)]}'
{"oslo_service/eventlet_backdoor.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"10b2bb671d54a3ad82e6ea75903a4c216c235450","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return eventlet.listen((host, port), reuse_port\u003dFalse)"},{"line_number":130,"context_line":"    except TypeError:"},{"line_number":131,"context_line":"        sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":132,"context_line":"        sock.bind((host, port))"},{"line_number":133,"context_line":"        sock.listen(50)"},{"line_number":134,"context_line":"        return sock"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_0c3dcbba","line":131,"updated":"2019-01-03 09:17:18.000000000","message":"I really think we should import eventlet.green.socket explicitly, and not rely on the socket module having been monkeypatched.","commit_id":"414b8b48a58844bc8abfbfa34b078fae2c80156b"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"854ea66afba289a984e6efb4f2f5a1e59941d040","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return eventlet.listen((host, port), reuse_port\u003dFalse)"},{"line_number":130,"context_line":"    except TypeError:"},{"line_number":131,"context_line":"        sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":132,"context_line":"        sock.bind((host, port))"},{"line_number":133,"context_line":"        sock.listen(50)"},{"line_number":134,"context_line":"        return sock"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_cabd5269","line":131,"in_reply_to":"ffd0ebdf_0c3dcbba","updated":"2019-01-04 04:33:07.000000000","message":"Agree. Thanks for the suggestion","commit_id":"414b8b48a58844bc8abfbfa34b078fae2c80156b"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"75383ab3156119d790370694a83fd04fc5628709","unresolved":false,"context_lines":[{"line_number":124,"context_line":"def _listen_func(host, port):"},{"line_number":125,"context_line":"    # eventlet is setting SO_REUSEPORT by default from v0.20."},{"line_number":126,"context_line":"    # But we can configure it by passing reuse_port argument"},{"line_number":127,"context_line":"    # from v0.22"},{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return eventlet.listen((host, port), reuse_port\u003dFalse)"},{"line_number":130,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_81ccddbc","line":127,"updated":"2019-01-09 18:24:32.000000000","message":".22 has been out for about a year now. I wonder if we could just bump our minimum requirement.","commit_id":"811650783d32accd2b49f907ddc520955146962c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"37e98c57f025443bad425dbff55c67bfc7a13cdf","unresolved":false,"context_lines":[{"line_number":124,"context_line":"def _listen_func(host, port):"},{"line_number":125,"context_line":"    # eventlet is setting SO_REUSEPORT by default from v0.20."},{"line_number":126,"context_line":"    # But we can configure it by passing reuse_port argument"},{"line_number":127,"context_line":"    # from v0.22"},{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return eventlet.listen((host, port), reuse_port\u003dFalse)"},{"line_number":130,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_4fbb6e71","line":127,"in_reply_to":"dfd5e7cf_230e4b32","updated":"2019-01-10 14:33:39.000000000","message":"Ah, backportability is a good reason to keep the compatibility logic. Sounds good.","commit_id":"811650783d32accd2b49f907ddc520955146962c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"040ef05b4ea256254e88ba7890549a611fb7c120","unresolved":false,"context_lines":[{"line_number":124,"context_line":"def _listen_func(host, port):"},{"line_number":125,"context_line":"    # eventlet is setting SO_REUSEPORT by default from v0.20."},{"line_number":126,"context_line":"    # But we can configure it by passing reuse_port argument"},{"line_number":127,"context_line":"    # from v0.22"},{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return eventlet.listen((host, port), reuse_port\u003dFalse)"},{"line_number":130,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_230e4b32","line":127,"in_reply_to":"dfd5e7cf_81ccddbc","updated":"2019-01-10 09:46:04.000000000","message":"Yes, that will be a good suggestion. Then our code here will be very simple i.e\n\ndef _listen_func(host, port):\n    eventlet.listen((host, port), reuse_port\u003dFalse)\n\nBut I want to backport this to stable branches. I felt backporting code to stable branches is easier than backporting lower-constraints.txt. Also many projects might have dependency on eventlet package version.\n\nLet me know If I have to change the lower-constraints.txt or existing change is fine.","commit_id":"811650783d32accd2b49f907ddc520955146962c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"75383ab3156119d790370694a83fd04fc5628709","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    except TypeError:"},{"line_number":131,"context_line":"        sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":132,"context_line":"        sock.bind((host, port))"},{"line_number":133,"context_line":"        sock.listen(50)"},{"line_number":134,"context_line":"        return sock"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_4174b568","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":22},"updated":"2019-01-09 18:24:32.000000000","message":"Is this valid? According to the Python docs \"the maximum value is system-dependent (usually 5)\". It\u0027s not clear to me if that applies to the eventlet version too, but I don\u0027t see anything that contradicts the stdlib docs either.","commit_id":"811650783d32accd2b49f907ddc520955146962c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"040ef05b4ea256254e88ba7890549a611fb7c120","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    except TypeError:"},{"line_number":131,"context_line":"        sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":132,"context_line":"        sock.bind((host, port))"},{"line_number":133,"context_line":"        sock.listen(50)"},{"line_number":134,"context_line":"        return sock"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_60a2094e","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":22},"in_reply_to":"dfd5e7cf_4174b568","updated":"2019-01-10 09:46:04.000000000","message":"Eventlet [1] is using 50 for backlog. When we replace eventet.listen() with our sock.listen, then we should use the same.\n\n[1] https://github.com/eventlet/eventlet/blob/master/eventlet/convenience.py#L34","commit_id":"811650783d32accd2b49f907ddc520955146962c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"37e98c57f025443bad425dbff55c67bfc7a13cdf","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    except TypeError:"},{"line_number":131,"context_line":"        sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":132,"context_line":"        sock.bind((host, port))"},{"line_number":133,"context_line":"        sock.listen(50)"},{"line_number":134,"context_line":"        return sock"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_cfa67e54","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":22},"in_reply_to":"dfd5e7cf_60a2094e","updated":"2019-01-10 14:33:39.000000000","message":"Fair enough, thanks for the explanation.","commit_id":"811650783d32accd2b49f907ddc520955146962c"}]}
