)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"946695ec1e27e8cd983ba75ea5423430a5760c3a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"we now expose the PID of the process as a format string argument,"},{"line_number":14,"context_line":"which can then be used like this:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"backdoor_socket \u003d /var/lib/neutron/backdoor-%(pid)s"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3f86f4867eb0cd5010abadf68620aa3450d3e64d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_03f17895","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":51},"updated":"2019-05-14 10:13:14.000000000","message":"I would be _very_ careful with these changes. oslo.config uses printf formatting for some strings so usually you have to escape the \u0027%\u0027 to make sure it makes it through. Have you tested this? If not, using \u0027String.format\u0027 style formatting might be a wiser move?\n\nIn any case, we could do with a unit test (assuming there are tests for this functionality).","commit_id":"76da379a96ecfac2a34430e585cb2b44d67095d2"}],"oslo_service/eventlet_backdoor.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"8d92fd9e904e8c5496bc2dd53b4f21dc4b7d50ba","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        socket_args \u003d {"},{"line_number":218,"context_line":"            \u0027pid\u0027: os.getpid(),"},{"line_number":219,"context_line":"        }"},{"line_number":220,"context_line":"        backdoor_socket_path \u003d conf.backdoor_socket.format(**socket_args)"},{"line_number":221,"context_line":"        sock \u003d _try_open_unix_domain_socket(backdoor_socket_path)"},{"line_number":222,"context_line":"        where_running \u003d backdoor_socket_path"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_0555681d","line":220,"range":{"start_line":220,"start_character":52,"end_line":220,"end_character":73},"updated":"2019-05-21 18:59:40.000000000","message":"er, why not\n\n  format(pid\u003dos.getpid())\n\n?","commit_id":"2250fc15ebec68a94fad810d7ce6c7da95a46d6f"},{"author":{"_account_id":30314,"name":"Sebastian Lohff","email":"sebastian.lohff@sap.com","username":"seba"},"change_message_id":"3b80904f5a572ac9b13c452426e9b554d4ef1c0a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        socket_args \u003d {"},{"line_number":218,"context_line":"            \u0027pid\u0027: os.getpid(),"},{"line_number":219,"context_line":"        }"},{"line_number":220,"context_line":"        backdoor_socket_path \u003d conf.backdoor_socket.format(**socket_args)"},{"line_number":221,"context_line":"        sock \u003d _try_open_unix_domain_socket(backdoor_socket_path)"},{"line_number":222,"context_line":"        where_running \u003d backdoor_socket_path"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_d7a2949a","line":220,"range":{"start_line":220,"start_character":52,"end_line":220,"end_character":73},"in_reply_to":"bfb3d3c7_0555681d","updated":"2019-05-22 13:22:16.000000000","message":"In my original patch (not presented in gerrit) I made a lot more format strings available while testing. I ended up only needing pid, but decided to leave it this way if we decided to add additional args. But it\u0027s not a problem to change it back.","commit_id":"2250fc15ebec68a94fad810d7ce6c7da95a46d6f"}]}