)]}'
{"id":"openstack%2Foslo.service~725327","triplet_id":"openstack%2Foslo.service~master~Ia903477064452129951fbb8c957beba306df1a79","project":"openstack/oslo.service","branch":"master","hashtags":[],"change_id":"Ia903477064452129951fbb8c957beba306df1a79","subject":"Align contributing doc with oslo\u0027s policy","status":"MERGED","created":"2020-05-04 16:31:32.000000000","updated":"2020-08-06 16:36:18.000000000","submitted":"2020-08-06 16:32:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"725327-1596731559912-ea02c699","meta_rev_id":"5c89acd47ebd38110caf8ebf17d7c347158f51ab","_number":725327,"virtual_id_number":725327,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2020-05-11 14:49:50.000000000","_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-06 16:32:39.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"disliked":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"all":[{"value":-1,"date":"2020-05-07 15:11:26.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":2,"date":"2020-07-20 15:39:52.000000000","_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":2,"date":"2020-08-06 15:04:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":1,"date":"2020-08-06 15:04:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-07 15:11:26.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"},{"updated":"2020-07-20 15:39:52.000000000","updated_by":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"reviewer":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"state":"REVIEWER"},{"updated":"2020-08-06 15:04:44.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-08-06 16:32:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cb62d78d42e6caf0dd95feef18134862366e5c56","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-05-04 16:31:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"353e4eb8c46d54c26b23852257946da0cfc8b252","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-04 16:37:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/70f9688b6d6c427389a06c115d3e3d99 : SUCCESS in 4m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c9565932af54f66acf81542670bfd11 : SUCCESS in 4m 50s","accounts_in_message":[],"_revision_number":1},{"id":"cfc866caeb6ca52bc57a3dd4c6c9b8aa89d11c39","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-05-05 12:31:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"978ef4c262238cfd1134bd3c55a06432c92d1713","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-05 12:40:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/71245fb614254f70890a609f8e7e074e : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/484c31eaad80454f863e4851be061894 : SUCCESS in 5m 23s","accounts_in_message":[],"_revision_number":2},{"id":"b81b17439f9d50ba5fe237fb0b3101c44b0aaa89","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2020-05-07 15:11:26.000000000","message":"Patch Set 2: Code-Review-1\n\nThis doesn\u0027t match the template for the goal:\n\nhttps://opendev.org/openstack/cookiecutter/src/branch/master/%7b%7bcookiecutter.repo_name%7d%7d/CONTRIBUTING.rst","accounts_in_message":[],"_revision_number":2},{"id":"4a813e2e5208fc99c685e6f65adfae51c141e7d2","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-05-07 19:14:20.000000000","message":"Patch Set 2:\n\n\u003e This doesn\u0027t match the template for the goal:\n \u003e \n \u003e https://opendev.org/openstack/cookiecutter/src/branch/master/%7b%7bcookiecutter.repo_name%7d%7d/CONTRIBUTING.rst\n\nThe goal here is to centralize contribution guidelines under oslo-specs (see links in commit message), so my goal here is just to point on that.\n\nWe will update the cookiecutter in a second time to match the oslo-specs policy and I\u0027ll drop the previous historical content when this one [1] will be merge (but not before to stay synced for now).\n\nBut indeed you are right we need to align the cookiecutter part.\n\n[1] https://review.opendev.org/#/c/725616/","accounts_in_message":[],"_revision_number":2},{"id":"445175f65a9aa2b368f8e02c79942b4a3245523a","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2020-05-08 16:28:43.000000000","message":"Patch Set 2:\n\nThe cookiecutter template has a place (on the last line) for linking to the project-specific contributor documentation for the project (in our case in the oslo-specs docs). I\u0027m not clear on why we would add the link in a different format and then reformat it, as opposed to just adopting the standardised format with the link in it straight away?","accounts_in_message":[],"_revision_number":2},{"id":"f5ff05104cd2b65883596fc90f488fb387040057","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-05-11 14:49:50.000000000","message":"Patch Set 2:\n\n\u003e The cookiecutter template has a place (on the last line) for\n \u003e linking to the project-specific contributor documentation for the\n \u003e project (in our case in the oslo-specs docs). I\u0027m not clear on why\n \u003e we would add the link in a different format and then reformat it,\n \u003e as opposed to just adopting the standardised format with the link\n \u003e in it straight away?\n\nThanks Zane for your feedback.\n\nI guess you speak about this one [1] (openstack/cookiecutter), I\u0027m right?\n\nSo, I wondering if we should converge `openstack/cookiecutter` and `openstack/oslo-cookiecutter`\u0027s contribution guide [2]...\n\noslo.service is an oslo project and the oslo-cookiecutter project doesn\u0027t reflect this (the project specific contributor documentation), or a I missed something. It simply refer to the CONTRIBUTING.rst [3] file which is similar to this one.\n\nThe oslo-specs contribution guide looks quite similar to the `openstack/cookiecutter` contribution guide template, and for oslo keep the things in the contribution/cookiecutter template guide will ask to us to continue to update each project at each change to follow the template and this is that we want to avoid by moving the contribution guide to oslo-specs (and just refer to this one).\n\nIt\u0027s not an issue for me to abandon these changes I simply want to align all the documentations to centralize things in one place and stop to submit changes to ~40 projects.\n\nWhat do you think about the oslo-cookiecutter side?\n\nThoughts?\n\n(I hope I correctly understand your comment)\n\n[1] https://github.com/openstack/cookiecutter/blob/master/%7B%7Bcookiecutter.repo_name%7D%7D/doc/source/contributor/contributing.rst\n[2] https://github.com/openstack/oslo-cookiecutter/blob/master/oslo.%7B%7Bcookiecutter.module_name%7D%7D/doc/source/contributing.rst\n[3] https://github.com/openstack/oslo-cookiecutter/blob/master/oslo.%7B%7Bcookiecutter.module_name%7D%7D/CONTRIBUTING.rst","accounts_in_message":[],"_revision_number":2},{"id":"3c67d9013da7b2a4af7bbd512f7ef887af9dc381","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2020-05-11 15:26:27.000000000","message":"Patch Set 2:\n\n\u003e I guess you speak about this one [1] (openstack/cookiecutter), I\u0027m right?\n\u003e [1] https://github.com/openstack/cookiecutter/blob/master/%7B%7Bcookiecutter.repo_name%7D%7D/doc/source/contributor/contributing.rst\n\nNo, the one I linked: https://opendev.org/openstack/cookiecutter/src/branch/master/%7b%7bcookiecutter.repo_name%7d%7d/CONTRIBUTING.rst\n\nI didn\u0027t know about oslo-cookiecutter, but I think it would make sense to align the CONTRIBUTING.rst there with the latest from openstack-cookiecutter.","accounts_in_message":[],"_revision_number":2},{"id":"89c51ed31607c31ae2dad6cd0147d562595bd685","author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"date":"2020-07-20 15:39:52.000000000","message":"Patch Set 2: Code-Review+2\n\nI think this one can merge, as we merged several others in oslo with the same change. But we should also update the cookiecutter.","accounts_in_message":[],"_revision_number":2},{"id":"7624f399b8bb3123fe2fa53dc4c3a2160a516995","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-06 15:04:44.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nWhat Moisés said","accounts_in_message":[],"_revision_number":2},{"id":"13226686ec5e2781a2e95094d8e0b41c31295e06","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-06 15:04:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"10c0752577821bb68c0678701467c856c0787799","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-06 16:32:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c9ab234bc982842dcfd7d76c1d6dbcfacbf1ad85","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-06 16:32:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/11b087ecaf524e16978ca587ba51ddc3 : SUCCESS in 5m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f62b8f1957b0484e8b824305f03aecba : SUCCESS in 4m 17s","accounts_in_message":[],"_revision_number":2},{"id":"5c89acd47ebd38110caf8ebf17d7c347158f51ab","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-06 16:36:18.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee4b762fb3bd49838d347d4d25d90da8 : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"598d5ab74af38313776f7da34508009deb2b52bb","revisions":{"1946bd1f3483f6e4d529a41b70f6ada9ff8958ce":{"kind":"REWORK","_number":1,"created":"2020-05-04 16:31:32.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/27/725327/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.service","ref":"refs/changes/27/725327/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/1"}}},"commit":{"parents":[{"commit":"f6781bf057102d1f0a12adf212dce2a3303ffa9f","subject":"Merge \"Add py38 package metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.service/commit/f6781bf057102d1f0a12adf212dce2a3303ffa9f"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-05-04 16:31:13.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-05-04 16:31:13.000000000","tz":120},"subject":"Align contributing doc with oslo\u0027s policy","message":"Align contributing doc with oslo\u0027s policy\n\nRelated to:\n- https://review.opendev.org/#/c/723044/\n- https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html\n\nChange-Id: Ia903477064452129951fbb8c957beba306df1a79\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.service/commit/1946bd1f3483f6e4d529a41b70f6ada9ff8958ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.service/commit/1946bd1f3483f6e4d529a41b70f6ada9ff8958ce"}]},"branch":"refs/heads/master"},"598d5ab74af38313776f7da34508009deb2b52bb":{"kind":"REWORK","_number":2,"created":"2020-05-05 12:31:13.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/27/725327/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.service","ref":"refs/changes/27/725327/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.service refs/changes/27/725327/2"}}},"commit":{"parents":[{"commit":"f6781bf057102d1f0a12adf212dce2a3303ffa9f","subject":"Merge \"Add py38 package metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.service/commit/f6781bf057102d1f0a12adf212dce2a3303ffa9f"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-05-04 16:31:13.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-05-05 12:31:05.000000000","tz":120},"subject":"Align contributing doc with oslo\u0027s policy","message":"Align contributing doc with oslo\u0027s policy\n\nRelated to:\n- https://review.opendev.org/#/c/723044/\n- https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html\n\nChange-Id: Ia903477064452129951fbb8c957beba306df1a79\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.service/commit/598d5ab74af38313776f7da34508009deb2b52bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.service/commit/598d5ab74af38313776f7da34508009deb2b52bb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}