)]}'
{"oslo_service/periodic_task.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26d475b34cd03e2ebc17e58ff33bbb4c8c325aa6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    return current_time - offset + jitter"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class PeriodicTasks(object, metaclass\u003d_PeriodicTasksMeta):"},{"line_number":172,"context_line":"    def __init__(self, conf):"},{"line_number":173,"context_line":"        super(PeriodicTasks, self).__init__()"},{"line_number":174,"context_line":"        self.conf \u003d conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b369c88c","line":171,"range":{"start_line":171,"start_character":20,"end_line":171,"end_character":28},"updated":"2020-05-26 12:48:26.000000000","message":"You don\u0027t actually need this now","commit_id":"ef1d87b25da1a1fef7a60f8a6a3d5bc499b73c41"}],"oslo_service/service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26d475b34cd03e2ebc17e58ff33bbb4c8c325aa6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                        % {\u0027service\u0027: service, \u0027base\u0027: ServiceBase})"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class ServiceBase(object, metaclass\u003dabc.ABCMeta):"},{"line_number":93,"context_line":"    \"\"\"Base class for all services.\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_1304f4c5","line":92,"range":{"start_line":92,"start_character":18,"end_line":92,"end_character":26},"updated":"2020-05-26 12:48:26.000000000","message":"ditto (and below)","commit_id":"ef1d87b25da1a1fef7a60f8a6a3d5bc499b73c41"}],"oslo_service/tests/test_wsgi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26d475b34cd03e2ebc17e58ff33bbb4c8c325aa6","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    key_file\u003dkey_file_name,"},{"line_number":280,"context_line":"                    group\u003dsslutils.config_section)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @testtools.skipIf(six.PY3, \"bug/1482633: test hangs on Python 3\")"},{"line_number":283,"context_line":"    def test_ssl_server(self):"},{"line_number":284,"context_line":"        def test_app(env, start_response):"},{"line_number":285,"context_line":"            start_response(\u0027200 OK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_93f764d5","side":"PARENT","line":282,"updated":"2020-05-26 12:48:26.000000000","message":"I wonder should we try to fix these rather than deleting them? If we don\u0027t have time to do that now, we could just change it to skip instead instead of skipIf","commit_id":"1348749dd514581acf37c20f00aeb494506b6214"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"471ebc3bef6453b5f9805b79e3eb4c4bf45b48c9","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    key_file\u003dkey_file_name,"},{"line_number":280,"context_line":"                    group\u003dsslutils.config_section)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @testtools.skipIf(six.PY3, \"bug/1482633: test hangs on Python 3\")"},{"line_number":283,"context_line":"    def test_ssl_server(self):"},{"line_number":284,"context_line":"        def test_app(env, start_response):"},{"line_number":285,"context_line":"            start_response(\u0027200 OK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e11d2374","side":"PARENT","line":282,"in_reply_to":"ff570b3c_7e1d370e","updated":"2020-05-26 16:07:02.000000000","message":"Good news (or not) \u003d\u003e https://github.com/eventlet/eventlet/issues/526","commit_id":"1348749dd514581acf37c20f00aeb494506b6214"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3ff12010776d5db49471ac2f941f1b76346c6c98","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    key_file\u003dkey_file_name,"},{"line_number":280,"context_line":"                    group\u003dsslutils.config_section)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @testtools.skipIf(six.PY3, \"bug/1482633: test hangs on Python 3\")"},{"line_number":283,"context_line":"    def test_ssl_server(self):"},{"line_number":284,"context_line":"        def test_app(env, start_response):"},{"line_number":285,"context_line":"            start_response(\u0027200 OK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7e1d370e","side":"PARENT","line":282,"in_reply_to":"ff570b3c_93f764d5","updated":"2020-05-26 13:23:02.000000000","message":"\u003e I wonder should we try to fix these rather than deleting them? If\n \u003e we don\u0027t have time to do that now, we could just change it to skip\n \u003e instead instead of skipIf\n\nSo for now my goal is just to drop six so I prefer to use `skip` rather than try to fix issues here.\n\nI\u0027ll try to address hanging in a follow up patch.","commit_id":"1348749dd514581acf37c20f00aeb494506b6214"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"52dd1dc54d0f5fe7c574baa8ae62c565cc2cc865","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    key_file\u003dkey_file_name,"},{"line_number":280,"context_line":"                    group\u003dsslutils.config_section)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @testtools.skipIf(six.PY3, \"bug/1482633: test hangs on Python 3\")"},{"line_number":283,"context_line":"    def test_ssl_server(self):"},{"line_number":284,"context_line":"        def test_app(env, start_response):"},{"line_number":285,"context_line":"            start_response(\u0027200 OK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b3ec28f4","side":"PARENT","line":282,"in_reply_to":"ff570b3c_93f764d5","updated":"2020-05-26 12:50:07.000000000","message":"I agree. If this still hangs, that is a little concerning now that we are py3-only.\n\nThough I\u0027m not a fan of spinning up a server inside a unit test.","commit_id":"1348749dd514581acf37c20f00aeb494506b6214"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1d18304cec490502d4fb8cca75c2ac2dda7499a8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    key_file\u003dkey_file_name,"},{"line_number":280,"context_line":"                    group\u003dsslutils.config_section)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @testtools.skipIf(six.PY3, \"bug/1482633: test hangs on Python 3\")"},{"line_number":283,"context_line":"    def test_ssl_server(self):"},{"line_number":284,"context_line":"        def test_app(env, start_response):"},{"line_number":285,"context_line":"            start_response(\u0027200 OK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_fffdbe08","side":"PARENT","line":282,"in_reply_to":"ff570b3c_e11d2374","updated":"2020-05-26 16:52:50.000000000","message":"Fixed by https://review.opendev.org/#/c/730884/","commit_id":"1348749dd514581acf37c20f00aeb494506b6214"}]}