)]}'
{"oslo_service/__init__.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ee26573bd765318a254fbc58bf39587581ec7738","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os.environ[\u0027EVENTLET_HUB\u0027] \u003d \u0027oslo_service:service_hub\u0027"},{"line_number":34,"context_line":"# reset hub in case it was initialized already by some imported module"},{"line_number":35,"context_line":"eventlet.hubs.use_hub()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7c70b141","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":23},"updated":"2020-09-30 09:40:49.000000000","message":"I\u0027m not familiar with hubs, is it not more appropriate to move these line inside the `service_hub` function?\n\nAs it will be called at each calling of this function, thoughts?","commit_id":"02fe0ba65baf2b3dc2543781c8ce0d65f443b9fb"},{"author":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"change_message_id":"bbc06d5f8612bad5ad6b6e4f984ea3367c506cb6","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os.environ[\u0027EVENTLET_HUB\u0027] \u003d \u0027oslo_service:service_hub\u0027"},{"line_number":34,"context_line":"# reset hub in case it was initialized already by some imported module"},{"line_number":35,"context_line":"eventlet.hubs.use_hub()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a246a44f","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":23},"in_reply_to":"9f560f44_7c70b141","updated":"2020-10-08 12:17:23.000000000","message":"I don\u0027t think so. This line is actually a \"commit\" for the line above.\nThe use_hub() function will take the hub definition from EVENTLET_HUB and replace current hub with that.\nWithout this, the EVENTLET_HUB variable will be used only if there was no hub created before it was set.\n\nEDIT: if it makes things more understandable, we can change it to: \"eventlet.hubs.use_hub(os.environ[\u0027EVENTLET_HUB\u0027])\" or \"eventlet.hubs.use_hub(\u0027oslo_service:service_hub\u0027)\" which will do exactly the same thing as the call without arguments.","commit_id":"02fe0ba65baf2b3dc2543781c8ce0d65f443b9fb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e015380279678a055e316b5d550d0892c7e825b1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os.environ[\u0027EVENTLET_HUB\u0027] \u003d \u0027oslo_service:service_hub\u0027"},{"line_number":34,"context_line":"# reset hub in case it was initialized already by some imported module"},{"line_number":35,"context_line":"eventlet.hubs.use_hub()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_fff93380","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":23},"in_reply_to":"9f560f44_a246a44f","updated":"2020-10-26 16:38:02.000000000","message":"Thanks to took the time to bring details :)\n\nFor the sake of completude (and verbosity on things that are done by doing that) I personally prefer to add one of the params that you suggested. Why not the one based on environment, thoughts?","commit_id":"02fe0ba65baf2b3dc2543781c8ce0d65f443b9fb"}]}