)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0c3347325387913f77f14e75c05a1359704628f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"runtimes doesn\u0027t yet support it and so we will skip the test, and so, that"},{"line_number":14,"context_line":"don\u0027t make much sense to skip it as the goal is to return a boolean"},{"line_number":15,"context_line":"if python support it. Feel free to propose alternative on this point."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"https://en.wikipedia.org/wiki/Federal_Information_Processing_Standards"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I93cf07b4ff174ed02c4afbf073c6d5931c48742c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c1cfa87_a90a802d","line":16,"updated":"2021-10-05 10:42:27.000000000","message":"We can mock the attribute of the SSL library, no?","commit_id":"fed5a00c48adc13110bb9f06d3c8b455a0513e5d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"77ef518cd1bb130eca4a9d4b26811f1fbdaeb3ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea434762_b4b9dea3","updated":"2022-07-22 00:22:53.000000000","message":"I\u0027ve failed to find the document about the related python bindings so I might be asking a dumb question. If you can share any pointer to documents.","commit_id":"dcfeb7424ca6d1080b07ef4e6df30c83db72f09b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c6a12995cd88791349e9dceccb2840a27f90facc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60651e10_10c2fb7b","in_reply_to":"ea434762_b4b9dea3","updated":"2022-07-29 10:18:50.000000000","message":"I think this is a downstream-only thing. I found a couple of unmerged patches related to this and I guess those have been included in RHEL? However, it does seem like this is exposed upstream now via the \u0027_hashlib\u0027 module [1]. I guess we should be using that instead?\n\n[1] https://github.com/python/cpython/pull/19703","commit_id":"dcfeb7424ca6d1080b07ef4e6df30c83db72f09b"}],"oslo_service/sslutils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"77ef518cd1bb130eca4a9d4b26811f1fbdaeb3ae","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def fips_is_supported():"},{"line_number":55,"context_line":"    \"\"\"Check if OpenSSL FIPS mode is supported.\"\"\""},{"line_number":56,"context_line":"    return getattr(ssl, \u0027FIPS_mode\u0027, False)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def is_enabled(conf):"}],"source_content_type":"text/x-python","patch_set":2,"id":"80a5fdaa_46159b5d","line":56,"range":{"start_line":56,"start_character":25,"end_line":56,"end_character":34},"updated":"2022-07-22 00:22:53.000000000","message":"is ssl.FIPS_mode callable ? then I think we can use hasattr instead of getattr here which avoids passing the object.\n\nAlso, just in case you intend to return status of fips mode, this function should be named _enabled instead of _supported.","commit_id":"dcfeb7424ca6d1080b07ef4e6df30c83db72f09b"}]}