)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3e643f06324a3cbf26e7b27ac650a36259649035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9da87e5b_5d29a6ec","updated":"2024-03-06 22:01:45.000000000","message":"An example of where this is important is https://review.opendev.org/c/openstack/neutron/+/911625 where without this, ovn hash ring entries would occasionally not be cleaned up.","commit_id":"89b35701804eb818be1c1f1ff1daedef01140ea3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ef0d1a980d6b7896c509c7b1d6bbb053387defe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a1bf55d_3bd212d4","updated":"2024-03-11 09:13:55.000000000","message":"Could be possible to backport this patch in order to have it in previous releases?","commit_id":"bd7e57789fd2c8641b303341afe749c6983767db"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61242d1c9fc60405e04141aca8096038e9fdaaf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52aa17ff_e004a402","updated":"2024-03-13 15:47:33.000000000","message":"I would just put a related-bug link in the commit message","commit_id":"bd7e57789fd2c8641b303341afe749c6983767db"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"28b7785e44556f051ae54575d72f3f50af852321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f29977e8_c501fb64","in_reply_to":"2a1bf55d_3bd212d4","updated":"2024-03-13 16:00:43.000000000","message":"I very much hope so.","commit_id":"bd7e57789fd2c8641b303341afe749c6983767db"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ebe8400373d501772cdbef06a9a45c33d1da4f3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ebe7f359_2afae48f","updated":"2024-03-13 16:24:59.000000000","message":"I understand the overall idea, but I\u0027m not yet fully confident that we can always assume that additional handlers are registered AFTER the handlers are registered by process/service launchers. One option we have is adding \"order\" field and sort handlers by orders.\n\nI\u0027ll give more thoughts on this, but I\u0027d like to hear thoughts from the others, in case anyone else has detailed view about the logic order...","commit_id":"d026081ca44ad7d48cd4cceeb6df767512910d96"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3db28a7fc5a2d2a802037ed709429578d1bf2609","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"addfa4d2_bad1677a","in_reply_to":"4eb5e922_18ef16b1","updated":"2024-03-15 16:28:49.000000000","message":"Perhaps some runtime asserts on the order of the list could alleviate some concerns here?..","commit_id":"d026081ca44ad7d48cd4cceeb6df767512910d96"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88a16257d532046fe214f5a193e2c0a94f9ca4b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec87f845_ff47f27a","in_reply_to":"addfa4d2_bad1677a","updated":"2024-03-15 16:35:22.000000000","message":"OK I confirmed the said behavior. I think we can move ahead with the current proposal and revisit the mechanism later if needed.","commit_id":"d026081ca44ad7d48cd4cceeb6df767512910d96"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"70666f6e4755d9b54784b2c6f46cefb53e3c0965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4eb5e922_18ef16b1","in_reply_to":"ebe7f359_2afae48f","updated":"2024-03-13 17:04:41.000000000","message":"Thanks for taking a look!\n\noslo_service currently would guarantee that the first stored in the list are its own (by clearing the list when before calling self.handle_signal()/add_handler() etc.). It looks like the child process signal handlers were added before the child process was launched in _child_process(). So I *think* they\u0027re guaranteed to be before any that the process would set at runtime? If there were SignalHandler handlers registered at import that got copied over with a fork, it seems like those could be cleared. But that seems like behavior that should be avoided anyway and we could document that limitation.\n\nThis isn\u0027t functionality that is being used much. I only saw it in cinder and the neutron patch I added. In any case, ordered \u003e random. 😄","commit_id":"d026081ca44ad7d48cd4cceeb6df767512910d96"}]}