)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"498308faa6f7fd400b03649aebc516e68ccc8589","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix threading-related test flakiness in oslo.service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improve the reliability of tests that depend on threading, as they were failing intermittently in certain local environments."},{"line_number":10,"context_line":"- Adjust `test_stop_current_thread` to ensure threads are properly joined and tested for completion."},{"line_number":11,"context_line":"- Modify `test_stop_immediately` to explicitly validate thread termination."},{"line_number":12,"context_line":"- Use `stop(graceful\u003dTrue)` and `timeout` where appropriate to avoid indefinite waits."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"These changes ensure consistency across different threading environments and align with expected test behavior."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I097ceabadae9878441fd1887093e1d81c88a411a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ca8f76bb_d99aed76","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":111},"updated":"2024-12-19 15:33:42.000000000","message":"Please wrap lines at 72 chars to keep the git history well formatted.\n\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d0931f14e51a29222ddaaa66b691cc6b4aeeadab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f5b0a05_4d686199","updated":"2024-12-18 13:26:06.000000000","message":"should be rebased over the latest version of its parent patch, or detached to the chain of parentality... as you prefer.","commit_id":"955aa5d1a5518d128458a5c87f6c97e578c370be"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"9baebd78f274a0b8f501240b2747a9ddd1eab139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36fd1053_299e5c49","in_reply_to":"6f5b0a05_4d686199","updated":"2024-12-19 11:41:23.000000000","message":"Done.","commit_id":"955aa5d1a5518d128458a5c87f6c97e578c370be"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"31b1aa4d5d029f7bad86dd776e2d2d957f93cbe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7d2e0d1_108a6508","updated":"2025-01-14 14:08:26.000000000","message":"@Daniel: Removing my vote because Takashi made good observations","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"58180e4a93e4bc9f16a064fc860f46a635ef1dc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe13af46_0aa646bb","updated":"2025-01-16 11:09:46.000000000","message":"I will work back on that after the merge of the backend.","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1edf1205c9fe96b2f3c890f93e8aba60c7577452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b784ac48_d35cb062","updated":"2024-12-19 12:18:57.000000000","message":"I wonder why this patch is still in the relation chain and the ancient parent patch is stillseen as \"Not current\". Have you rebased over the parent patch or extrayed this one of the relation chain?","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c53ba3cd2d259256d3450bc97741a82d1c993ebc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c203bdc_91f1126d","in_reply_to":"130fff57_cdb65400","updated":"2024-12-19 13:45:27.000000000","message":"Lets try to merge it.","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"9e8abcc1ca58dc6db01cce7dc6ff5b4f044b7d5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"130fff57_cdb65400","in_reply_to":"b784ac48_d35cb062","updated":"2024-12-19 12:42:44.000000000","message":"I’m not sure why this is happening, I did rebase from the parent commit. Honestly, I don’t think this impacts the patch itself, but let me know if there’s anything I should check further.","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"}],"oslo_service/tests/test_threadgroup.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"498308faa6f7fd400b03649aebc516e68ccc8589","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        stop_event.wait(timeout\u003d2)"},{"line_number":110,"context_line":"        quit_event.send(\u0027quit_event\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.tg.stop(graceful\u003dTrue)"},{"line_number":113,"context_line":"        self.assertEqual(0, len(self.tg.threads))"},{"line_number":114,"context_line":"        self.tg.wait()"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b56d6e70_aafb2101","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":35},"updated":"2024-12-19 15:33:42.000000000","message":"I\u0027m unsure calling stop outside of thread is what this test case aims to test. It looks like the previous implementation which calls stop FROM thread looks appropriate.","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"498308faa6f7fd400b03649aebc516e68ccc8589","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        thread \u003d self.tg.add_thread(foo, \u0027arg\u0027, kwarg\u003d\u0027kwarg\u0027)"},{"line_number":158,"context_line":"        time.sleep(0.1)"},{"line_number":159,"context_line":"        self.tg.stop(graceful\u003dFalse)  # Stop immediately without waiting"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.assertTrue(thread.thread.dead)"},{"line_number":162,"context_line":"        self.assertEqual(0, len(self.tg.threads))"}],"source_content_type":"text/x-python","patch_set":2,"id":"875ea82f_394f3730","line":159,"range":{"start_line":159,"start_character":16,"end_line":159,"end_character":20},"updated":"2024-12-19 15:33:42.000000000","message":"This test case should test cancel. Don\u0027t replace it by stop","commit_id":"529726cef442fb786090dc06a9659bb63b7503dc"}]}