)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1952ddb676244001409e944e1c3dc8288262d147","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04bc5979_35740731","updated":"2025-07-15 13:52:21.000000000","message":"As I pointed in my inline comment, I\u0027m unsure about the benefit of boarding the wsgi module to the backend system. We do not provide the threading implementation for wsgi module and the backend selection does not look really meaningful.","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"65260dac59d068644cd430142437aef436bc1843","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b9f5baf_74a22314","updated":"2025-07-16 15:42:39.000000000","message":"New version moved here https://review.opendev.org/c/openstack/oslo.service/+/955199","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"280f99f888f41838da33cdd530078a680d6f42d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4977d42a_8811f9de","in_reply_to":"04bc5979_35740731","updated":"2025-07-15 13:55:26.000000000","message":"If we want to prohibit users from using the wsgi server in threading mode then we can add that validation. My concern is this change brings large effrt on module structure for quite tiny benefit, IMHO.","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"626c9561f7eb45f5a1cc0f419acc3f0c553a159c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c90c7c4c_0482844b","in_reply_to":"4977d42a_8811f9de","updated":"2025-07-16 08:27:47.000000000","message":"Indeed, the main difference between backends is that the threading backend mostly rely on the wsgi common module with no specific code.\n\nI\u0027m not sure to see how to validate parts of this module when one backend or the other is used, please can you develop?\n\nYou want to check which backend is in use and then to raise an error?\n\nAlso, side question, I\u0027m not sure to see what is the \"large effort on module structure\" beyond merging this patch, please develop this point, just to ensure that I not missed to take account of some aspects.","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a545fd1292ff5761ee6a408044920b9280efacb2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"333cf4da_544a7576","in_reply_to":"4d481489_6eba57d6","updated":"2025-07-16 11:57:55.000000000","message":"I see, thanks for your answer. Then let\u0027s abandon this patch. I\u0027ll see to implement a detection like the one you suggest.","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b49d2ecad9db967f24db7fbd59e8b7bed790195b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d481489_6eba57d6","in_reply_to":"c90c7c4c_0482844b","updated":"2025-07-16 08:50:24.000000000","message":"\u003e I\u0027m not sure to see how to validate parts of this module when one backend or the other is used, please can you develop?\n\nYou can call oslo_service.backend.get_backend_type to detect the service backend used.\n\n\u003e You want to check which backend is in use and then to raise an error?\n\n\u003e Also, side question, I\u0027m not sure to see what is the \"large effort on module structure\" beyond merging this patch, please develop this point, just to ensure that I not missed to take account of some aspects.\n\nWe are not providing thread-base implementation for wsgi server. This means that we may drop the whole server implementation once we drop eventlet code and we keep only common code. My concern is that introducing backend system and also new structure for wsgi module is overkilling, unless we have a clear requirement to do so now (like we had for the other module which provides switch-able backends)","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"}],"oslo_service/backend/common/wsgi_utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"173c1dcfc9bedb9d5f6e19d204820272252908b9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2024 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"a35eb983_d90a3a6c","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2025-07-15 13:49:35.000000000","message":"I wonder what\u0027s the benefit of adding this new module. Can we just leave these to the existing wsgi.py instead ?","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"626c9561f7eb45f5a1cc0f419acc3f0c553a159c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2024 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"b9c56c5c_d6bcd82e","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"a35eb983_d90a3a6c","updated":"2025-07-16 08:27:47.000000000","message":"This new module aim to transfer the common parts of the old wsgi module that should not be removed due to fact that they are not really related to eventlet, see Stephen\u0027s proposal https://review.opendev.org/c/openstack/oslo.service/+/954055\n\nStephen emitted the idea to create oslo.(w|a)sgi and then to transfer this module to this new oslo library.","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cbe7c63c24f03a3050db37f1371c3ecb23dd15dd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2024 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"06051bfe_58e6ff48","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"b9c56c5c_d6bcd82e","updated":"2025-07-16 08:30:31.000000000","message":"Indeed, they can just leave to the existing wsgi.py, this is what we did until now and apparently it works. I was thinking that as we have 2 diverging implementations of the wsgi module, then that would be worth to manage it via the backend logic.","commit_id":"94bf10fa9250dfa62d41c7a95a2d3625f2e37436"}]}