)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ba4f0bec43ad4b4c2d54e69d8dca5511d983aa3f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cgibi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-07 17:12:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Synch Service.launch() signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The two backend had different effective signature due to threading has"},{"line_number":10,"context_line":"no_fork while eventlet did not accepted that. This made complicated to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a9bf0a2_7cbd7031","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2025-11-07 16:34:52.000000000","message":"Sync","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"60f897b1344e71a07585a66220681badd24db2de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cgibi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-07 17:12:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Synch Service.launch() signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The two backend had different effective signature due to threading has"},{"line_number":10,"context_line":"no_fork while eventlet did not accepted that. This made complicated to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4f2c64f9_303e81da","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"21953380_48689e59","updated":"2025-11-11 16:26:30.000000000","message":"Done","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"753458e6cd5557e05fd1512bcd3c2bbf9adaa1fc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cgibi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-07 17:12:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Synch Service.launch() signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The two backend had different effective signature due to threading has"},{"line_number":10,"context_line":"no_fork while eventlet did not accepted that. This made complicated to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"21953380_48689e59","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"7a9bf0a2_7cbd7031","updated":"2025-11-10 13:11:29.000000000","message":"I will fix it if I need to respin","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ba4f0bec43ad4b4c2d54e69d8dca5511d983aa3f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Synch Service.launch() signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The two backend had different effective signature due to threading has"},{"line_number":10,"context_line":"no_fork while eventlet did not accepted that. This made complicated to"},{"line_number":11,"context_line":"use the same launch call regardless of the backend for services that"},{"line_number":12,"context_line":"does not want to fork."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So this patch added **kwargs to the eventlet version to accept and"},{"line_number":15,"context_line":"ignore the no_fork flag. This keeps backward compatibility but allows"},{"line_number":16,"context_line":"the caller to use the same call to get no forking behavior."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6ed306c2c1deb0e298b384d404e1ee573f60fb71"},{"line_number":19,"context_line":"Signed-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bdc944ae_a9f81bb5","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":59},"updated":"2025-11-07 16:34:52.000000000","message":"```\nThe two backends had different effective signatures because\nthe threading backed support no_fork while the eventlet backend\ndid not accept that. This made it complicated to use the same\nlaunch call regardless of the backend for services that\ndo not want to fork.\n\nSo, this patch added **kwargs to the eventlet version to accept\nand ignore the no_fork flag. This keeps backward compatibility\nbut allows the caller to use the same call to get no-forking behavior.\n```\n\nwith that said the signiture of launch should be more concreatly defeind\n\ni was expting to find it here\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L41\nor here https://github.com/openstack/oslo.service/blob/master/oslo_service/backend/_common/service.py\nor here\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/backend/base.py#L44\n\ngiven there is ment to be a common interface defintion  but that seams to not have been how this was actully implemented  despite teh intet of https://specs.openstack.org/openstack/oslo-specs/specs/epoxy/remove-eventlet-from-oslo-service.html to make the backedns switchiable via a common api.\n\nim not askign you to nessiarly fix that just poihnt out this is a lot less well defiend then i was expecting.","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"60f897b1344e71a07585a66220681badd24db2de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Synch Service.launch() signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The two backend had different effective signature due to threading has"},{"line_number":10,"context_line":"no_fork while eventlet did not accepted that. This made complicated to"},{"line_number":11,"context_line":"use the same launch call regardless of the backend for services that"},{"line_number":12,"context_line":"does not want to fork."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So this patch added **kwargs to the eventlet version to accept and"},{"line_number":15,"context_line":"ignore the no_fork flag. This keeps backward compatibility but allows"},{"line_number":16,"context_line":"the caller to use the same call to get no forking behavior."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6ed306c2c1deb0e298b384d404e1ee573f60fb71"},{"line_number":19,"context_line":"Signed-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6fca0436_9a428c05","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":59},"in_reply_to":"a508289c_93fae1eb","updated":"2025-11-11 16:26:30.000000000","message":"Done","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"753458e6cd5557e05fd1512bcd3c2bbf9adaa1fc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Synch Service.launch() signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The two backend had different effective signature due to threading has"},{"line_number":10,"context_line":"no_fork while eventlet did not accepted that. This made complicated to"},{"line_number":11,"context_line":"use the same launch call regardless of the backend for services that"},{"line_number":12,"context_line":"does not want to fork."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So this patch added **kwargs to the eventlet version to accept and"},{"line_number":15,"context_line":"ignore the no_fork flag. This keeps backward compatibility but allows"},{"line_number":16,"context_line":"the caller to use the same call to get no forking behavior."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6ed306c2c1deb0e298b384d404e1ee573f60fb71"},{"line_number":19,"context_line":"Signed-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a508289c_93fae1eb","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":59},"in_reply_to":"bdc944ae_a9f81bb5","updated":"2025-11-10 13:11:29.000000000","message":"yeah there is no common interface def. There is a conditional bring-an-interface-into-scope logic in the generic service.py. So it pulls in two different function with different args depending on the backend. Yeah. This patch will not refactor the generic service.py to define explicit python interfaces. I encourage you to file a separate bug for that work.","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9a2a3552c9019b9a999f118301fe641ce838c78a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58801f46_a5788b2d","updated":"2025-11-11 14:45:45.000000000","message":"Alternatively we can explicitly add no_fork arg there but I\u0027m fine with kwargs approach.","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"31594d8a419838208272f24d68c5a5aac1892f20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d726883a_e0427717","updated":"2025-11-07 16:30:56.000000000","message":"Perfect, thanks!","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef0d614bd69c730eb69ca74e75651cca23937f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05ed0a4b_2e8ceeca","updated":"2025-11-07 16:18:59.000000000","message":"This shows where this fix is useful https://review.opendev.org/c/openstack/nova/+/965466/4#message-aa6655c55d67659e24364d21ea1ba178af97cee9","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb883892ad2b7e57bf3cf694a7c206fe272a82b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9190bad_5ef846a5","updated":"2025-11-10 14:28:18.000000000","message":"if it needs a respin it would be nice to adress the nits in the commit message but i dont think this need a respin just for that so +1 form me","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5ea809ad7db8425843303f7f5d7b5db9b01a51cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fc199eb_3beede29","in_reply_to":"58801f46_a5788b2d","updated":"2025-11-11 16:25:57.000000000","message":"I\u0027d prefer explicit over implicit. Tackled in a follow-up https://review.opendev.org/c/openstack/oslo.service/+/966702","commit_id":"1ba9201e9bd92de9c2cb8f4f161d6e279549e515"}]}