)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d1f4106a8ccf64f6018852ec21f69f6f1055800","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ghanshyam Maan \u003cgmaan@ghanshyammann.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-01-20 04:29:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix signal hanlder for threading mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signal hanlder can only be set and executed in the main"},{"line_number":10,"context_line":"thread of process. But in threading mode backend, they"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c8714287_36389e4a","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":18},"updated":"2026-01-21 08:59:15.000000000","message":"nit:handler (here and below as well)","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2bc87139c096575c31939d98c1a8f994ce3b83af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ghanshyam Maan \u003cgmaan@ghanshyammann.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-01-20 04:29:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix signal hanlder for threading mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signal hanlder can only be set and executed in the main"},{"line_number":10,"context_line":"thread of process. But in threading mode backend, they"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2f758dfb_babe046a","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":18},"in_reply_to":"c8714287_36389e4a","updated":"2026-01-21 22:29:55.000000000","message":"Done","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"70c3232b95b6361d3997c73b8917d6ddfd21c5b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eef4a690_1f34f78c","updated":"2026-01-21 09:16:23.000000000","message":"LGTM, would be worth adding a release note.","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d1f4106a8ccf64f6018852ec21f69f6f1055800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84141b85_9114d2cb","updated":"2026-01-21 08:59:15.000000000","message":"Looks good.","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ce6b74f95fda88f2f97c4f83cf0d4bc105bb8a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c84c24bb_ecb2113e","in_reply_to":"eef4a690_1f34f78c","updated":"2026-01-21 16:24:13.000000000","message":"sure, I can add one","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"}],"oslo_service/backend/_threading/service.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d1f4106a8ccf64f6018852ec21f69f6f1055800","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return"},{"line_number":57,"context_line":"        signo \u003d self._signals_by_name[sig]"},{"line_number":58,"context_line":"        self._signal_handlers[signo].append(handler)"},{"line_number":59,"context_line":"        signal.signal(signo, self._handle_signal_cb)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _handle_signal_cb(self, signo, frame):"},{"line_number":62,"context_line":"        for handler in reversed(self._signal_handlers[signo]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ded8d7f6_b311fcaa","line":59,"updated":"2026-01-21 08:59:15.000000000","message":"This change make sense in threading mode. I just wondering why I did not see any issue with GMR generation in threading mode without this fix using USR2 signal to trigger the GMR. Probably oslo_report registers its signals independently from oslo_service.\n\n// later\n\nyepp GMR sets up the signal before we fork via https://github.com/openstack/nova/blob/66bad0b1d9f9a1136482ee4b658d69ebc9d4e428/nova/cmd/conductor.py#L45","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ce6b74f95fda88f2f97c4f83cf0d4bc105bb8a9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return"},{"line_number":57,"context_line":"        signo \u003d self._signals_by_name[sig]"},{"line_number":58,"context_line":"        self._signal_handlers[signo].append(handler)"},{"line_number":59,"context_line":"        signal.signal(signo, self._handle_signal_cb)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _handle_signal_cb(self, signo, frame):"},{"line_number":62,"context_line":"        for handler in reversed(self._signal_handlers[signo]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd47d18e_1338d3a5","line":59,"in_reply_to":"ded8d7f6_b311fcaa","updated":"2026-01-21 16:24:13.000000000","message":"yeah, and GMR run the handler (dump report) in the same main thread - https://github.com/openstack/oslo.reports/blob/7671d3ca29ed8db29c4149b585083ef3492c6144/oslo_reports/guru_meditation_report.py#L198","commit_id":"4788bd820bf10b674c81f525d010a4e4250712e0"}]}