)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38752,"name":"Pavlo Kostianov","email":"pkostian@redhat.com","username":"pkostian"},"change_message_id":"c4f006d950c4eb2a0e573cdec9b20a6015ffb56a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89e4ba67_67b4b819","updated":"2026-04-02 10:46:42.000000000","message":"recheck","commit_id":"fdfe2b2737861868431f97010e009f2a582ddc28"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"ada721e0b322b1588fd24f6836f6ef7a67edcc37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9aff3e9_cc745b67","updated":"2026-04-02 15:24:52.000000000","message":"recheck","commit_id":"fdfe2b2737861868431f97010e009f2a582ddc28"},{"author":{"_account_id":38752,"name":"Pavlo Kostianov","email":"pkostian@redhat.com","username":"pkostian"},"change_message_id":"66ac0885231c2562013c49fda0cc1a7235efc382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd714b97_ae7a0ed5","updated":"2026-04-13 07:57:47.000000000","message":"recheck","commit_id":"fdfe2b2737861868431f97010e009f2a582ddc28"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"20f6e8e0ba44702af770e77a599a3dda5968f98b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f7dfe59_e68dcb31","updated":"2026-06-04 15:19:30.000000000","message":"LGTM, thanks Daniel","commit_id":"8f3787c39dc92b0dfd7108c90f60b4a2dd62416e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ed9d028a789785f43daa65a5eebeb78b263b52c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c889b155_b362ff37","updated":"2026-06-04 17:45:12.000000000","message":"almost lgtm but we are adding the non-test code in test-only file","commit_id":"8f3787c39dc92b0dfd7108c90f60b4a2dd62416e"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"6efb30ef07dfa0d314265f983c113a4778bb718d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"110bf167_d94a3121","updated":"2026-06-09 17:29:54.000000000","message":"recheck","commit_id":"0d9234d5a41cf95e5f9d196e57291b6af8478e30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0b9e8803edca96108ece1dfbfc260b7883b76226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99887768_12158298","updated":"2026-06-11 17:41:28.000000000","message":"this lgtm, but let\u0027s make it utils file more common for future addition of all util function.","commit_id":"0d9234d5a41cf95e5f9d196e57291b6af8478e30"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"d930acd13f496e8ede9bd1490076afcd456b828b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf0d8b55_0492ed5f","updated":"2026-06-14 15:36:12.000000000","message":"recheck","commit_id":"0f3d78595b403929f9c8dcb217b5ac3f9acdb6f9"}],"oslo_service/_fork_safety_workers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ed9d028a789785f43daa65a5eebeb78b263b52c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    return x * 2"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def configure_worker_oslo_logging(config_files, project\u003d\u0027oslo.service\u0027):"},{"line_number":43,"context_line":"    \"\"\"Pool initializer: configure oslo_log in a spawn worker."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    ``oslo.config.cfg.ConfigOpts`` is not picklable (it contains lambdas),"}],"source_content_type":"text/x-python","patch_set":2,"id":"cbe8d8ec_72c722b7","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":33},"updated":"2026-06-04 17:45:12.000000000","message":"this is not just test function but used in oslo_service/periodic_task.py and this file is mentioned as test file @L15, We should move this function to oslo_service/periodic_task.py itself or create a new file utils under oslo_service/","commit_id":"8f3787c39dc92b0dfd7108c90f60b4a2dd62416e"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"b67ec82d42d741b11b23c8f8f3d27f8f8d11c984","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    return x * 2"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def configure_worker_oslo_logging(config_files, project\u003d\u0027oslo.service\u0027):"},{"line_number":43,"context_line":"    \"\"\"Pool initializer: configure oslo_log in a spawn worker."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    ``oslo.config.cfg.ConfigOpts`` is not picklable (it contains lambdas),"}],"source_content_type":"text/x-python","patch_set":2,"id":"6637e44d_a0b6ba80","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":33},"in_reply_to":"cbe8d8ec_72c722b7","updated":"2026-06-04 19:34:31.000000000","message":"Done","commit_id":"8f3787c39dc92b0dfd7108c90f60b4a2dd62416e"}],"oslo_service/_spawn_utils.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0b9e8803edca96108ece1dfbfc260b7883b76226","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8e2a469_17eb4873","updated":"2026-06-11 17:41:28.000000000","message":"I will suggest to name it utils.py so that we can add other non-spawn common util function also.","commit_id":"0d9234d5a41cf95e5f9d196e57291b6af8478e30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"23091bbf0c62c543d6ecfd43a7cf19cb18b2c34a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0e35618_269c49f6","in_reply_to":"3aacde1d_15cfdf5d","updated":"2026-06-12 16:39:37.000000000","message":"Sure, thanks, it works fine for me.","commit_id":"0d9234d5a41cf95e5f9d196e57291b6af8478e30"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5de3f8eede4dd36f5c4d92e276af029690781062","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3aacde1d_15cfdf5d","in_reply_to":"e8e2a469_17eb4873","updated":"2026-06-12 12:48:23.000000000","message":"Thanks a lot. I named it _spawn_utils.py because the current helper is spawn-specific. I would prefer to keep it scoped for now to avoid creating a broad utils module too early. If we later add more generic helpers, we can introduce a wider utility module then.","commit_id":"0d9234d5a41cf95e5f9d196e57291b6af8478e30"}]}
