)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"8862c94ff3f3f3033b26779146714e08d6ccd6a1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log config option when service is launched on main process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When service is lauchned on main process (no_fork\u003dTrue) then"},{"line_number":10,"context_line":"oslo.service does not log the config options, in all other cases,"},{"line_number":11,"context_line":"cotyledon lib logs the options."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"659be688_d8ed0658","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":24},"updated":"2026-07-23 10:35:47.000000000","message":"nit: launched","commit_id":"5ff2ea8675d48907ce686082978c3a382cafe2d1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2c6d7e81bfb1d6472cd043e4fbb521f31dd1bf82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26e3d385_ef1da3b5","updated":"2026-07-22 20:52:35.000000000","message":"Looks like there was a very similar patch proposed a long time ago and it had a reset of a global var as part of the testing, I wonder if you might need that?\n\nhttps://review.opendev.org/c/openstack/oslo.service/+/967354/6/oslo_service/tests/backend/threading/test_launcher.py#45","commit_id":"5ff2ea8675d48907ce686082978c3a382cafe2d1"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"8862c94ff3f3f3033b26779146714e08d6ccd6a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9580d570_de339167","updated":"2026-07-23 10:35:47.000000000","message":"wdyt about release note","commit_id":"5ff2ea8675d48907ce686082978c3a382cafe2d1"}],"oslo_service/tests/backend/threading/test_launcher.py":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"8862c94ff3f3f3033b26779146714e08d6ccd6a1","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        with mock.patch.object(self.conf, \u0027log_opt_values\u0027) as mock_log:"},{"line_number":149,"context_line":"            launcher.launch_service(DummyService())"},{"line_number":150,"context_line":"            mock_log.assert_called_once()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_no_fork_skips_logging_options_when_log_options_disabled(self):"},{"line_number":153,"context_line":"        launcher \u003d service.ProcessLauncher(self.conf, no_fork\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e05ec7d_61ee1b3a","line":150,"updated":"2026-07-23 10:35:47.000000000","message":"WDYT about using mock_log.assert_called_once_with here to check the parameters as well?","commit_id":"5ff2ea8675d48907ce686082978c3a382cafe2d1"}]}
