)]}'
{"oslo_upgradecheck/upgradecheck.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ec158d9e54feb5d0f47e5d3343bd3574ce2bdfd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def check(self):"},{"line_number":87,"context_line":"        \"\"\"Performs checks to see if the deployment is ready for upgrade."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        These checks are expected to be run BEFORE services are restarted with"},{"line_number":90,"context_line":"        new code."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        :returns: Code"},{"line_number":93,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b72d0291","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":17},"updated":"2018-09-21 20:59:31.000000000","message":"I\u0027ve gotten quite a few questions about this as well, and in the case of nova we do encourage people to run the checks post-green install:\n\nhttps://docs.openstack.org/nova/latest/install/verify.html\n\nI need to update some of the wording in https://docs.openstack.org/nova/latest/reference/upgrade-checks.html about it and I think long-term those reference docs should live in this library rather than nova. But that\u0027s another change for another day. The key is the checks should be idempotent and flexible - expect people to run them at really any time.","commit_id":"099b8c0a9b3fbfb1a6263ac2a4622da612287de1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"08026d083dfd48a54d00dbcdc20a0bb64ff870ea","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    class member so that they are run when the ``check`` method is called."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    The subcommands here must not rely on the service object model since they"},{"line_number":74,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":75,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":76,"context_line":"    schema migrations."},{"line_number":77,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a7791b31","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":37},"updated":"2018-09-25 20:43:53.000000000","message":"What is \"n-1 data\"?","commit_id":"2685b6d40cad9a3e5db6139e5f609325cd208ae9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"855dc52b105de4444e7aa3b4b18123e50c8e0f36","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    class member so that they are run when the ``check`` method is called."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    The subcommands here must not rely on the service object model since they"},{"line_number":74,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":75,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":76,"context_line":"    schema migrations."},{"line_number":77,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1a50120a","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":37},"in_reply_to":"3f79a3b5_8515f73f","updated":"2018-09-28 21:28:42.000000000","message":"Nova\u0027s versioned objects match the data model for each release, so the database schema has to be synced up before you can start the service code with those versioned objects. We expect upgrade checks to be run in isolation in a venv/container and can be run against different versions of the schema, or that we can write a check on master and backport it because sometimes we get bugs were people say, \"while upgrading to $master-2 release, I hit this issue. I\u0027ve since resolved it, but it would have been nice to get a warning\" so we\u0027ll write a retroactive check and backport it, that happened with this one:\n\nIe2bc4616439352850cf29a9de7d33a06c8f7c2b8\n\nSo just like we don\u0027t backport versioned object changes to stable branches (because they are a versioned RPC interface), we don\u0027t include those versioned objects in the upgrade checks since we just want to deal with the raw DB schema model.","commit_id":"2685b6d40cad9a3e5db6139e5f609325cd208ae9"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"754c35b41446ef56bb8f11513bcd1997657cfbe0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    class member so that they are run when the ``check`` method is called."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    The subcommands here must not rely on the service object model since they"},{"line_number":74,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":75,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":76,"context_line":"    schema migrations."},{"line_number":77,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8515f73f","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":37},"in_reply_to":"3f79a3b5_a7791b31","updated":"2018-09-26 21:33:22.000000000","message":"I think in Nova\u0027s case it would be data that potentially has not had online migrations run on it yet. In Designate\u0027s case it\u0027s a database schema that hasn\u0027t been migrated to the current version yet.\n\nAt least that\u0027s my interpretation. This was copy-pasted from the Nova code.","commit_id":"2685b6d40cad9a3e5db6139e5f609325cd208ae9"}]}