)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"872f3d3f325f6f1c14ba8654d8ef4ba3595e4b76","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In some scenarios, it is useful for the caller of upgradecheck"},{"line_number":10,"context_line":"to be responsible for parsing the conf (see [1]). Since"},{"line_number":11,"context_line":"registering command line options must come before parsing,"},{"line_number":12,"context_line":"we must separate registation from running the commands."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change enables that by making `register_cli_options` public"},{"line_number":15,"context_line":"and extracting a public `run` method. `main` continues to work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_f76a06eb","line":12,"range":{"start_line":12,"start_character":17,"end_line":12,"end_character":28},"updated":"2019-01-28 15:24:58.000000000","message":"registration (Is it your \u0027r\u0027 now? Eating toffees while typing is a good way to ruin keyboards.)","commit_id":"fd6bd23457ca70a150b768d0f7d916639e92f50c"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"49a67b1b09a6c9aab02484250003a57965ff8f8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"as before by calling these new methods."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] I2eea00343d1bbdf486985daeaf6707358b6a2708"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I3d7e28d2432f5b04d4154793025786dc289b0cb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_2917ca53","line":19,"updated":"2019-01-29 02:16:03.000000000","message":"nit: It helps reviewers to have \"Need-By: https://review.openstack.org/#/c/633595/1\"","commit_id":"fd6bd23457ca70a150b768d0f7d916639e92f50c"}],"oslo_upgradecheck/upgradecheck.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1e8572ce17ecc7ba4733abdfb13cbeea931a2a1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    \"\"\"Set up the command line options."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    Adds a subcommand to support \u0027upgrade check\u0027 on the command line."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    def add_parsers(subparsers):"},{"line_number":151,"context_line":"        upgrade_action \u003d subparsers.add_parser(\u0027upgrade\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6f714da8","line":148,"updated":"2019-02-13 10:01:01.000000000","message":"Given that these are now essentially APIs, would it be possible to update the docstrings to describe the parameters? Ditto for \u0027run\u0027 below. A follow-up is fine, but we really don\u0027t do enough of that in oslo and should fix that","commit_id":"fd6bd23457ca70a150b768d0f7d916639e92f50c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"c5560c3d4886b2de3c1aa071ef8bed43b40962ac","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    \"\"\"Set up the command line options."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    Adds a subcommand to support \u0027upgrade check\u0027 on the command line."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    def add_parsers(subparsers):"},{"line_number":151,"context_line":"        upgrade_action \u003d subparsers.add_parser(\u0027upgrade\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6ff4edf1","line":148,"in_reply_to":"9fdfeff1_6f714da8","updated":"2019-02-13 10:04:41.000000000","message":"sure will do a fup","commit_id":"fd6bd23457ca70a150b768d0f7d916639e92f50c"}]}
