)]}'
{"oslo_upgradecheck/upgradecheck.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"123b1e7deef7627403f59598d6d5f284af5d0dd9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    _upgrade_checks \u003d ()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __init__(self):"},{"line_number":85,"context_line":"        self.conf \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_details(self, upgrade_check_result):"},{"line_number":88,"context_line":"        if upgrade_check_result.details is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_dc8908ca","line":85,"updated":"2019-06-11 14:28:21.000000000","message":"Seems to be never used, or maybe I missing something...","commit_id":"108f56a66e4f317fd7f0880f2b918367490fe9bd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdb8982d6574c0b8869342483e65a8c86d026b0b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    _upgrade_checks \u003d ()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __init__(self):"},{"line_number":85,"context_line":"        self.conf \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_details(self, upgrade_check_result):"},{"line_number":88,"context_line":"        if upgrade_check_result.details is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ff3cfe2f","line":85,"in_reply_to":"9fb8cfa7_dc8908ca","updated":"2019-06-11 15:06:15.000000000","message":"Yep, you\u0027re right. I think I must have left this in after changing from an originally planned approach.","commit_id":"108f56a66e4f317fd7f0880f2b918367490fe9bd"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1e5bb84dc3bcbb64e556fac5fc649a8790e79ecc","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        :returns: Code"},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        global CONF"},{"line_number":99,"context_line":"        return_code \u003d Code.SUCCESS"},{"line_number":100,"context_line":"        # This is a list if 2-item tuples for the check name and it\u0027s results."},{"line_number":101,"context_line":"        check_results \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_12cec0b3","line":98,"updated":"2019-06-25 16:03:55.000000000","message":"Since we only ever read from CONF, I don\u0027t think this is necessary.","commit_id":"3a92c6e0b60321fff869c864fb167381066b5585"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1e5bb84dc3bcbb64e556fac5fc649a8790e79ecc","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if result.code \u003e return_code:"},{"line_number":108,"context_line":"                return_code \u003d result.code"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(bnemec): Consider using cliff for this so we can output in"},{"line_number":111,"context_line":"        # different formats like JSON or CSV."},{"line_number":112,"context_line":"        # We\u0027re going to build a summary table that looks like:"},{"line_number":113,"context_line":"        # +----------------------------------------------------+"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_b27ed416","line":110,"updated":"2019-06-25 16:03:55.000000000","message":"Nit: Should remove this.","commit_id":"3a92c6e0b60321fff869c864fb167381066b5585"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1e5bb84dc3bcbb64e556fac5fc649a8790e79ecc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # | Details: There is no placement-api endpoint in the |"},{"line_number":123,"context_line":"        # |          service catalog.                          |"},{"line_number":124,"context_line":"        # +----------------------------------------------------+"},{"line_number":125,"context_line":"        # NOTE(bnemec): We use six.text_type on the translated string to"},{"line_number":126,"context_line":"        # force immediate translation if lazy translation is in use."},{"line_number":127,"context_line":"        # See lp1801761 for details."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_12dfa03a","line":125,"updated":"2019-06-25 16:03:55.000000000","message":"Nit: This comment is now split from the code it refers to. Since there\u0027s only one six.text_type in each of the branches it should be possible to figure out what it\u0027s referring to, but it\u0027s less clear than before.","commit_id":"3a92c6e0b60321fff869c864fb167381066b5585"}]}