)]}'
{"oslo/utils/netutils.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"fcd41d3d01605b1e15d2e246fd2ffe40ae943a63","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        host, port \u003d parse_host_port(netloc)"},{"line_number":93,"context_line":"        return port"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def params(self, collapse\u003dTrue):"},{"line_number":96,"context_line":"        # NOTE(harlowja): this function isn\u0027t exposed as a part of the base"},{"line_number":97,"context_line":"        # classes but it\u0027s a nice to have to avoid having to have users do"},{"line_number":98,"context_line":"        # the same."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_eb454643","line":95,"updated":"2014-09-04 18:45:35.000000000","message":"This could use a docstring to explain the return type and argument, although I notice that the class is marked private so I guess we\u0027re not documenting it anywhere.\n\nWhat do you see happening to this function when we drop python 2.6 support and no longer need the custom _ModifiedSplitResult? Should we keep our custom subclass, make it public, and then keep this method?","commit_id":"554cf837b6073d2e9709ec972ba01135cc7bdf61"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"0c4e76dbbe31d3eff7f5f118fe4c56bcb8f49c36","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        host, port \u003d parse_host_port(netloc)"},{"line_number":93,"context_line":"        return port"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def params(self, collapse\u003dTrue):"},{"line_number":96,"context_line":"        # NOTE(harlowja): this function isn\u0027t exposed as a part of the base"},{"line_number":97,"context_line":"        # classes but it\u0027s a nice to have to avoid having to have users do"},{"line_number":98,"context_line":"        # the same."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c8532515","line":95,"in_reply_to":"fa98f980_eb454643","updated":"2014-09-04 19:57:50.000000000","message":"Will add a docstring.\n\nAs for when 2.6 goes away, if we plan on dropping the urlsplit method then maybe a tiny utililty method can be enough (in the module namespace). If we don\u0027t plan on dropping urlsplit from this module then returning a custom subclass seems ok (with only this method). \n\nAs for it being private its not really private since its what urlsplit returns as its object (and urlsplit is a public api), I guess maybe the reason for not documenting it is that it just covers over the difference between 2.6 and 2.7 (while this method actually adds something new).","commit_id":"554cf837b6073d2e9709ec972ba01135cc7bdf61"}]}