)]}'
{"oslo/utils/uuidutils.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"eebd5c6e9ba81c97604f616961906bbc956f6f49","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def generate_uuid():"},{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_e6520866","line":24,"updated":"2014-09-26 09:33:23.000000000","message":"This is so useless. We use UUID a lot in Gnocchi for example, and we use the UUID type – not the str one – in a lot of places (SQLAlchemy, REST API, etc…).\n\nI can\u0027t see a good reason to provide this.","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"9e2f741c7db9e0845a5251180dc28220754d0af5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def generate_uuid():"},{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_be5c691a","line":24,"in_reply_to":"da9df570_e6520866","updated":"2014-10-10 14:21:29.000000000","message":"@jd, this is just to avoid a whole lot of reviews/rechecks in projects that already have a lot of references to generate_uuid","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d80d550b203360f15c75e960c0cab5bf97676923","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def generate_uuid():"},{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8ae34304","line":24,"in_reply_to":"da9df570_e6520866","updated":"2014-10-02 11:46:21.000000000","message":"my 2c.\n\n- cinder, heat, neutron, nova and sahara contains uuidutils modul in theirs openstack-common.conf, so this probably makes a sense to move uuidutils into the oslo library\n\n- some OS project have it\u0027s own implementation of generate_uuid() and is_uuid_like() functions","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a7cb2dcbeace6cb84ebc0df3473dc0d5684494db","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"},{"line_number":28,"context_line":"    \"\"\"Returns validation of a value as a UUID."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    For our purposes, a UUID is a canonical form string:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_75fb32c1","line":27,"updated":"2014-09-25 19:08:04.000000000","message":"Just an interesting observation.\n\nhttps://hg.python.org/releasing/3.4/file/8671f89107c8/Lib/uuid.py#l133\n\nThis will basically accept any kind of string that is hexadecimal and is 32 chars long after being cleaned. I wonder if we should have a better detection algorithm then this...\n\nFor example the following will say it is a invalid uuid (when really it is):\n\n  \u003e\u003e\u003e x \u003d \u0027uuid:bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027\n  \u003e\u003e\u003e uuid.UUID(x)\n  UUID(\u0027bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027)\n  \u003e\u003e\u003e uuidutils.is_uuid_like(x)\n  False\n\nApparently the following is also valid but not detected as uuid_like\n\n  \u003e\u003e\u003e x \u003d \"{}-----bbb---aaa---aaa--aaa--------aaa------aaa--bbb-bbb----bbb-bbb-bb-{}\"\n  \u003e\u003e\u003e uuid.UUID(x)\n  UUID(\u0027bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027)\n  \u003e\u003e\u003e uuidutils.is_uuid_like(x)\n  False\n\nMaybe we shouldn\u0027t have this validation function, or should at least make it better??","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"eebd5c6e9ba81c97604f616961906bbc956f6f49","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"},{"line_number":28,"context_line":"    \"\"\"Returns validation of a value as a UUID."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    For our purposes, a UUID is a canonical form string:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_46f03467","line":27,"in_reply_to":"da9df570_03e54cdc","updated":"2014-09-26 09:33:23.000000000","message":"Do I miss something or doing UUID(val) is enough to validate that\u0027s it\u0027s a valid UUID? Josh just pointed out how that current function is bugged anyhow…\n\nI really wonder if we need this uuidutils module.","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d80d550b203360f15c75e960c0cab5bf97676923","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"},{"line_number":28,"context_line":"    \"\"\"Returns validation of a value as a UUID."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    For our purposes, a UUID is a canonical form string:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_caed4bf1","line":27,"in_reply_to":"da9df570_46f03467","updated":"2014-10-02 11:46:21.000000000","message":"+1 to make this function better","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"f4c0887f3c6881aeef9dd118aa8e76813a3edaa6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    return str(uuid.uuid4())"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def is_uuid_like(val):"},{"line_number":28,"context_line":"    \"\"\"Returns validation of a value as a UUID."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    For our purposes, a UUID is a canonical form string:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_03e54cdc","line":27,"in_reply_to":"da9df570_75fb32c1","updated":"2014-09-25 20:16:32.000000000","message":"Josh, +1 to make it better!","commit_id":"7fb0b3f08038275803f43d5705158a3221d84a00"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3517d88c91cae3b6a3616c23a6786777d4965868","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  .replace(\u0027-\u0027, \u0027\u0027))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def is_uuid_like(val):"},{"line_number":35,"context_line":"    \"\"\"Returns validation of a value as a UUID."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    :param val: Value to verify"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_82068a1a","line":34,"updated":"2014-10-15 18:09:37.000000000","message":"I already ask this question but I still miss the answer: do I miss something or doing UUID(val) is enough to validate that\u0027s it\u0027s a valid UUID?","commit_id":"dabbbca567c565e908399c400e6d7da0b4f1dbd3"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bab0c22d0a1c54de0b68176d94e40b5bb7e9e84b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  .replace(\u0027-\u0027, \u0027\u0027))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def is_uuid_like(val):"},{"line_number":35,"context_line":"    \"\"\"Returns validation of a value as a UUID."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    :param val: Value to verify"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_d8430c11","line":34,"in_reply_to":"baa201ad_82068a1a","updated":"2014-10-16 13:33:37.000000000","message":"This realization was in oslo-incubator from the beginning, but Nova has a few different versions of this function. Zhongyue Luo was an author of oslo-incubator\u0027s version, so I hope, he will clarify some details.","commit_id":"dabbbca567c565e908399c400e6d7da0b4f1dbd3"}],"tests/test_uuidutils.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"10b84d2f02da5b72832663552d6a4a85b21cd6f8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.assertFalse(uuidutils.is_uuid_like(1234567))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_name_is_uuid_like(self):"},{"line_number":47,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":48,"context_line":"            \u0027urn:bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027))"},{"line_number":49,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":50,"context_line":"            \u0027uuid:bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_f925a00a","line":47,"updated":"2014-10-13 13:45:43.000000000","message":"it\u0027s looks strange for me - to see four self.assertTrue(uuidutils.is_uuid_like(UUID)) in test_name_is_uuid_like()","commit_id":"1d9475c6e998a44a971a0244ad8ff557db1c1d82"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c8e93c01aa71a29dc74a50309940ac8e24723a69","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.assertFalse(uuidutils.is_uuid_like(1234567))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_name_is_uuid_like(self):"},{"line_number":47,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":48,"context_line":"            \u0027urn:bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027))"},{"line_number":49,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":50,"context_line":"            \u0027uuid:bbbaaaaa-aaaa-aaaa-aabb-bbbbbbbbbbbb\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_3039d941","line":47,"in_reply_to":"baa201ad_f925a00a","updated":"2014-10-14 11:33:57.000000000","message":"Done","commit_id":"1d9475c6e998a44a971a0244ad8ff557db1c1d82"}]}
