)]}'
{"oslo/utils/strutils.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"acb62ce1d4fa0af4dd9aae754d1bafcfe038f663","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    \"\"\""},{"line_number":256,"context_line":"    try:"},{"line_number":257,"context_line":"        return str(int(val)) \u003d\u003d str(val)"},{"line_number":258,"context_line":"    except Exception:"},{"line_number":259,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_298ad763","line":258,"updated":"2014-10-08 21:06:05.000000000","message":"int() will raise TypeError or ValueError. str(val) might raise unicode errors.\n\nI think we want to ignore the unicode errors and let the caller deal with them, but to do that we need to use six.text_type. After making that change, we can change \"Exception:\" to \"(TypeError, ValueError):\".","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e360c5f3528bb9e4a365821da4e25963711e6db6","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    \"\"\""},{"line_number":256,"context_line":"    try:"},{"line_number":257,"context_line":"        return str(int(val)) \u003d\u003d str(val)"},{"line_number":258,"context_line":"    except Exception:"},{"line_number":259,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_bffdee70","line":258,"in_reply_to":"baa201ad_298ad763","updated":"2014-10-10 08:05:06.000000000","message":"agreed","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"}],"tests/test_strutils.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ef8d5dd0ade931d740a69b49df771f372e17562d","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        self.assertTrue(strutils.is_int_like(\"1\"))"},{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8b91829b","line":561,"updated":"2014-10-02 15:07:57.000000000","message":"Fails for this, I think, valid case: 12e3\n\n\u003e\u003e\u003e str(int(12e3)) \u003d\u003d str(12e3)\nFalse","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1283c32de47cf08f0679064a01f748bca285e9a8","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        self.assertTrue(strutils.is_int_like(\"1\"))"},{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_abc4865f","line":561,"in_reply_to":"baa201ad_8b91829b","updated":"2014-10-02 15:20:10.000000000","message":"well, python interpreter tells, that 12e3 is a float value, so False looks correct in this case, same as str(int(1.0)) !\u003d str(1.0)\n\n \u003e\u003e\u003e type(12e3)\n \u003ctype \u0027float\u0027\u003e","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"25dcbe1a5c8a1de2a8d4c46c3fb53de95a86eb41","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        self.assertTrue(strutils.is_int_like(\"1\"))"},{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ce9c78c3","line":561,"in_reply_to":"baa201ad_abc4865f","updated":"2014-10-02 15:41:31.000000000","message":"Fair enough.","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"76739213c0693cf44a155889153119a7c69229a0","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"},{"line_number":565,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_4acdc95c","line":562,"updated":"2014-10-03 00:20:53.000000000","message":"Also fails for is_int_like(\"0x20\"). I guess your not concerned with other bases (octal or hexadecimal)?","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e360c5f3528bb9e4a365821da4e25963711e6db6","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"},{"line_number":565,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_7fdc6619","line":562,"in_reply_to":"baa201ad_09e6f343","updated":"2014-10-10 08:05:06.000000000","message":"Done","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"35a0c08ab22d2e00dad7c9d5c6880ee9f0f66790","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"},{"line_number":565,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_f6481f89","line":562,"in_reply_to":"baa201ad_4acdc95c","updated":"2014-10-03 09:01:51.000000000","message":"yes, at the moment function is_int_like() works only with integer with base 10, so it will return False for \"0o51\" and \"0xDEADBEEF\"","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"acb62ce1d4fa0af4dd9aae754d1bafcfe038f663","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        self.assertTrue(strutils.is_int_like(\"514\"))"},{"line_number":560,"context_line":"        self.assertTrue(strutils.is_int_like(\"0\"))"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_is_int_like_false(self):"},{"line_number":563,"context_line":"        self.assertFalse(strutils.is_int_like(1.1))"},{"line_number":564,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1\"))"},{"line_number":565,"context_line":"        self.assertFalse(strutils.is_int_like(\"1.1.1\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_09e6f343","line":562,"in_reply_to":"baa201ad_f6481f89","updated":"2014-10-08 21:06:05.000000000","message":"Let\u0027s add those test cases to make that expectation explicit.","commit_id":"6c3742e12624e1a8ddc39556ac98fef1135d754b"}]}