)]}'
{"oslo_utils/netutils.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"795c65ef5e8380a756bc91be5115276390ba0837","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    try:"},{"line_number":92,"context_line":"        return netaddr.valid_mac(mac)"},{"line_number":93,"context_line":"    except Exception:"},{"line_number":94,"context_line":"        return False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_1227ae13","line":93,"updated":"2015-05-12 17:53:46.000000000","message":"Does this throw any specific exceptions that should be caught instead?\n\nFrom looking at the following it doesn\u0027t appear it throws any exceptions actually... so maybe no try, except block needed at all?\n\nhttps://github.com/drkjam/netaddr/blob/rel-0.7.x/netaddr/strategy/eui48.py#L137\n\nhttps://github.com/drkjam/netaddr/blob/rel-0.7.x/netaddr/__init__.py#L42","commit_id":"f2cb25281a68c79bacef3752c3b3840075159a97"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"12a6d4521e0ddc0019464b62932ccb12059d8d9d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    try:"},{"line_number":92,"context_line":"        return netaddr.valid_mac(mac)"},{"line_number":93,"context_line":"    except Exception:"},{"line_number":94,"context_line":"        return False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_fd486b2f","line":93,"in_reply_to":"9a0c5dc1_1227ae13","updated":"2015-05-12 18:07:19.000000000","message":"I\u0027m having some trouble understanding why we need this function at all if we don\u0027t have to trap exceptions from valid_mac(). What sorts of exceptions should we expect?","commit_id":"f2cb25281a68c79bacef3752c3b3840075159a97"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"551a5c8a5f7ac09e1a26113afee452c0659209d4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    try:"},{"line_number":92,"context_line":"        return netaddr.valid_mac(mac)"},{"line_number":93,"context_line":"    except Exception:"},{"line_number":94,"context_line":"        return False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_2f759bca","line":93,"in_reply_to":"9a0c5dc1_fd486b2f","updated":"2015-05-13 02:19:24.000000000","message":"Just copy-paste from is_valid_ipv4, seems it will not throw exceptions, will remove it next patchset.","commit_id":"f2cb25281a68c79bacef3752c3b3840075159a97"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"bcf56fc377b51b6edd57384af1d2ecc4d05d7a2d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    try:"},{"line_number":92,"context_line":"        return netaddr.valid_mac(mac)"},{"line_number":93,"context_line":"    except Exception:"},{"line_number":94,"context_line":"        return False"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_7e26a269","line":93,"in_reply_to":"9a0c5dc1_fd486b2f","updated":"2015-05-13 04:16:41.000000000","message":"Unsure...","commit_id":"f2cb25281a68c79bacef3752c3b3840075159a97"}]}