)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7582e6dc8c6949a4235ce9f7e2d8f8f2dded0c7b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joshua Harlow \u003charlowja@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-22 07:58:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Provide direct access to splits captured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Oslo.concurrency has a lock timing func that can just use splits"},{"line_number":10,"context_line":"but it needs to have easy access to the number of splits that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_b488b923","line":7,"updated":"2015-08-25 07:25:25.000000000","message":"I don\u0027t mean to be a PITA but, the commit title doesn\u0027t seem to be aligned with the change. Mind updating it?\n\nOne more thing, this change introduces a backwards incompatible API change. It\u0027s probably not a problem since it changes from returning a tuple to returning a list. It\u0027d be great to have that explained in the message or just use this patch to update the docstring and add tests without changing the returned value.","commit_id":"fa6a4267818a04f457de56ab8852f1b0ba2dc9d0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d69f4c41cd1745dc4ca6ffe735be3b1ad8582962","unresolved":false,"context_lines":[{"line_number":12,"context_line":"different; so add the ability to easily fetch how many splits"},{"line_number":13,"context_line":"have been captured by just returning the underlying list (and updating"},{"line_number":14,"context_line":"the docstring to denote it should only be used in a read-only"},{"line_number":15,"context_line":"fashion)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This is a api change, that alters how the splits property now returns"},{"line_number":18,"context_line":"a list, instead of a previous tuple, this should be harmless, or that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a57f1b5_9dbfbefa","line":15,"range":{"start_line":15,"start_character":7,"end_line":15,"end_character":9},"updated":"2016-02-11 15:35:23.000000000","message":"I don\u0027t understand the use case. Do you need to get access to len(stopwatch.splits)? You can already get accesss to len(stopwatch.splits), no?","commit_id":"ed22bd304369e0a1017ddcd0e734cc8bc4576a02"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d69f4c41cd1745dc4ca6ffe735be3b1ad8582962","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This is a api change, that alters how the splits property now returns"},{"line_number":18,"context_line":"a list, instead of a previous tuple, this should be harmless, or that"},{"line_number":19,"context_line":"is the goal as the returned result is still recommended to be read-only"},{"line_number":20,"context_line":"even after this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia5ada0d4a8cf4c0807212867c6d993b729063f6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a57f1b5_3d456a16","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":23},"updated":"2016-02-11 15:35:23.000000000","message":"I don\u0027t see an unit test on API change itself: you should ensure that stopwatch.splits is a list and/or that you can modify it.","commit_id":"ed22bd304369e0a1017ddcd0e734cc8bc4576a02"}],"oslo_utils/timeutils.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7385684424690b108485e3111fec3971671ababa","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @property"},{"line_number":380,"context_line":"    def splits(self):"},{"line_number":381,"context_line":"        \"\"\"Read-only accessor to all/any splits that have been captured.\"\"\""},{"line_number":382,"context_line":"        return self._splits"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def split(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_6133f6ab","line":381,"updated":"2015-10-08 20:19:06.000000000","message":"This isn\u0027t read-only any more is it? I\u0027m not sure why you changed the property to not return a new object.","commit_id":"ed22bd304369e0a1017ddcd0e734cc8bc4576a02"}]}