)]}'
{"oslo_utils/tests/tests_encodeutils.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"f93890975837946ee9ae091c7c4ff757aa0a8802","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                         u\u0027utf-8 \\xe9\\u20ac\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_oslo_i18n_message(self):"},{"line_number":238,"context_line":"        oslo_i18n.enable_lazy()"},{"line_number":239,"context_line":"        exc \u003d _LE(\"test\")"},{"line_number":240,"context_line":"        # Sanity check to ensure that oslo_i18n gave us a Message object,"},{"line_number":241,"context_line":"        # not a bytes or Unicode string"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_79a40007","line":238,"updated":"2015-07-02 17:07:00.000000000","message":"You shouldn\u0027t be enabling lazy directly, but should use the oslo_i18n fixture to do this.\n\nActually, you could simply use the oslo_i18n Translation fixture\u0027s lazy() to get a lazy translated message for line 239 and then you wouldn\u0027t need this line.","commit_id":"582484bf4ba683b8341fb31e2bc37a00c8aa7a79"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"220db904217ae4f7f784bb115a556f6da5641b02","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                         u\u0027utf-8 \\xe9\\u20ac\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_oslo_i18n_message(self):"},{"line_number":238,"context_line":"        oslo_i18n.enable_lazy()"},{"line_number":239,"context_line":"        exc \u003d _LE(\"test\")"},{"line_number":240,"context_line":"        # Sanity check to ensure that oslo_i18n gave us a Message object,"},{"line_number":241,"context_line":"        # not a bytes or Unicode string"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f57fa512","line":238,"in_reply_to":"ba3cc151_79a40007","updated":"2015-07-02 21:55:20.000000000","message":"I was looking for such function in oslo_i18n documentation but I failed to find it. Thanks! I will use the fixture.","commit_id":"582484bf4ba683b8341fb31e2bc37a00c8aa7a79"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1ab56c9a43f526d2c888f62285006760769ac6fc","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.assertNotIn(type(exc), (bytes, six.text_type))"},{"line_number":243,"context_line":"        self.assertEqual(six.text_type(exc), u\"test\")"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.assertEqual(encodeutils.exception_to_unicode(exc),"},{"line_number":246,"context_line":"                         u\"test\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_de05f210","line":245,"updated":"2015-07-02 16:01:34.000000000","message":"Huh, that\u0027s not a exception object :-/\n\nMe so confused...","commit_id":"582484bf4ba683b8341fb31e2bc37a00c8aa7a79"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"220db904217ae4f7f784bb115a556f6da5641b02","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.assertNotIn(type(exc), (bytes, six.text_type))"},{"line_number":243,"context_line":"        self.assertEqual(six.text_type(exc), u\"test\")"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.assertEqual(encodeutils.exception_to_unicode(exc),"},{"line_number":246,"context_line":"                         u\"test\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_75a4f5b8","line":245,"in_reply_to":"ba3cc151_de05f210","updated":"2015-07-02 21:55:20.000000000","message":"I\u0027m working on a patch to replace Glance exception_to_str() with oslo_utils exception_to_unicode(). exception_to_str() works on oslo_i18n messages. Patch for Glance:\n\nhttps://review.openstack.org/#/c/197916/\n\nFor the specific case of Glance, exception_to_str() was only used in a single line in the whole project to cast a oslo_i18n message to unicode. I replaced exception_to_str() with six.text_type() on this specific line, so I don\u0027t need this exception_to_unicode() enhancement anymore for the specific case of Glance.","commit_id":"582484bf4ba683b8341fb31e2bc37a00c8aa7a79"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"f93890975837946ee9ae091c7c4ff757aa0a8802","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.assertNotIn(type(exc), (bytes, six.text_type))"},{"line_number":243,"context_line":"        self.assertEqual(six.text_type(exc), u\"test\")"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.assertEqual(encodeutils.exception_to_unicode(exc),"},{"line_number":246,"context_line":"                         u\"test\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_19fe14ae","line":245,"in_reply_to":"ba3cc151_de05f210","updated":"2015-07-02 17:07:00.000000000","message":"That\u0027s a good point.   Since this is about the message in the exception being lazy translatable and not the exception itself.","commit_id":"582484bf4ba683b8341fb31e2bc37a00c8aa7a79"}]}