)]}'
{"oslo_utils/strutils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5e4f0f75ce54e50dde6541412d39ea1c939e1774","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                message \u003d re.sub(pattern, substitute1, message)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    # handle extra sanitize keys"},{"line_number":279,"context_line":"    if extra_sanitize_keys is None:"},{"line_number":280,"context_line":"        extra_sanitize_keys \u003d []"},{"line_number":281,"context_line":"    for key in extra_sanitize_keys:"},{"line_number":282,"context_line":"        if key in message:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d408cedb","line":279,"updated":"2015-11-16 08:48:42.000000000","message":"Hum, I would prefer to make the following for optional, instead of creating an useless empty list. What do you think?\n\nYou can just write \"if extra_sanitize_keys: for ...\"\n\nIf you want to avoid the if, just set the default value of the parameter to an empty tuple ;-)","commit_id":"08c443b25ddcd1eebc6e607f18fc42c985b02cfa"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0a31cff92b8deb0a9b04a0c1c9a45ab7327638a0","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                message \u003d re.sub(pattern, substitute1, message)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    # handle extra sanitize keys"},{"line_number":279,"context_line":"    if extra_sanitize_keys is None:"},{"line_number":280,"context_line":"        extra_sanitize_keys \u003d []"},{"line_number":281,"context_line":"    for key in extra_sanitize_keys:"},{"line_number":282,"context_line":"        if key in message:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_34403aa5","line":279,"in_reply_to":"da85f559_d408cedb","updated":"2015-11-16 09:12:48.000000000","message":"empty tuple  is good.","commit_id":"08c443b25ddcd1eebc6e607f18fc42c985b02cfa"}],"oslo_utils/tests/test_strutils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5e4f0f75ce54e50dde6541412d39ea1c939e1774","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        payload \u003d \u0027mysqld --spassword \"aaaaaa\"\u0027"},{"line_number":598,"context_line":"        expected \u003d \u0027mysqld --spassword \"aaaaaa\"\u0027"},{"line_number":599,"context_line":"        actual \u003d strutils.mask_password(payload)"},{"line_number":600,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_149bb673","line":598,"updated":"2015-11-16 08:48:42.000000000","message":"expected variable can be removed here, just reuse payload, no?","commit_id":"08c443b25ddcd1eebc6e607f18fc42c985b02cfa"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0a31cff92b8deb0a9b04a0c1c9a45ab7327638a0","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        payload \u003d \u0027mysqld --spassword \"aaaaaa\"\u0027"},{"line_number":598,"context_line":"        expected \u003d \u0027mysqld --spassword \"aaaaaa\"\u0027"},{"line_number":599,"context_line":"        actual \u003d strutils.mask_password(payload)"},{"line_number":600,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_945d667b","line":598,"in_reply_to":"da85f559_149bb673","updated":"2015-11-16 09:12:48.000000000","message":"yes, that looks better","commit_id":"08c443b25ddcd1eebc6e607f18fc42c985b02cfa"}]}