)]}'
{"oslo_utils/strutils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"079cb7c141b47b48d76be12134437d642f4639e5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# NOTE(flaper87): The following globals are used by `mask_password`"},{"line_number":54,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_pass\u0027, \u0027password\u0027, \u0027admin_password\u0027,"},{"line_number":55,"context_line":"                  \u0027auth_token\u0027, \u0027new_pass\u0027, \u0027auth_password\u0027, \u0027secret_uuid\u0027,"},{"line_number":56,"context_line":"                  \u0027secret\u0027, \u0027sys_pswd\u0027, \u0027token\u0027, \u0027configdrive\u0027, \u0027CHAPPASSWORD\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# NOTE(ldbragst): Let\u0027s build a list of regex objects using the list of"},{"line_number":59,"context_line":"# _SANITIZE_KEYS we already have. This way, we only have to add the new key"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c5cca86c","line":56,"updated":"2016-02-22 22:08:57.000000000","message":"You can achieve the same thing in a more widely useful way by just adding \"PASSWORD\" instead.","commit_id":"4a9e24d39b5d5040d375bee001cffa0bc117ccb9"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"26b6208eb302e9fda95188d5862f2d5e6b1a832b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# NOTE(flaper87): The following globals are used by `mask_password`"},{"line_number":54,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_pass\u0027, \u0027password\u0027, \u0027admin_password\u0027,"},{"line_number":55,"context_line":"                  \u0027auth_token\u0027, \u0027new_pass\u0027, \u0027auth_password\u0027, \u0027secret_uuid\u0027,"},{"line_number":56,"context_line":"                  \u0027secret\u0027, \u0027sys_pswd\u0027, \u0027token\u0027, \u0027configdrive\u0027, \u0027CHAPPASSWORD\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# NOTE(ldbragst): Let\u0027s build a list of regex objects using the list of"},{"line_number":59,"context_line":"# _SANITIZE_KEYS we already have. This way, we only have to add the new key"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_9a0afa77","line":56,"in_reply_to":"bae84128_c5cca86c","updated":"2016-02-23 17:24:07.000000000","message":"Done","commit_id":"4a9e24d39b5d5040d375bee001cffa0bc117ccb9"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e3770607e3586f2cad09d2ce7a7206b3d46c500e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_pass\u0027, \u0027password\u0027, \u0027admin_password\u0027,"},{"line_number":55,"context_line":"                  \u0027auth_token\u0027, \u0027new_pass\u0027, \u0027auth_password\u0027, \u0027secret_uuid\u0027,"},{"line_number":56,"context_line":"                  \u0027secret\u0027, \u0027sys_pswd\u0027, \u0027token\u0027, \u0027configdrive\u0027,"},{"line_number":57,"context_line":"                  \u0027CHAPPASSWORD\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# NOTE(ldbragst): Let\u0027s build a list of regex objects using the list of"},{"line_number":60,"context_line":"# _SANITIZE_KEYS we already have. This way, we only have to add the new key"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_ae0a351f","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":31},"updated":"2016-03-02 17:41:51.000000000","message":"No need to add this.  Better to just substitute on password. But need to change this code to be case insensitive.","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9e07b4cc8907165cdf886de335956010ca90ac1c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_pass\u0027, \u0027password\u0027, \u0027admin_password\u0027,"},{"line_number":55,"context_line":"                  \u0027auth_token\u0027, \u0027new_pass\u0027, \u0027auth_password\u0027, \u0027secret_uuid\u0027,"},{"line_number":56,"context_line":"                  \u0027secret\u0027, \u0027sys_pswd\u0027, \u0027token\u0027, \u0027configdrive\u0027,"},{"line_number":57,"context_line":"                  \u0027CHAPPASSWORD\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# NOTE(ldbragst): Let\u0027s build a list of regex objects using the list of"},{"line_number":60,"context_line":"# _SANITIZE_KEYS we already have. This way, we only have to add the new key"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_66fb0d48","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":31},"in_reply_to":"7af24918_a376a7a1","updated":"2016-03-03 08:11:13.000000000","message":"This was my patch, and that was the recommendation of a previous reviewer.","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"89fc1e43403c2ddee6464074abe76d9d9ee7e2f8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_pass\u0027, \u0027password\u0027, \u0027admin_password\u0027,"},{"line_number":55,"context_line":"                  \u0027auth_token\u0027, \u0027new_pass\u0027, \u0027auth_password\u0027, \u0027secret_uuid\u0027,"},{"line_number":56,"context_line":"                  \u0027secret\u0027, \u0027sys_pswd\u0027, \u0027token\u0027, \u0027configdrive\u0027,"},{"line_number":57,"context_line":"                  \u0027CHAPPASSWORD\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# NOTE(ldbragst): Let\u0027s build a list of regex objects using the list of"},{"line_number":60,"context_line":"# _SANITIZE_KEYS we already have. This way, we only have to add the new key"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_a376a7a1","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":31},"in_reply_to":"7af24918_ae0a351f","updated":"2016-03-03 07:37:35.000000000","message":"If \u0027CHAPPASSWORD\u0027 can be substituted by password, \u0027admin_password\u0027, \u0027auth_password\u0027 also can. I think this should be addressed in another patch, not this patch, thanks!","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"822e7a2a23e9a3f06b27c4f7282f0837498df726","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    .. versionchanged:: 3.4"},{"line_number":268,"context_line":"       Replace also ``\u0027configdrive\u0027`` key."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    .. versionchanged:: 3.7"},{"line_number":271,"context_line":"       Replace also ``\u0027CHAPPASSWORD\u0027`` key."},{"line_number":272,"context_line":"    \"\"\""},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_538ff8cb","line":270,"range":{"start_line":270,"start_character":26,"end_line":270,"end_character":27},"updated":"2016-03-02 12:30:04.000000000","message":"should be 3.8 now","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9e07b4cc8907165cdf886de335956010ca90ac1c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    .. versionchanged:: 3.4"},{"line_number":268,"context_line":"       Replace also ``\u0027configdrive\u0027`` key."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    .. versionchanged:: 3.7"},{"line_number":271,"context_line":"       Replace also ``\u0027CHAPPASSWORD\u0027`` key."},{"line_number":272,"context_line":"    \"\"\""},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_46f89149","line":270,"range":{"start_line":270,"start_character":26,"end_line":270,"end_character":27},"in_reply_to":"7af24918_469b7172","updated":"2016-03-03 08:11:13.000000000","message":"Done","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"89fc1e43403c2ddee6464074abe76d9d9ee7e2f8","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    .. versionchanged:: 3.4"},{"line_number":268,"context_line":"       Replace also ``\u0027configdrive\u0027`` key."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    .. versionchanged:: 3.7"},{"line_number":271,"context_line":"       Replace also ``\u0027CHAPPASSWORD\u0027`` key."},{"line_number":272,"context_line":"    \"\"\""},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b19d540c","line":270,"range":{"start_line":270,"start_character":26,"end_line":270,"end_character":27},"in_reply_to":"7af24918_538ff8cb","updated":"2016-03-03 07:37:35.000000000","message":"Why should be 3.8 now? 3.7 is not used anyway.","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"dcac0b42d7aa41b1903435fc4f9e12eb8081bcfa","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    .. versionchanged:: 3.4"},{"line_number":268,"context_line":"       Replace also ``\u0027configdrive\u0027`` key."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    .. versionchanged:: 3.7"},{"line_number":271,"context_line":"       Replace also ``\u0027CHAPPASSWORD\u0027`` key."},{"line_number":272,"context_line":"    \"\"\""},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_469b7172","line":270,"range":{"start_line":270,"start_character":26,"end_line":270,"end_character":27},"in_reply_to":"7af24918_b19d540c","updated":"2016-03-03 08:04:21.000000000","message":"we have released 3.7, this change should include next release.\nhttps://github.com/openstack/oslo.utils/tree/3.7.0","commit_id":"16a5386852796d01a253c00ce97c4567174058ce"}]}