)]}'
{"oslo_utils/netutils.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"4d5317381c29b01cb95045a0035c72fb7c8c948d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        return netaddr.valid_ipv4(address)"},{"line_number":95,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":96,"context_line":"        return False"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0e0ef531","line":95,"range":{"start_line":95,"start_character":10,"end_line":95,"end_character":33},"updated":"2016-05-25 07:08:31.000000000","message":"netaddr.valid_ipv4 only raises exception netaddr.AddrFormatError now, so this change still handles the exception well. \n\nBut this change has potential risk when netaddr changes its API and raises other type exception. oslo.utils as a library should keep consistent behavior, so I don\u0027t think we should change this. what do you think ?","commit_id":"27dbe1e7460f067d5c0841ebc158364211add4e0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"3ce214a219c1e3025157d142bd3dd7542d7738b6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        return netaddr.valid_ipv4(address)"},{"line_number":95,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":96,"context_line":"        return False"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_f0855959","line":95,"range":{"start_line":95,"start_character":10,"end_line":95,"end_character":33},"in_reply_to":"9abb7d3a_29faee42","updated":"2016-05-30 06:26:25.000000000","message":"ok,I won\u0027t block this, would like to see others comment.","commit_id":"27dbe1e7460f067d5c0841ebc158364211add4e0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e0de11511c99b6acc0937c64b8d58647c312e704","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        return netaddr.valid_ipv4(address)"},{"line_number":95,"context_line":"    except netaddr.AddrFormatError:"},{"line_number":96,"context_line":"        return False"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_29faee42","line":95,"range":{"start_line":95,"start_character":10,"end_line":95,"end_character":33},"in_reply_to":"bab6814e_0e0ef531","updated":"2016-05-29 04:17:53.000000000","message":"I think we probably should yell at the library author if it does raise some new exception; I do wonder what other kind of exception could be raised from a validation function, there isn\u0027t many other types that could be raised (since all it does is validate, ha).","commit_id":"27dbe1e7460f067d5c0841ebc158364211add4e0"}]}