)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3eaab67effc807ca7cb4dff4a1f135247b44d4f9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"way in which isotime() returns results. Specifically, these two"},{"line_number":21,"context_line":"situations are known."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"1. If you provide isotime() with a timestamp that includes timezone"},{"line_number":24,"context_line":"information, the old isotime() would wilfully ignore it, the new one"},{"line_number":25,"context_line":"will produce offset information in the resulting string. If the"},{"line_number":26,"context_line":"timezone is UTC, you will get the \u0027Z\u0027 suffix, if it is non-UTC, you"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_d9dcab48","line":23,"updated":"2016-06-16 19:04:02.000000000","message":"split these out into a separate commit.","commit_id":"105ca9241d6982984bf0ac29c81e22cbf2323561"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a3462dd1a064fc8b03e0b3b63da0a68e6a565519","unresolved":false,"context_lines":[{"line_number":20,"context_line":"way in which isotime() returns results. Specifically, these two"},{"line_number":21,"context_line":"situations are known."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"1. If you provide isotime() with a timestamp that includes timezone"},{"line_number":24,"context_line":"information, the old isotime() would wilfully ignore it, the new one"},{"line_number":25,"context_line":"will produce offset information in the resulting string. If the"},{"line_number":26,"context_line":"timezone is UTC, you will get the \u0027Z\u0027 suffix, if it is non-UTC, you"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_c5a01993","line":23,"in_reply_to":"7aa08908_d9dcab48","updated":"2016-06-17 11:51:07.000000000","message":"Done","commit_id":"105ca9241d6982984bf0ac29c81e22cbf2323561"}],"oslo_utils/timeutils.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9d043e24705b024b9e4233b7916442cb3e9de17e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"_MAX_DATETIME_SEC \u003d 59"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def utcnow_aware():"},{"line_number":42,"context_line":"    \"\"\"An aware utcnow() that uses zulutime for the tzinfo.\"\"\""},{"line_number":43,"context_line":"    return datetime.datetime.now(iso8601.UTC)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7881c3c2","line":41,"updated":"2016-06-14 13:14:09.000000000","message":"This is utcnow(True) IIUC","commit_id":"86fc7b632a8697247e35dba517fcf04a82438104"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"60e22b79a3bdbd5b7053fefd7e5bc5885d403158","unresolved":false,"context_lines":[{"line_number":38,"context_line":"_MAX_DATETIME_SEC \u003d 59"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def utcnow_aware():"},{"line_number":42,"context_line":"    \"\"\"An aware utcnow() that uses zulutime for the tzinfo.\"\"\""},{"line_number":43,"context_line":"    return datetime.datetime.now(iso8601.UTC)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_efa83522","line":41,"in_reply_to":"7aa08908_7881c3c2","updated":"2016-06-14 18:01:50.000000000","message":"Done","commit_id":"86fc7b632a8697247e35dba517fcf04a82438104"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"848d92bfe48428d5cc3d87d543068405d38e1070","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # either we are provided a naive time (tm) or no tm, or an"},{"line_number":97,"context_line":"        # aware UTC time. In any event, we want to use \u0027Z\u0027 for the"},{"line_number":98,"context_line":"        # timezone rather than the full 6 character offset."},{"line_number":99,"context_line":"        _dt \u003d _dt.replace(tzinfo\u003dNone)"},{"line_number":100,"context_line":"        ts \u003d _dt.isoformat()"},{"line_number":101,"context_line":"        ts +\u003d \u0027Z\u0027"},{"line_number":102,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_94a0a891","line":99,"updated":"2016-06-14 17:32:02.000000000","message":"Idea, is it better to just raise a value error on a time without a tzinfo; or have it by default raise a value error, and add a way to make it so that those types of errors can be defaulted to UTC (but explicitly doing this); so that projects that are doing things without datetime with no time zone information actually get to know they are doing things badly...\n\nSomething like a \u0027force_utc_if_no_tz\u003dFalse\u0027 keyword argument (that would default to raise a value error) that people would have to provide to activate the behavior of defaulting to UTC...\n\nThoughts?","commit_id":"86fc7b632a8697247e35dba517fcf04a82438104"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b635879843f105d12d100471a96a614ef94f2cf1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # either we are provided a naive time (tm) or no tm, or an"},{"line_number":97,"context_line":"        # aware UTC time. In any event, we want to use \u0027Z\u0027 for the"},{"line_number":98,"context_line":"        # timezone rather than the full 6 character offset."},{"line_number":99,"context_line":"        _dt \u003d _dt.replace(tzinfo\u003dNone)"},{"line_number":100,"context_line":"        ts \u003d _dt.isoformat()"},{"line_number":101,"context_line":"        ts +\u003d \u0027Z\u0027"},{"line_number":102,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_819865c1","line":99,"in_reply_to":"7aa08908_94a0a891","updated":"2016-06-14 18:06:35.000000000","message":"there\u0027s a generally accepted feeling that a timestamp with no timezone is valid, and it is up to an application to treat it either as UTC or local time (at its sole discretion).\n\nIn this case, we\u0027re treating it as UTC which seems to be just as valid as treating it as localtime, as a matter of general course.\n\nIn client-server style applications though it is generally considered bad form for a server to make the choice of anything other than UTC.","commit_id":"86fc7b632a8697247e35dba517fcf04a82438104"}]}
