)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"541ad7baac88aad2f4ddfab63ad40d159ac69fbb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add method is_valid_ipv6_cidr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"method is_valid_ipv6_cidr is defined in Nova[1] and Cinder[2],"},{"line_number":10,"context_line":"It\u0027s good for oslo.utils to adopt it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]http://git.openstack.org/cgit/openstack/nova/tree/nova/utils.py#n540"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_e7b2694b","line":9,"updated":"2016-09-26 22:12:10.000000000","message":"Cinder?","commit_id":"3248be81b58d89e36ef8a72051754e2d41ec858e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"541ad7baac88aad2f4ddfab63ad40d159ac69fbb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It\u0027s good for oslo.utils to adopt it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]http://git.openstack.org/cgit/openstack/nova/tree/nova/utils.py#n540"},{"line_number":13,"context_line":"[2]http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/utils.py#n303"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic98d537560be28591f220a40fe0262ad3b891eb6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_84cd2333","line":13,"updated":"2016-09-26 22:12:10.000000000","message":"This doesn\u0027t look like \"Cinder\"\n\nAlso a \"permalink\" would be better. Like:\n\nhttps://github.com/openstack/ironic/blob/659f951d72e96f39bb967455a6855682e517ca43/ironic/common/utils.py#L303-L308\n\nOr\n\nhttp://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/utils.py?id\u003d659f951d72e96f39bb967455a6855682e517ca43#n303","commit_id":"3248be81b58d89e36ef8a72051754e2d41ec858e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cf6c54a1b2b91cc37e1566eba01d79b720486db0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"method is_valid_ipv6_cidr is defined in Nova[1] and Ironic[2],"},{"line_number":10,"context_line":"It\u0027s good for oslo.utils to adopt it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]https://github.com/openstack/nova/blob/\\"},{"line_number":13,"context_line":"56787db6301741240da5a44026edf82ca4cfed37/nova/utils.py#L540-L545"},{"line_number":14,"context_line":"[2]https://github.com/openstack/ironic/blob/\\"},{"line_number":15,"context_line":"659f951d72e96f39bb967455a6855682e517ca43/ironic/common/utils.py#L303-L308"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_1c15e39a","line":12,"updated":"2016-09-27 03:30:51.000000000","message":"I would just break the rule about 72 max line width, so that the link is all on one line. But that is me :)","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"48c8bd57500a934d5596e6d86855e6caa5d48e8d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"method is_valid_ipv6_cidr is defined in Nova[1] and Ironic[2],"},{"line_number":10,"context_line":"It\u0027s good for oslo.utils to adopt it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]https://github.com/openstack/nova/blob/\\"},{"line_number":13,"context_line":"56787db6301741240da5a44026edf82ca4cfed37/nova/utils.py#L540-L545"},{"line_number":14,"context_line":"[2]https://github.com/openstack/ironic/blob/\\"},{"line_number":15,"context_line":"659f951d72e96f39bb967455a6855682e517ca43/ironic/common/utils.py#L303-L308"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_693d10bb","line":12,"in_reply_to":"5a8bc5a2_1c15e39a","updated":"2016-09-27 20:48:12.000000000","message":"I tend to agree.  I think the pep8 check (when we had one) even had exceptions for long addresses.\n\nThat said, this provides sufficient information to find the relevant code so I wouldn\u0027t -1 for it.","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"76214001650d21786aabff6e13c9fb4c253043dd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"method is_valid_ipv6_cidr is defined in Nova[1] and Ironic[2],"},{"line_number":10,"context_line":"It\u0027s good for oslo.utils to adopt it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]https://github.com/openstack/nova/blob/\\"},{"line_number":13,"context_line":"56787db6301741240da5a44026edf82ca4cfed37/nova/utils.py#L540-L545"},{"line_number":14,"context_line":"[2]https://github.com/openstack/ironic/blob/\\"},{"line_number":15,"context_line":"659f951d72e96f39bb967455a6855682e517ca43/ironic/common/utils.py#L303-L308"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_3411985e","line":12,"in_reply_to":"5a8bc5a2_693d10bb","updated":"2016-09-28 02:34:20.000000000","message":"will put in one line","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"}],"oslo_utils/netutils.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"84649212dc51737bf6b9f833498319ee36ecbdf3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"def is_valid_ipv6_cidr(address):"},{"line_number":141,"context_line":"    \"\"\"Verify that address represents a valid IPv6 CIDR address."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param address: Value to verify"},{"line_number":144,"context_line":"    :type address: string"},{"line_number":145,"context_line":"    :returns: bool"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_9fba8e09","line":143,"range":{"start_line":143,"start_character":20,"end_line":143,"end_character":25},"updated":"2016-09-27 21:36:53.000000000","message":"nit: s/value/address","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"76214001650d21786aabff6e13c9fb4c253043dd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"def is_valid_ipv6_cidr(address):"},{"line_number":141,"context_line":"    \"\"\"Verify that address represents a valid IPv6 CIDR address."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param address: Value to verify"},{"line_number":144,"context_line":"    :type address: string"},{"line_number":145,"context_line":"    :returns: bool"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_b405a815","line":143,"range":{"start_line":143,"start_character":20,"end_line":143,"end_character":25},"in_reply_to":"5a8bc5a2_9fba8e09","updated":"2016-09-28 02:34:20.000000000","message":"Done","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"84649212dc51737bf6b9f833498319ee36ecbdf3","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param address: Value to verify"},{"line_number":144,"context_line":"    :type address: string"},{"line_number":145,"context_line":"    :returns: bool"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    .. versionadded:: 3.16"},{"line_number":148,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_5fc0067d","line":145,"range":{"start_line":145,"start_character":14,"end_line":145,"end_character":18},"updated":"2016-09-27 21:36:53.000000000","message":"nit: \"true if address is valid, false otherwise\"","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"76214001650d21786aabff6e13c9fb4c253043dd","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param address: Value to verify"},{"line_number":144,"context_line":"    :type address: string"},{"line_number":145,"context_line":"    :returns: bool"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    .. versionadded:: 3.16"},{"line_number":148,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_dffded09","line":145,"range":{"start_line":145,"start_character":14,"end_line":145,"end_character":18},"in_reply_to":"5a8bc5a2_5fc0067d","updated":"2016-09-28 02:34:20.000000000","message":"Done","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"84649212dc51737bf6b9f833498319ee36ecbdf3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    :type address: string"},{"line_number":145,"context_line":"    :returns: bool"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    .. versionadded:: 3.16"},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":"    try:"},{"line_number":150,"context_line":"        netaddr.IPNetwork(address, version\u003d6).cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_ffa392fe","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":26},"updated":"2016-09-27 21:36:53.000000000","message":"Current released version is 3.16, so this should be 3.17 or whatever next is.","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"76214001650d21786aabff6e13c9fb4c253043dd","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    :type address: string"},{"line_number":145,"context_line":"    :returns: bool"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    .. versionadded:: 3.16"},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":"    try:"},{"line_number":150,"context_line":"        netaddr.IPNetwork(address, version\u003d6).cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_3f0df137","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":26},"in_reply_to":"5a8bc5a2_ffa392fe","updated":"2016-09-28 02:34:20.000000000","message":"Done","commit_id":"1360db0e661a4aeac56e94e4f8884eaaa1cf1cec"}]}