)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"80c0495419a81ba1aeed056bdf30113a06032e08","unresolved":false,"context_lines":[{"line_number":10,"context_line":"matching, which could easily cause us to miss masking something that"},{"line_number":11,"context_line":"happens to use a different case. This switches to case-insensitive"},{"line_number":12,"context_line":"matching."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35cb98877a030f2eafe5b5ff88374c5a568bd53c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_64ba61e3","line":13,"updated":"2016-10-11 22:53:17.000000000","message":"Is there a bug associated with this? I guess I\u0027m wondering if an issue has come up which caused a problem or this is trying to be proactive.","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3c857c40e9f76758c481dbad240c404c2b52a269","unresolved":false,"context_lines":[{"line_number":10,"context_line":"matching, which could easily cause us to miss masking something that"},{"line_number":11,"context_line":"happens to use a different case. This switches to case-insensitive"},{"line_number":12,"context_line":"matching."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35cb98877a030f2eafe5b5ff88374c5a568bd53c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_eb6e5595","line":13,"in_reply_to":"fa6399be_64ba61e3","updated":"2016-10-18 10:17:37.000000000","message":"I agree, is there some actual situation where this happens? Trove has used this mask_password thing for a long time, and we certainly haven\u0027t faced issues with this.","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"c96eca528160d7b3c8f5e835d1c2379295849e54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"matching, which could easily cause us to miss masking something that"},{"line_number":11,"context_line":"happens to use a different case. This switches to case-insensitive"},{"line_number":12,"context_line":"matching."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35cb98877a030f2eafe5b5ff88374c5a568bd53c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da6895a0_e2dcdc48","line":13,"in_reply_to":"fa6399be_9b57a801","updated":"2016-10-20 19:58:13.000000000","message":"See response in the review comments","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"838d70e52beaf1baf2210b28c75a3abdbb20efdd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"matching, which could easily cause us to miss masking something that"},{"line_number":11,"context_line":"happens to use a different case. This switches to case-insensitive"},{"line_number":12,"context_line":"matching."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35cb98877a030f2eafe5b5ff88374c5a568bd53c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_9b57a801","line":13,"in_reply_to":"fa6399be_eb6e5595","updated":"2016-10-19 15:20:02.000000000","message":"++ to creating a bug","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"}],"oslo_utils/strutils.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"79d7deffb7fd764dc1e54f7f48af839507324bf1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"for key in _SANITIZE_KEYS:"},{"line_number":87,"context_line":"    _SANITIZE_PATTERNS_1[key] \u003d []"},{"line_number":88,"context_line":"    _SANITIZE_PATTERNS_2[key] \u003d []"},{"line_number":89,"context_line":"    flags \u003d re.DOTALL | re.IGNORECASE"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    for pattern in _FORMAT_PATTERNS_2:"},{"line_number":92,"context_line":"        reg_ex \u003d re.compile(pattern % {\u0027key\u0027: key}, flags\u003dflags)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_f1a1caaa","line":89,"updated":"2016-10-12 06:51:08.000000000","message":"This will increase a lot the time to sanitize thing, this method is used on every log lines. So if you have a particular case your are thinking about perhaps adding your needs in the _SANITIZE_KEYS list is a better approach.","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"4c52916f8455357588b7fedaf5893147bafc3daa","unresolved":false,"context_lines":[{"line_number":86,"context_line":"for key in _SANITIZE_KEYS:"},{"line_number":87,"context_line":"    _SANITIZE_PATTERNS_1[key] \u003d []"},{"line_number":88,"context_line":"    _SANITIZE_PATTERNS_2[key] \u003d []"},{"line_number":89,"context_line":"    flags \u003d re.DOTALL | re.IGNORECASE"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    for pattern in _FORMAT_PATTERNS_2:"},{"line_number":92,"context_line":"        reg_ex \u003d re.compile(pattern % {\u0027key\u0027: key}, flags\u003dflags)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_f9b60589","line":89,"in_reply_to":"fa6399be_d99ea1b7","updated":"2016-10-12 12:36:48.000000000","message":"Assuming that this does increase the time taken here, note that:\n1) adding keys would also do that and \n2) https://review.openstack.org/#/c/385197/ would conversely decrease the time taken (testing fewer patterns and fewer keys)\n\nI suspect together these two patches will actually reduce the time taken, but I haven\u0027t run any tests to prove that.","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cf93464c79d9067b83144eb67d4122c15c96737f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"for key in _SANITIZE_KEYS:"},{"line_number":87,"context_line":"    _SANITIZE_PATTERNS_1[key] \u003d []"},{"line_number":88,"context_line":"    _SANITIZE_PATTERNS_2[key] \u003d []"},{"line_number":89,"context_line":"    flags \u003d re.DOTALL | re.IGNORECASE"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    for pattern in _FORMAT_PATTERNS_2:"},{"line_number":92,"context_line":"        reg_ex \u003d re.compile(pattern % {\u0027key\u0027: key}, flags\u003dflags)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_d99ea1b7","line":89,"in_reply_to":"fa6399be_f1a1caaa","updated":"2016-10-12 12:21:04.000000000","message":"Is there data to back up the assertion that this will increase the time a lot?","commit_id":"78a530d4e4b26e05890def7b8188563169ac5f42"}]}