)]}'
{"oslo_utils/netutils.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ba2756ebb7f6801f05bf880eedebaa63306faefa","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    parts \u003d address.rsplit(\"%\", 1)"},{"line_number":114,"context_line":"    address \u003d parts[0]"},{"line_number":115,"context_line":"    scope \u003d parts[1] if len(parts) \u003e 1 else None"},{"line_number":116,"context_line":"    if scope is not None and (len(scope) \u003c 1 or len(scope) \u003e 15):"},{"line_number":117,"context_line":"        return False"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_20e480aa","line":116,"updated":"2016-11-01 19:13:22.000000000","message":"So why check len(scope) \u003e 15?\n\nLooking at https://tools.ietf.org/html/rfc4007#page-15 it doesn\u0027t seem to mention that its size restricted.\n\nAlso fe80::%2/64 appears to be valid but may get cut by your routine here?\n\nBtw, created https://github.com/drkjam/netaddr/issues/140 so that hopefully netaddr fixes this (perhaps reference this issue in your change, so that once netaddr fixes itself this code can be chopped).","commit_id":"778b943d635f14fecf8bcf743423977cb4e3ca8c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"3463253d6e2bec80d02354649795bd6b8af70e6f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    parts \u003d address.rsplit(\"%\", 1)"},{"line_number":114,"context_line":"    address \u003d parts[0]"},{"line_number":115,"context_line":"    scope \u003d parts[1] if len(parts) \u003e 1 else None"},{"line_number":116,"context_line":"    if scope is not None and (len(scope) \u003c 1 or len(scope) \u003e 15):"},{"line_number":117,"context_line":"        return False"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_a2b20de3","line":116,"in_reply_to":"ba5da102_20e480aa","updated":"2016-11-03 11:36:40.000000000","message":"+1 for fixing this in netaddr, more projects will get benefit in addition to OpenStack.","commit_id":"778b943d635f14fecf8bcf743423977cb4e3ca8c"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"227bd496cb62c65c07db852f4e0039008d5afabe","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    parts \u003d address.rsplit(\"%\", 1)"},{"line_number":114,"context_line":"    address \u003d parts[0]"},{"line_number":115,"context_line":"    scope \u003d parts[1] if len(parts) \u003e 1 else None"},{"line_number":116,"context_line":"    if scope is not None and (len(scope) \u003c 1 or len(scope) \u003e 15):"},{"line_number":117,"context_line":"        return False"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_9f958988","line":116,"in_reply_to":"ba5da102_20e480aa","updated":"2016-11-02 14:59:09.000000000","message":"The scope qualifier can consist of either the interface name or the interface index. Linux restricts interface names to 15 bytes.\n\nI would suggest simplifying the logic here:\n\n`scope is None or len(scope) \u003c 1 or len(scope) \u003e 15`","commit_id":"778b943d635f14fecf8bcf743423977cb4e3ca8c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a69490da8cb72907e328e4c131f791352f71213a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    parts \u003d address.rsplit(\"%\", 1)"},{"line_number":114,"context_line":"    address \u003d parts[0]"},{"line_number":115,"context_line":"    scope \u003d parts[1] if len(parts) \u003e 1 else None"},{"line_number":116,"context_line":"    if scope is not None and (len(scope) \u003c 1 or len(scope) \u003e 15):"},{"line_number":117,"context_line":"        return False"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_021d7965","line":116,"in_reply_to":"ba5da102_9f958988","updated":"2016-11-03 11:26:41.000000000","message":"Unfortunately that doesn\u0027t work -- if \u0027scope is None\u0027 then there was no scope provided, and we should continue with standard validation. What we are doing is checking that if there WAS a scope provided, that it is length between 1 and 15 inclusive.","commit_id":"778b943d635f14fecf8bcf743423977cb4e3ca8c"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"15bd08945598d3bb70debe7b04143846479f0be4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    parts \u003d address.rsplit(\"%\", 1)"},{"line_number":114,"context_line":"    address \u003d parts[0]"},{"line_number":115,"context_line":"    scope \u003d parts[1] if len(parts) \u003e 1 else None"},{"line_number":116,"context_line":"    if scope is not None and (len(scope) \u003c 1 or len(scope) \u003e 15):"},{"line_number":117,"context_line":"        return False"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_222a7d90","line":116,"in_reply_to":"ba5da102_a2b20de3","updated":"2016-11-03 11:43:17.000000000","message":"Yeah I think that\u0027s the right approach as well, I just figured we could get it fixed sooner here, but maybe that isn\u0027t true.\n\nAlso, I looked at many python libraries for handling IP addresses, and NONE of them handle this. It seems most simply use the C level libraries for checking, and on Linux systems *that* doesn\u0027t accept scoped addresses, while somehow on BSD systems (like OSX) it does. Just an interesting sidenote...","commit_id":"778b943d635f14fecf8bcf743423977cb4e3ca8c"}]}
