)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"9e408eda9e3d1c733839fa3f8928d3977bdda723","unresolved":false,"context_lines":[{"line_number":9,"context_line":"IPv6 addresses are commonly enclosed in square brackets"},{"line_number":10,"context_line":"in resource identifiers to allow them to be distinguished"},{"line_number":11,"context_line":"from port numbers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icdcf681c1d71a09b88b029f80d13cd5015dacd56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_eebba3c1","line":12,"updated":"2017-08-18 11:40:08.000000000","message":"Can you describe which projects will use the new function ？","commit_id":"2dc0dfbf7e9f93705d61e441fd248c4aaa035d57"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"a9a7e6416a3265e1288ef05b003403e312a152bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"IPv6 addresses are commonly enclosed in square brackets"},{"line_number":10,"context_line":"in resource identifiers to allow them to be distinguished"},{"line_number":11,"context_line":"from port numbers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icdcf681c1d71a09b88b029f80d13cd5015dacd56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_d16e40c8","line":12,"in_reply_to":"9f436f4f_eebba3c1","updated":"2017-08-18 11:51:40.000000000","message":"done","commit_id":"2dc0dfbf7e9f93705d61e441fd248c4aaa035d57"}],"oslo_utils/netutils.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7173bfa43be0005ee9aeebe71001d046fc2af08a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    \"\"\""},{"line_number":229,"context_line":"    if is_valid_ipv6(address):"},{"line_number":230,"context_line":"        return \"[%s]\" % address"},{"line_number":231,"context_line":"    return address"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"def is_valid_ip(address):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_d944051e","line":231,"updated":"2018-01-05 16:06:02.000000000","message":"It seems like if the address isn\u0027t valid this could raise an exception (ValueError?). What\u0027s the benefit of returning the input value unchanged instead of reporting the error?","commit_id":"785b33c29542639680659b1d68d9047df5af2964"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"70f825178900a6c0e7ff5f222c46f1f2cf18eae9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    \"\"\""},{"line_number":229,"context_line":"    if is_valid_ipv6(address):"},{"line_number":230,"context_line":"        return \"[%s]\" % address"},{"line_number":231,"context_line":"    return address"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"def is_valid_ip(address):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_da44f31d","line":231,"in_reply_to":"9f91af0f_7fdb59ec","updated":"2018-01-05 18:06:26.000000000","message":"Ah, so the caller can pass anything in as argument and if it looks like a v6 address it\u0027s escaped? I guess that\u0027s fine; it saves the separate check in the consuming code.","commit_id":"785b33c29542639680659b1d68d9047df5af2964"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"3579ad7e1f2944f169ce341a93066165f9f5bf5c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    \"\"\""},{"line_number":229,"context_line":"    if is_valid_ipv6(address):"},{"line_number":230,"context_line":"        return \"[%s]\" % address"},{"line_number":231,"context_line":"    return address"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"def is_valid_ip(address):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_7fdb59ec","line":231,"in_reply_to":"9f91af0f_d944051e","updated":"2018-01-05 17:47:02.000000000","message":"My intention was to wrap the IP address if it was IPv6 and leave unchanged if IPv4. \nPerhaps a rename to escape_if_ipv6 ?","commit_id":"785b33c29542639680659b1d68d9047df5af2964"}]}