)]}'
{"id":"openstack%2Foslo.utils~677770","triplet_id":"openstack%2Foslo.utils~master~I4b365cb05de98bdd498b3c2094e4a77ab3944b12","project":"openstack/oslo.utils","branch":"master","topic":"677770","hashtags":[],"change_id":"I4b365cb05de98bdd498b3c2094e4a77ab3944b12","subject":"Add digestmod when using hmac","status":"MERGED","created":"2019-08-21 15:53:01.000000000","updated":"2019-08-28 12:11:09.000000000","submitted":"2019-08-28 12:09:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677770-1566994149243-2a78a105","meta_rev_id":"fdcf406f1f8b5b1f8121f84600d7946bd29d24b1","_number":677770,"virtual_id_number":677770,"owner":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2019-08-28 12:09:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":2,"date":"2019-08-21 16:30:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":2,"date":"2019-08-28 10:18:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":1,"date":"2019-08-28 10:18:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-21 16:30:57.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-08-28 10:18:30.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-08-28 12:09:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"81d7be1d6c8cf20c44cd22c08165eb686481d102","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2019-08-21 15:53:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"368a86af205bd900652d188654c2eef110bee732","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2019-08-21 16:02:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"655523518e7a7e426a902d67cf281c8b2db959f9","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-08-21 16:21:09.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nIn the interest of not holding this up, I think I\u0027m just going to push my inline suggestion as a followup that we can squash into this if we want.","accounts_in_message":[],"_revision_number":2},{"id":"28efbc2da4c0bc011627910ab3f362afe732faf5","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2019-08-21 16:29:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6efafe130fdc0d489b3b59dd39da5176cbc4d368","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-08-21 16:30:57.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks","accounts_in_message":[],"_revision_number":3},{"id":"4c9e67f0532cff3d837663643a32d42e78d88591","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 18:31:54.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/2c960464129840ea8142ca3eb86ccc10 : SUCCESS in 1h 58m 35s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/31ae1c1eaf4f4665bf7dc6d93064e3e5 : SUCCESS in 1h 41m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/375a58dd983c4c97b935e90774f2c290 : SUCCESS in 6m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/232ba32517374d28a2e36822023610e8 : SUCCESS in 5m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/89e99030e0c34bc8a182c1dccf405539 : SUCCESS in 3m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ef98afeff23349c4b9aeeff348cc968c : SUCCESS in 6m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c602f28ad174482d8182c7fb1a2bb04e : SUCCESS in 6m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/64188f4fe70742588ffa6f4318e8a4de : SUCCESS in 4m 35s","accounts_in_message":[],"_revision_number":3},{"id":"b2d1d3468670ce45b183dbced647f0e5129c14dc","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-08-28 10:18:30.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"9756f8e6ae6087a16a8e1d9b89289cc2a7a1ee5a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 10:18:47.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"82bfb9ce6913130eb9141aa5abf10279a571ee69","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 12:09:08.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/159c65d2c8274387831629bdd45f94af : SUCCESS in 1h 47m 32s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/da12c52cfdfd450881e1452fb370aa72 : SUCCESS in 1h 24m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c5bb8f23e0de4d089dceff93838b3830 : SUCCESS in 5m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17cd99e67a1643d88bfa1769dc46e5ee : SUCCESS in 3m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/abb31765b2404c438b86c28f2fd1034d : SUCCESS in 4m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9a2060ea0298457aa3d58661771edf42 : SUCCESS in 4m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/59cdcc4d72c8451391ec3f1fc5c4d682 : SUCCESS in 5m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0ed25abc27d648ce94532552a331e25d : SUCCESS in 5m 05s","accounts_in_message":[],"_revision_number":3},{"id":"e4905da41cd1da6d05ec09435bd63ddeb6297dd2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 12:09:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"8f07328d1312e235452910a7ee9c959b826cf094","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 12:11:09.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/22e0184544354f07b2c57ace2ccb82b5 : SUCCESS in 1m 41s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5ae7d21f98bc8e6237f600f4885f94e57a2c99b1","revisions":{"f991efb355d03ce103f35a2931f5f8a4d665346c":{"kind":"REWORK","_number":1,"created":"2019-08-21 15:53:01.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/70/677770/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/70/677770/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/1"}}},"commit":{"parents":[{"commit":"1b8bafb391b82665b99b3da8205402ec2cd495d1","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/1b8bafb391b82665b99b3da8205402ec2cd495d1"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-08-21 15:44:16.000000000","tz":120},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-08-21 15:52:58.000000000","tz":120},"subject":"Add digestmod when using hmac","message":"Add digestmod when using hmac\n\nUntil Python 3.8 hmc.new() defaulted the digestmod argument to \u0027hmac-md5\u0027.\nThis was deperecated, to be removed in Python 3.8 [1], so let\u0027s get\nready for new python.\n\nChange-Id: I4b365cb05de98bdd498b3c2094e4a77ab3944b12\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/f991efb355d03ce103f35a2931f5f8a4d665346c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/f991efb355d03ce103f35a2931f5f8a4d665346c"}]},"branch":"refs/heads/master"},"892699e9d1bc9253f57da7849519e6e2e49c91f6":{"kind":"REWORK","_number":2,"created":"2019-08-21 16:02:06.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/70/677770/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/70/677770/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/2"}}},"commit":{"parents":[{"commit":"1b8bafb391b82665b99b3da8205402ec2cd495d1","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/1b8bafb391b82665b99b3da8205402ec2cd495d1"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-08-21 15:44:16.000000000","tz":120},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-08-21 16:00:15.000000000","tz":120},"subject":"Add digestmod when using hmac","message":"Add digestmod when using hmac\n\nUntil Python 3.8 hmc.new() defaulted the digestmod argument to \u0027hmac-md5\u0027.\nThis was deperecated, to be removed in Python 3.8 [1], so let\u0027s get\nready for new python.\n\n[1] https://docs.python.org/3.8/library/hmac.html\n\nChange-Id: I4b365cb05de98bdd498b3c2094e4a77ab3944b12\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/892699e9d1bc9253f57da7849519e6e2e49c91f6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/892699e9d1bc9253f57da7849519e6e2e49c91f6"}]},"branch":"refs/heads/master"},"5ae7d21f98bc8e6237f600f4885f94e57a2c99b1":{"kind":"REWORK","_number":3,"created":"2019-08-21 16:29:49.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/70/677770/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/70/677770/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/70/677770/3"}}},"commit":{"parents":[{"commit":"1b8bafb391b82665b99b3da8205402ec2cd495d1","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/1b8bafb391b82665b99b3da8205402ec2cd495d1"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-08-21 15:44:16.000000000","tz":120},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-08-21 16:28:09.000000000","tz":120},"subject":"Add digestmod when using hmac","message":"Add digestmod when using hmac\n\nUntil Python 3.8 hmc.new() defaulted the digestmod argument to \u0027hmac-md5\u0027.\nThis was deperecated, to be removed in Python 3.8 [1], so let\u0027s get\nready for new python.\n\nAlso switching to more secure sha1 algorithm, using md5 anywhere may\ntrigger alerts from automatic security tools.\n\n[1] https://docs.python.org/3.8/library/hmac.html\n\nChange-Id: I4b365cb05de98bdd498b3c2094e4a77ab3944b12\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/5ae7d21f98bc8e6237f600f4885f94e57a2c99b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/5ae7d21f98bc8e6237f600f4885f94e57a2c99b1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}