)]}'
{"id":"openstack%2Foslo.utils~699746","triplet_id":"openstack%2Foslo.utils~master~I0add2c96a9da510e1a9be0d6d07b7a6a33ac6528","project":"openstack/oslo.utils","branch":"master","topic":"remove-mox","hashtags":[],"change_id":"I0add2c96a9da510e1a9be0d6d07b7a6a33ac6528","subject":"tests: Convert remaining tests to mock","status":"MERGED","created":"2019-12-18 18:06:46.000000000","updated":"2020-02-28 20:43:37.000000000","submitted":"2020-02-28 20:41:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"699746-1582922497366-b70934f3","meta_rev_id":"3682c9997544140969b13c65150c609459ce25c8","_number":699746,"virtual_id_number":699746,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-28 20:41:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"recommended":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-02-28 14:51:37.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":2,"date":"2020-02-25 19:43:48.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2020-02-28 18:54:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-02-28 18:54:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-25 19:43:48.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-02-28 14:51:37.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-02-28 18:54:10.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2020-02-28 20:41:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b4ba72cff90f3076bebf4240bcf6d2e174769d9b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-18 18:06:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"37d61426b64e55fe4bccf22c5ed1616327e144f4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 19:43:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/ee329d161d1c4f28ba4f7a7bb88fa3d7 : SUCCESS in 1h 30m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4ffd2dbca9504a3c90caf747b4a29d69 : SUCCESS in 1h 23m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/09aa917535ee48aca73f04322d960d7c : FAILURE in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/00eba6af2f694a3da553c904fc6fde34 : SUCCESS in 3m 11s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/96e7f7df3a1645cab5bac15a8143b239 : FAILURE in 4m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/24046c0789a040e7a21f386256a78915 : FAILURE in 4m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b03041ec2c064ff0a0bf7e2dae3c170d : FAILURE in 5m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4c1e913180e14958af904c7cf1f29e93 : SUCCESS in 3m 47s","accounts_in_message":[],"_revision_number":1},{"id":"ec3fb64c2e4cb8cd8f74607e5b464c67d0086c14","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-25 16:55:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dd430682cfd1c86daae2f95c52debb87e20638cd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-25 18:40:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/71b0fb23a2e4427cbfc78b677b0eb898 : SUCCESS in 1h 39m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4df53d699bf2479c8fb161effc994fe2 : SUCCESS in 9m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c493ff64d10f4f2f8c49252c3c41ce87 : SUCCESS in 6m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4cba91881a764dfc838589bb908bcfab : SUCCESS in 9m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c10e0689338f467f9b96f2d3623062df : SUCCESS in 8m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/deb98a5a9c3d4ea08988aba3bbdef539 : FAILURE in 8m 30s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/06c3afffcb7140dfb4f571c238943b1b : SUCCESS in 8m 40s","accounts_in_message":[],"_revision_number":2},{"id":"53535933012092f1d34a606ab56ff316b1074711","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-02-25 19:43:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"649f7f71b9e71588f7c25672fea58ae36522ad2c","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-28 14:51:37.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, only +1 because I\u0027m not familliar with mox3 and I might missed things during this review I prefer let\u0027s a chance to other to review. so for the sake of a better point of view during review I prefer allow others core with more experience with mox3 to review too.\n\nAlso if I correctly understand it is a good things to drop mox usages so these changes looks good to follow this path.","accounts_in_message":[],"_revision_number":2},{"id":"2d7c8a3bdd3e005f3811cf02bebcb81342428f2e","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2020-02-28 18:54:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"1c0f7d0f2e2ddf7dbeec3b57d1033bfb9dbeec06","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-28 18:54:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0dd3f4f36adde525648d2b2ae917c0bec483f9a0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-28 20:41:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"973d5d47909c4d0abab91cbc1f06f0e4e893b1e3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-28 20:41:37.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5daddccd70e446e48a4e31e5345189e0 : SUCCESS in 1h 12m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3e6964f204f3474fb481675b6fd7fce8 : SUCCESS in 4m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/26b809584e5748158d6347e73c76e4c7 : SUCCESS in 5m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7ab2156e7dcb41399b07ae24c203856b : SUCCESS in 5m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/02cc6a23716c458f8f660d5a19aab055 : SUCCESS in 7m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/806bfa2133964a38aa2132dc93f1b3b1 : SUCCESS in 6m 50s","accounts_in_message":[],"_revision_number":2},{"id":"be27bcf68589ddf67f3aa15683610de6a5f8bdb3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-28 20:43:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6966d76801fe47d3a626c4dd4fc2d382 : SUCCESS in 1m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a830a6b8a18172ec22b343ffd9734355260e48e5","revisions":{"5cab1ab1c95a6837ff318d142ab47ef21a2bda77":{"kind":"REWORK","_number":1,"created":"2019-12-18 18:06:46.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/46/699746/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/46/699746/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/1"}}},"commit":{"parents":[{"commit":"e9ac79401a5058a34ecde1f7c88b6c1a6c2a9802","subject":"Flatten test case","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/e9ac79401a5058a34ecde1f7c88b6c1a6c2a9802"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-12-18 18:04:41.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-12-18 18:06:36.000000000","tz":0},"subject":"WIP: Convert tests to mock","message":"WIP: Convert tests to mock\n\nConvert remaining tests from mox to mock. This actually highlights\nsomething mock doesn\u0027t do that well - ensuring the order that things are\ncalled in. It\u0027s not a big deal and the tests are ultimately easier to\ngrok (IMO), but it\u0027s worth highlighting.\n\nChange-Id: I0add2c96a9da510e1a9be0d6d07b7a6a33ac6528\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/5cab1ab1c95a6837ff318d142ab47ef21a2bda77"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/5cab1ab1c95a6837ff318d142ab47ef21a2bda77"}]},"branch":"refs/heads/master"},"a830a6b8a18172ec22b343ffd9734355260e48e5":{"kind":"REWORK","_number":2,"created":"2020-02-25 16:55:02.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/46/699746/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/46/699746/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/46/699746/2"}}},"commit":{"parents":[{"commit":"7b7970f858a12f838958810b33bbcaa0a0090217","subject":"Flatten test case","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/7b7970f858a12f838958810b33bbcaa0a0090217"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-12-18 18:04:41.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-02-25 16:54:41.000000000","tz":0},"subject":"tests: Convert remaining tests to mock","message":"tests: Convert remaining tests to mock\n\nConvert remaining tests from mox to mock. This actually highlights\nsomething mock doesn\u0027t do that well - ensuring the order that things are\ncalled in. It\u0027s not a big deal and the tests are ultimately easier to\ngrok (IMO), but it\u0027s worth highlighting.\n\nChange-Id: I0add2c96a9da510e1a9be0d6d07b7a6a33ac6528\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/a830a6b8a18172ec22b343ffd9734355260e48e5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/a830a6b8a18172ec22b343ffd9734355260e48e5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}