)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa34cdacf6bde903621f49b545adc7936195235c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The data held within this section is particularly useful when dealing"},{"line_number":10,"context_line":"with encrypted LUKSv1, as shown below:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"$ qemu-img info --output\u003djson rbd:volumes/volume"},{"line_number":13,"context_line":"{"},{"line_number":14,"context_line":"    [..]"},{"line_number":15,"context_line":"    \"format-specific\": {"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_7f3776e5","line":12,"updated":"2020-02-13 17:07:06.000000000","message":"Sadly the man page [1] doesn\u0027t describe the output of this command, in any format, so I\u0027ve to trust you on this :(\n\n[1] https://linux.die.net/man/1/qemu-img","commit_id":"8bddd513af9cd2037a4c982a0a1d7c4d66e558e9"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"148ec6f1c5bfd55ccdfb663cf9c4ed6d8e4753de","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The data held within this section is particularly useful when dealing"},{"line_number":10,"context_line":"with encrypted LUKSv1, as shown below:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"$ qemu-img info --output\u003djson rbd:volumes/volume"},{"line_number":13,"context_line":"{"},{"line_number":14,"context_line":"    [..]"},{"line_number":15,"context_line":"    \"format-specific\": {"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_fa0ff487","line":12,"in_reply_to":"3fa7e38b_7f3776e5","updated":"2020-02-13 17:20:55.000000000","message":"That looks seriously out of date, on Fedora I get the following:\n\nhttps://qemu.weilnetz.de/doc/qemu-doc.html#qemu_005fimg_005finvocation\n\nThat said I also can\u0027t find any docs for this outside of the code:\n\nhttps://github.com/qemu/qemu/blob/d8d5fefd8657d4f7b380b3a1533340434b5b9def/qapi/crypto.json#L289-L298","commit_id":"8bddd513af9cd2037a4c982a0a1d7c4d66e558e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4b96d8b3a1114dec4b53b7c0da1ffa3383e3e81","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"    },"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":"Related-Bug: #1861071"},{"line_number":65,"context_line":"Change-Id: I133da07a5a9628b8a9338556939c858afae679f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_4a60b0d0","line":64,"updated":"2020-02-14 08:14:29.000000000","message":"nit: newline above this would be nice","commit_id":"0a793ba28a568360530b3b6717ba6179da4b5f78"}],"oslo_utils/imageutils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa34cdacf6bde903621f49b545adc7936195235c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            self.snapshots \u003d details.get(\u0027snapshots\u0027, [])"},{"line_number":60,"context_line":"            self.encrypted \u003d details.get(\u0027encrypted\u0027)"},{"line_number":61,"context_line":"            self.format_specific \u003d details.get(\u0027format-specific\u0027)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            details \u003d self._parse(cmd_output or \u0027\u0027)"},{"line_number":64,"context_line":"            self.image \u003d details.get(\u0027image\u0027)"},{"line_number":65,"context_line":"            self.backing_file \u003d details.get(\u0027backing_file\u0027)"},{"line_number":66,"context_line":"            self.file_format \u003d details.get(\u0027file_format\u0027)"},{"line_number":67,"context_line":"            self.virtual_size \u003d details.get(\u0027virtual_size\u0027)"},{"line_number":68,"context_line":"            self.cluster_size \u003d details.get(\u0027cluster_size\u0027)"},{"line_number":69,"context_line":"            self.disk_size \u003d details.get(\u0027disk_size\u0027)"},{"line_number":70,"context_line":"            self.snapshots \u003d details.get(\u0027snapshot_list\u0027, [])"},{"line_number":71,"context_line":"            self.encrypted \u003d details.get(\u0027encrypted\u0027)"},{"line_number":72,"context_line":"            self.format_specific \u003d None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __str__(self):"},{"line_number":75,"context_line":"        lines \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3f2d7e8f","line":72,"range":{"start_line":62,"start_character":0,"end_line":72,"end_character":39},"updated":"2020-02-13 17:07:06.000000000","message":"The only callers of this in nova seem to be using the default format or \u0027human\u0027, so is this actually going to be useful? If not, should we implement the parser for this?\n\nOn another note, I wonder can we kill this mode now? I guess not since most users of this from codesearch.o.o aren\u0027t providing this argument. Maybe we can switch the default instead?","commit_id":"8bddd513af9cd2037a4c982a0a1d7c4d66e558e9"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"148ec6f1c5bfd55ccdfb663cf9c4ed6d8e4753de","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            self.snapshots \u003d details.get(\u0027snapshots\u0027, [])"},{"line_number":60,"context_line":"            self.encrypted \u003d details.get(\u0027encrypted\u0027)"},{"line_number":61,"context_line":"            self.format_specific \u003d details.get(\u0027format-specific\u0027)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            details \u003d self._parse(cmd_output or \u0027\u0027)"},{"line_number":64,"context_line":"            self.image \u003d details.get(\u0027image\u0027)"},{"line_number":65,"context_line":"            self.backing_file \u003d details.get(\u0027backing_file\u0027)"},{"line_number":66,"context_line":"            self.file_format \u003d details.get(\u0027file_format\u0027)"},{"line_number":67,"context_line":"            self.virtual_size \u003d details.get(\u0027virtual_size\u0027)"},{"line_number":68,"context_line":"            self.cluster_size \u003d details.get(\u0027cluster_size\u0027)"},{"line_number":69,"context_line":"            self.disk_size \u003d details.get(\u0027disk_size\u0027)"},{"line_number":70,"context_line":"            self.snapshots \u003d details.get(\u0027snapshot_list\u0027, [])"},{"line_number":71,"context_line":"            self.encrypted \u003d details.get(\u0027encrypted\u0027)"},{"line_number":72,"context_line":"            self.format_specific \u003d None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __str__(self):"},{"line_number":75,"context_line":"        lines \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fab7f4f6","line":72,"range":{"start_line":62,"start_character":0,"end_line":72,"end_character":39},"in_reply_to":"3fa7e38b_3f2d7e8f","updated":"2020-02-13 17:20:55.000000000","message":"I\u0027m going to be using it directly in the fix for bug 1861071, I\u0027ll add Related-Bug: #1861071 to the commit message to make that clear now:\n\nhttps://review.opendev.org/#/c/706900/4/nova/virt/libvirt/driver.py@1955\n\nI\u0027d actually like to switch all callers in Nova over to JSON output in the future if possible, I\u0027ve just not had a chance to take a swing at that yet.","commit_id":"8bddd513af9cd2037a4c982a0a1d7c4d66e558e9"}]}