)]}'
{"oslo_utils/imageutils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe2a5e0f14f8ca21c1061a80329a4ce8e2f6be28","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                         re.I)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @debtcollector.removals.removed_kwarg(\u0027format\u0027,"},{"line_number":57,"context_line":"                            message\u003d\"human format support will be dropped\""},{"line_number":58,"context_line":"                            \"and json format will be the only one supported\")"},{"line_number":59,"context_line":"    def __init__(self, cmd_output\u003dNone, format\u003d\u0027json\u0027):"},{"line_number":60,"context_line":"        if format \u003d\u003d \u0027json\u0027:"},{"line_number":61,"context_line":"            details \u003d json.loads(cmd_output or \u0027{}\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_0defe784","line":58,"range":{"start_line":57,"start_character":28,"end_line":58,"end_character":76},"updated":"2020-02-26 10:49:50.000000000","message":"weird indentation. Also, the commit message could be more concise. How about:\n\n    Support for the \u0027human\u0027 format will be removed in a future release.\n\n?","commit_id":"75c84711ff0a5adf336edc5915e36a39215181d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe2a5e0f14f8ca21c1061a80329a4ce8e2f6be28","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.format_specific \u003d details.get(\u0027format-specific\u0027)"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            debtcollector.deprecate("},{"line_number":73,"context_line":"                \u0027human format is deprecated. format will be \u0027"},{"line_number":74,"context_line":"                \u0027removed and the only supported format will be json.\u0027"},{"line_number":75,"context_line":"                \u0027Use explicitly json instead\u0027,"},{"line_number":76,"context_line":"                version\u003d\"ussuri\", removal_version\u003d\"victoria\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6dfd3b39","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":51},"updated":"2020-02-26 10:49:50.000000000","message":"and","commit_id":"75c84711ff0a5adf336edc5915e36a39215181d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe2a5e0f14f8ca21c1061a80329a4ce8e2f6be28","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            debtcollector.deprecate("},{"line_number":73,"context_line":"                \u0027human format is deprecated. format will be \u0027"},{"line_number":74,"context_line":"                \u0027removed and the only supported format will be json.\u0027"},{"line_number":75,"context_line":"                \u0027Use explicitly json instead\u0027,"},{"line_number":76,"context_line":"                version\u003d\"ussuri\", removal_version\u003d\"victoria\","},{"line_number":77,"context_line":"                category\u003dFutureWarning)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ed9e0b06","line":74,"range":{"start_line":74,"start_character":24,"end_line":74,"end_character":68},"updated":"2020-02-26 10:49:50.000000000","message":"Drop this, IMO","commit_id":"75c84711ff0a5adf336edc5915e36a39215181d0"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1962624c546c5d59c193cb16a124ee3b0431f3b9","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @debtcollector.removals.removed_kwarg("},{"line_number":57,"context_line":"        \u0027format\u0027,"},{"line_number":58,"context_line":"        message\u003d\"Support for the \u0027human\u0027 format will be \""},{"line_number":59,"context_line":"        \"removed in a future release.\")"},{"line_number":60,"context_line":"    def __init__(self, cmd_output\u003dNone, format\u003d\u0027json\u0027):"},{"line_number":61,"context_line":"        if format \u003d\u003d \u0027json\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_fb123cb1","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":40},"updated":"2020-02-26 17:08:24.000000000","message":"Nit: I\u0027m proposing that we remove the format kwarg completely, not just the \u0027human\u0027 value. Also, if we do what I propose below this could read something more like: \u0027Overriding the qemu-img output format is no longer supported. The format kwarg will be removed in a future release.\u0027","commit_id":"11053e62795b4ebd2ebd347d58e04a155c0f31b1"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c34dadd19a4ac0f4dabde0e2d8f519f3a695e9d9","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @debtcollector.removals.removed_kwarg("},{"line_number":57,"context_line":"        \u0027format\u0027,"},{"line_number":58,"context_line":"        message\u003d\"Support for the \u0027human\u0027 format will be \""},{"line_number":59,"context_line":"        \"removed in a future release.\")"},{"line_number":60,"context_line":"    def __init__(self, cmd_output\u003dNone, format\u003d\u0027json\u0027):"},{"line_number":61,"context_line":"        if format \u003d\u003d \u0027json\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_85ae3e96","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":40},"in_reply_to":"1fa4df85_fb123cb1","updated":"2020-02-27 09:58:09.000000000","message":"I agree, my message could be ambiguous.","commit_id":"11053e62795b4ebd2ebd347d58e04a155c0f31b1"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1962624c546c5d59c193cb16a124ee3b0431f3b9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.encrypted \u003d details.get(\u0027encrypted\u0027)"},{"line_number":71,"context_line":"            self.format_specific \u003d details.get(\u0027format-specific\u0027)"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            debtcollector.deprecate("},{"line_number":74,"context_line":"                \u0027human format is deprecated and format will be \u0027"},{"line_number":75,"context_line":"                \u0027removed. Use explicitly json instead\u0027,"},{"line_number":76,"context_line":"                version\u003d\"ussuri\", removal_version\u003d\"victoria\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_7b45ecb2","line":73,"updated":"2020-02-26 17:08:24.000000000","message":"My thought was that we just remove this completely now. There should be no externally visible changes since we\u0027re parsing the human-readable values into plain bytes anyway (which again makes me wonder why human was ever an option...). Also, since human is broken in recent versions of qemu it\u0027s unlikely that forcing json would make things any worse for existing human users.","commit_id":"11053e62795b4ebd2ebd347d58e04a155c0f31b1"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c34dadd19a4ac0f4dabde0e2d8f519f3a695e9d9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.encrypted \u003d details.get(\u0027encrypted\u0027)"},{"line_number":71,"context_line":"            self.format_specific \u003d details.get(\u0027format-specific\u0027)"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            debtcollector.deprecate("},{"line_number":74,"context_line":"                \u0027human format is deprecated and format will be \u0027"},{"line_number":75,"context_line":"                \u0027removed. Use explicitly json instead\u0027,"},{"line_number":76,"context_line":"                version\u003d\"ussuri\", removal_version\u003d\"victoria\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_a5a1faab","line":73,"in_reply_to":"1fa4df85_7b45ecb2","updated":"2020-02-27 09:58:09.000000000","message":"I think remove this now is a little bit an abrupt change,  how to manage case where given input is still to `human` format?\n\nIn this case json loader will fail, we could catch exceptions but what we should return to users in this case?\n\nI think we should deprecate first during a short period to allow smooth migration for users and their inputs (changing command, etc...) and then completely drop this code and the `format` param in a second time.","commit_id":"11053e62795b4ebd2ebd347d58e04a155c0f31b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e46579bd45b87f8843a3e8fbcf1f535b117c3b06","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         r\"\\s*(\\w+)?(\\s*\\(\\s*(\\d+)\\s+bytes\\s*\\))?\","},{"line_number":54,"context_line":"                         re.I)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @debtcollector.removals.removed_kwarg("},{"line_number":57,"context_line":"        \u0027format\u0027,"},{"line_number":58,"context_line":"        message\u003d\"Overriding the qemu-img output format is no longer supported.\""},{"line_number":59,"context_line":"                \"The format kwarg will be removed in a future release.\""},{"line_number":60,"context_line":"                \"JSON will be the only supported format for input given by\""},{"line_number":61,"context_line":"                \"cmd_ouput\")"},{"line_number":62,"context_line":"    def __init__(self, cmd_output\u003dNone, format\u003d\u0027human\u0027):"},{"line_number":63,"context_line":"        if format \u003d\u003d \u0027json\u0027:"},{"line_number":64,"context_line":"            details \u003d json.loads(cmd_output or \u0027{}\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_9dfcfbb5","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":28},"updated":"2020-04-29 12:34:45.000000000","message":"This isn\u0027t ideal. Either we provide format\u003d\u0027json\u0027 and get this warning, or we don\u0027t provide this which means we get human format and the below warning.\n\nPerhaps we could deprecate the human format now and deprecate the parameter when the human format deprecation is complete?","commit_id":"0f5e2cf38b934528fd7cf99a40ef505fd73a4cb8"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d611b91d5dbe17240246d893d0ba5d9997f0f4e1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         r\"\\s*(\\w+)?(\\s*\\(\\s*(\\d+)\\s+bytes\\s*\\))?\","},{"line_number":54,"context_line":"                         re.I)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @debtcollector.removals.removed_kwarg("},{"line_number":57,"context_line":"        \u0027format\u0027,"},{"line_number":58,"context_line":"        message\u003d\"Overriding the qemu-img output format is no longer supported.\""},{"line_number":59,"context_line":"                \"The format kwarg will be removed in a future release.\""},{"line_number":60,"context_line":"                \"JSON will be the only supported format for input given by\""},{"line_number":61,"context_line":"                \"cmd_ouput\")"},{"line_number":62,"context_line":"    def __init__(self, cmd_output\u003dNone, format\u003d\u0027human\u0027):"},{"line_number":63,"context_line":"        if format \u003d\u003d \u0027json\u0027:"},{"line_number":64,"context_line":"            details \u003d json.loads(cmd_output or \u0027{}\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_3bbcf66a","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":28},"in_reply_to":"1f493fa4_3a0c313a","updated":"2020-09-23 13:21:02.000000000","message":"Sorry for the long delay, this topic was fall in a black hole in my universe, I\u0027ll address your comments soons.","commit_id":"0f5e2cf38b934528fd7cf99a40ef505fd73a4cb8"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"5ad97e587b36edda97dfde9fa1ebe1c6a71a89b1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         r\"\\s*(\\w+)?(\\s*\\(\\s*(\\d+)\\s+bytes\\s*\\))?\","},{"line_number":54,"context_line":"                         re.I)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @debtcollector.removals.removed_kwarg("},{"line_number":57,"context_line":"        \u0027format\u0027,"},{"line_number":58,"context_line":"        message\u003d\"Overriding the qemu-img output format is no longer supported.\""},{"line_number":59,"context_line":"                \"The format kwarg will be removed in a future release.\""},{"line_number":60,"context_line":"                \"JSON will be the only supported format for input given by\""},{"line_number":61,"context_line":"                \"cmd_ouput\")"},{"line_number":62,"context_line":"    def __init__(self, cmd_output\u003dNone, format\u003d\u0027human\u0027):"},{"line_number":63,"context_line":"        if format \u003d\u003d \u0027json\u0027:"},{"line_number":64,"context_line":"            details \u003d json.loads(cmd_output or \u0027{}\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_3a0c313a","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":28},"in_reply_to":"1f493fa4_9dfcfbb5","updated":"2020-05-07 15:09:54.000000000","message":"Yeah, I think if we don\u0027t want to break consumers we have to do it in 3 steps:\n\n1. Deprecate the human format\n2. Remove the human format, ignore the parameter value and deprecate the parameter\n3. Remove the parameter","commit_id":"0f5e2cf38b934528fd7cf99a40ef505fd73a4cb8"}],"oslo_utils/tests/test_imageutils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa89a7c0abd4c4a24d5d5dbedb632d83a23bf685","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import warnings"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslotest import base as test_base"},{"line_number":18,"context_line":"import testscenarios"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_ed45ab71","line":15,"updated":"2020-02-26 10:52:05.000000000","message":"nit: newline above this","commit_id":"448b20abbaa7259ef229a9d30383fba0bca219c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa89a7c0abd4c4a24d5d5dbedb632d83a23bf685","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_utils import imageutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from six.moves import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"load_tests \u003d testscenarios.load_tests_apply_scenarios"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_8d7d17b3","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":26},"updated":"2020-02-26 10:52:05.000000000","message":"Just use \u0027mock\u0027. We don\u0027t need to support Python 2 anymore and we can\u0027t switch to unittest.mock until we drop support for Python 3.6.","commit_id":"448b20abbaa7259ef229a9d30383fba0bca219c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fa89a7c0abd4c4a24d5d5dbedb632d83a23bf685","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            cls._qcow2_encrypted,"},{"line_number":196,"context_line":"            cls._qcow2_backing_file)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @mock.patch(\u0027warnings.warn\u0027)"},{"line_number":199,"context_line":"    def test_qemu_img_info_human_format(self, warn):"},{"line_number":200,"context_line":"        img_info \u003d self._initialize_img_info()"},{"line_number":201,"context_line":"        img_info \u003d img_info + (\u0027cluster_size: %s\u0027 % self.cluster_size,)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_ad5fb33f","line":198,"updated":"2020-02-26 10:52:05.000000000","message":"Can you mock debtcollector instead? This relies on an internal implementation detail of debtcollector.","commit_id":"448b20abbaa7259ef229a9d30383fba0bca219c3"}],"releasenotes/notes/drop-imageutils-human-format-support-a89101a36c4dd3cb.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe2a5e0f14f8ca21c1061a80329a4ce8e2f6be28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    On ``QemuImgInfo`` human ``format`` support will be dropped in next cycle."},{"line_number":5,"context_line":"    After this drop the only supported format will be json format. Qemu"},{"line_number":6,"context_line":"    introduced json output format since version 1.3"},{"line_number":7,"context_line":"    https://wiki.qemu.org/ChangeLog/1.3"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_ed6ccb09","line":7,"range":{"start_line":4,"start_character":0,"end_line":7,"end_character":39},"updated":"2020-02-26 10:49:50.000000000","message":"How about\n\n  The ``QemuImgInfo`` helper now defaults to parsing ``json`` format\n  by default. Support for parsing the ``human`` format has been\n  deprecated and will be removed in a future release. This\n  requires qemu `version 1.3`__ or greater\n\n  __ https://wiki.qemu.org/ChangeLog/1.3","commit_id":"75c84711ff0a5adf336edc5915e36a39215181d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e46579bd45b87f8843a3e8fbcf1f535b117c3b06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``QemuImgInfo`` helper now defaults to parsing ``json`` format"},{"line_number":5,"context_line":"    by default. Support for parsing the ``human`` format has been"},{"line_number":6,"context_line":"    deprecated and will be removed in a future release. This"},{"line_number":7,"context_line":"    requires qemu `version 1.3`__ or greater"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_7d248f5e","line":5,"range":{"start_line":4,"start_character":24,"end_line":5,"end_character":15},"updated":"2020-04-29 12:34:45.000000000","message":"This isn\u0027t true. It\u0027s still using human [1]\n\n[1] https://review.opendev.org/#/c/710005/7/oslo_utils/imageutils.py@62","commit_id":"0f5e2cf38b934528fd7cf99a40ef505fd73a4cb8"}]}