)]}'
{"oslo_utils/fnmatch.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c89ed0bfc587b53cfcdcfa7e07e55475d284c18f","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.simplefilter(\"always\", category\u003dDeprecationWarning)"},{"line_number":24,"context_line":"debtcollector.deprecate("},{"line_number":25,"context_line":"    \"Using the oslo.utils\u0027s \u0027fnmatch\u0027 module is deprecated, \""},{"line_number":26,"context_line":"    \"please use the stdlib \u0027fnmatch\u0027 module.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f07c0bd_2868f93e","line":23,"updated":"2021-06-30 10:55:09.000000000","message":"Actually, we probably want to remove this entirely. This should be done by the user themselves. I\u0027m assuming it was bad copy-paste","commit_id":"e1fcf0e00358c89ba571d7296a8ab18eeb3add84"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"adf367b21bbb6a85d454bb9344bc74c36e964aee","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.simplefilter(\"always\", category\u003dDeprecationWarning)"},{"line_number":24,"context_line":"debtcollector.deprecate("},{"line_number":25,"context_line":"    \"Using the oslo.utils\u0027s \u0027fnmatch\u0027 module is deprecated, \""},{"line_number":26,"context_line":"    \"please use the stdlib \u0027fnmatch\u0027 module.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"f145f1a9_e2297ce2","line":23,"in_reply_to":"1f07c0bd_2868f93e","updated":"2021-06-30 11:28:01.000000000","message":"ok can update and push new patch, but a question, atleast openstackclient was not showing deprecation warning of fnmatch by default with heatclient, is that expected?","commit_id":"e1fcf0e00358c89ba571d7296a8ab18eeb3add84"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6841c435c18e581a84851deca7571e7f1cb4ebce","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.simplefilter(\"always\", category\u003dDeprecationWarning)"},{"line_number":24,"context_line":"debtcollector.deprecate("},{"line_number":25,"context_line":"    \"Using the oslo.utils\u0027s \u0027fnmatch\u0027 module is deprecated, \""},{"line_number":26,"context_line":"    \"please use the stdlib \u0027fnmatch\u0027 module.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"4d209476_74aaf6ef","line":23,"in_reply_to":"6811552c_fa04171c","updated":"2021-06-30 14:55:30.000000000","message":"Done","commit_id":"e1fcf0e00358c89ba571d7296a8ab18eeb3add84"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"882a0578bab0150a94069537f342d69a2a1060bb","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.simplefilter(\"always\", category\u003dDeprecationWarning)"},{"line_number":24,"context_line":"debtcollector.deprecate("},{"line_number":25,"context_line":"    \"Using the oslo.utils\u0027s \u0027fnmatch\u0027 module is deprecated, \""},{"line_number":26,"context_line":"    \"please use the stdlib \u0027fnmatch\u0027 module.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"6811552c_fa04171c","line":23,"in_reply_to":"c3b5df8b_c2b091c3","updated":"2021-06-30 14:48:48.000000000","message":"Ok updating patch to remove it altogether.","commit_id":"e1fcf0e00358c89ba571d7296a8ab18eeb3add84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0365ecb7fca96f6a542d807aa03370f13ec10bb1","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.simplefilter(\"always\", category\u003dDeprecationWarning)"},{"line_number":24,"context_line":"debtcollector.deprecate("},{"line_number":25,"context_line":"    \"Using the oslo.utils\u0027s \u0027fnmatch\u0027 module is deprecated, \""},{"line_number":26,"context_line":"    \"please use the stdlib \u0027fnmatch\u0027 module.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"c3b5df8b_c2b091c3","line":23,"in_reply_to":"f145f1a9_e2297ce2","updated":"2021-06-30 13:21:27.000000000","message":"Yes, DeprecationWarning is disabled by default [1]. You would typically enable this in tox.ini or by calling this API in your code so that you see it as part of your unit tests and can address issues as they arise. For example, we do the latter in nova [2] and previously did the former too [3]\n\n[1] https://docs.python.org/3/library/exceptions.html#DeprecationWarning\n[2] https://github.com/openstack/nova/blob/ee3b4925064c843ba497179624e128985880a7d2/nova/tests/fixtures/nova.py#L738-L741\n[3] https://github.com/openstack/nova/commit/50ff47d55388a44b47b1e6a997e1eb1fd7d95510","commit_id":"e1fcf0e00358c89ba571d7296a8ab18eeb3add84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"05151441499fece4ad307d089b72ce1388a854ee","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import fnmatch as standard_fnmatch"},{"line_number":19,"context_line":"import warnings"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"45419176_b137808d","line":19,"updated":"2021-06-30 15:49:10.000000000","message":"you need to drop this import or pep8 will fail","commit_id":"da85800ea1e7022c53add8992567fd3538550472"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"600ecc620eb4cbfa9c4e72250ddd9f953ee1d4bd","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import fnmatch as standard_fnmatch"},{"line_number":19,"context_line":"import warnings"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import debtcollector"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0e9ec934_818d17ee","line":19,"in_reply_to":"45419176_b137808d","updated":"2021-07-01 04:51:41.000000000","message":"ahh missed, Thanks.","commit_id":"da85800ea1e7022c53add8992567fd3538550472"}]}
