)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1105195297d9cf463ec23e3acffa61f21e9004f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6da25b67_a01c238d","updated":"2021-12-20 18:46:40.000000000","message":"Looks pretty reasonable, though I do wonder if we can simplify this somewhat. Soft -1 to get the release note reworded. I\u0027m +2 once that\u0027s done","commit_id":"6e825a45f8a0cdbd3d59752185404bd95ae9655c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"134251798c0b5f43d8eb5e1c5e37b7b393782c45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e63dff42_3a4b9617","updated":"2022-01-12 08:55:33.000000000","message":"Thanks Daniel.\nThe latest PS address Stephen\u0027s comments so LGTM.","commit_id":"6e17ae1f7959c64dfd20a5f67edf422e702426aa"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"3e7171e176e04d5d144f5d1bc262b20fa99c479e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56e20133_b4a5c34d","updated":"2022-01-12 09:32:50.000000000","message":"You\u0027re welcome and thanks a lot Herve for the code review. ","commit_id":"6e17ae1f7959c64dfd20a5f67edf422e702426aa"}],"oslo_utils/strutils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1105195297d9cf463ec23e3acffa61f21e9004f3","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                      r\u0027\\\u0027\\s*,\\s*u?[\\\u0027\"])[^\\\"\\\u0027]*([\\\u0027\"])\u0027,"},{"line_number":91,"context_line":"                      r\u0027(%(key)s[0-9]*\\s*--?[A-z]+\\s*)\\S+(\\s*)\u0027]"},{"line_number":92,"context_line":"_FORMAT_PATTERNS_WILDCARD \u003d [r\u0027([\\\u0027\\\"][^\\\"\\\u0027]*%(key)s[0-9]*[\\\u0027\\\"]\\s*:\\s*\u0027"},{"line_number":93,"context_line":"                             r\u0027u?[\\\u0027\\\"].*[\\\u0027\\\"])[^\\\"\\\u0027]*([\\\u0027\\\"])\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# NOTE(dhellmann): Keep a separate list of patterns by key so we only"},{"line_number":96,"context_line":"# need to apply the substitutions for keys we find using a quick \"in\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a4f5eb8_9b0ed005","line":93,"updated":"2021-12-20 18:46:40.000000000","message":"Can you put this on one line and simply noqa it?\n\n  _FORMAT_PATTERNS_WILDCARD \u003d [\n      r\u0027([\\\u0027\\\"][^\\\"\\\u0027]*%(key)s[0-9]*[\\\u0027\\\"]\\s*:\\s*u?[\\\u0027\\\"].*[\\\u0027\\\"])[^\\\"\\\u0027]*([\\\u0027\\\"])\u0027,  # noqa: E501\n  ]\n\nThis is already tough to read and splitting it over many lines makes it even tougher, IMO 😊\n\n(This assumes we need the capturing group (brackets). Do we?","commit_id":"6e825a45f8a0cdbd3d59752185404bd95ae9655c"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"489af211687c43cc8d4751fa894872649959f891","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                      r\u0027\\\u0027\\s*,\\s*u?[\\\u0027\"])[^\\\"\\\u0027]*([\\\u0027\"])\u0027,"},{"line_number":91,"context_line":"                      r\u0027(%(key)s[0-9]*\\s*--?[A-z]+\\s*)\\S+(\\s*)\u0027]"},{"line_number":92,"context_line":"_FORMAT_PATTERNS_WILDCARD \u003d [r\u0027([\\\u0027\\\"][^\\\"\\\u0027]*%(key)s[0-9]*[\\\u0027\\\"]\\s*:\\s*\u0027"},{"line_number":93,"context_line":"                             r\u0027u?[\\\u0027\\\"].*[\\\u0027\\\"])[^\\\"\\\u0027]*([\\\u0027\\\"])\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# NOTE(dhellmann): Keep a separate list of patterns by key so we only"},{"line_number":96,"context_line":"# need to apply the substitutions for keys we find using a quick \"in\""}],"source_content_type":"text/x-python","patch_set":1,"id":"0942a917_09a89bec","line":93,"in_reply_to":"9a4f5eb8_9b0ed005","updated":"2022-01-10 09:54:51.000000000","message":"Yes I think in this case it will be better to have the regex on the same line.","commit_id":"6e825a45f8a0cdbd3d59752185404bd95ae9655c"}],"releasenotes/notes/fix_mask_password_regex-c0661f95a23369a4.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1105195297d9cf463ec23e3acffa61f21e9004f3","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix regex used to mask password. When the password contains"},{"line_number":5,"context_line":"    quotes or double quotes in the middle such as ``pass\"word``,"},{"line_number":6,"context_line":"    the ``strutils.mask_password`` function will return ``***\"word``."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6343e828_b3acb0d5","line":6,"updated":"2021-12-20 18:46:40.000000000","message":"This reads kind of weirdly. How about something as simple as:\n\n  The ``strutils.mask_password`` function will now correctly handle \n  passwords that contain single or double quotes. Previously, only the\n  characters before the quote were masked.","commit_id":"6e825a45f8a0cdbd3d59752185404bd95ae9655c"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"489af211687c43cc8d4751fa894872649959f891","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix regex used to mask password. When the password contains"},{"line_number":5,"context_line":"    quotes or double quotes in the middle such as ``pass\"word``,"},{"line_number":6,"context_line":"    the ``strutils.mask_password`` function will return ``***\"word``."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db55c967_a13e22c2","line":6,"in_reply_to":"6343e828_b3acb0d5","updated":"2022-01-10 09:54:51.000000000","message":"I agree.","commit_id":"6e825a45f8a0cdbd3d59752185404bd95ae9655c"}]}