)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"4975f3e18cee5ddb4b0f0c1c1ed61d8184b37548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"18b2f19e_978489b9","updated":"2022-07-18 15:17:08.000000000","message":"-1 to highlight my inline comment","commit_id":"8aed83a6c3d0640c5c0d41380daa2a138e74c585"}],"oslo_utils/reflection.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"4975f3e18cee5ddb4b0f0c1c1ed61d8184b37548","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def is_same_callback(callback1, callback2, strict\u003dTrue):"},{"line_number":164,"context_line":"    \"\"\"Returns if the two callbacks are the same."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    \u0027strict\u0027 arg has no meaning for python 3.8 onwards and will"}],"source_content_type":"text/x-python","patch_set":5,"id":"e8b89b4b_15d06412","side":"PARENT","line":163,"range":{"start_line":163,"start_character":43,"end_line":163,"end_character":54},"updated":"2022-07-18 15:17:08.000000000","message":"I think we need a deprecation period first. We\u0027ll be able to remove it in a near future to let\u0027s time to person who use this module to migrate their code.","commit_id":"7df64737c23f7e88cb4d8abe29245603864ed4f9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9581c6f4e68f1cd911a6ee39758f841063251b5a","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def is_same_callback(callback1, callback2, strict\u003dTrue):"},{"line_number":164,"context_line":"    \"\"\"Returns if the two callbacks are the same."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    \u0027strict\u0027 arg has no meaning for python 3.8 onwards and will"}],"source_content_type":"text/x-python","patch_set":5,"id":"8bb798dd_a5523f0e","side":"PARENT","line":163,"range":{"start_line":163,"start_character":43,"end_line":163,"end_character":54},"in_reply_to":"476435cd_74e4521c","updated":"2023-03-15 03:31:33.000000000","message":"I now noticed we Do have the warning message in L189 and this should allow users to ba aware of the deprecation. so I believe we can remove the method now.","commit_id":"7df64737c23f7e88cb4d8abe29245603864ed4f9"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a54d6efebf723b21122b353e79f6609403e2f9c9","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def is_same_callback(callback1, callback2, strict\u003dTrue):"},{"line_number":164,"context_line":"    \"\"\"Returns if the two callbacks are the same."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    \u0027strict\u0027 arg has no meaning for python 3.8 onwards and will"}],"source_content_type":"text/x-python","patch_set":5,"id":"14e8b953_25cdba81","side":"PARENT","line":163,"range":{"start_line":163,"start_character":43,"end_line":163,"end_character":54},"in_reply_to":"8bb798dd_a5523f0e","updated":"2023-03-20 13:36:25.000000000","message":"Yeah that WFM. Thanks","commit_id":"7df64737c23f7e88cb4d8abe29245603864ed4f9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8034752f8c5b1465c6a6725556d70a7f07838fda","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def is_same_callback(callback1, callback2, strict\u003dTrue):"},{"line_number":164,"context_line":"    \"\"\"Returns if the two callbacks are the same."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    \u0027strict\u0027 arg has no meaning for python 3.8 onwards and will"}],"source_content_type":"text/x-python","patch_set":5,"id":"476435cd_74e4521c","side":"PARENT","line":163,"range":{"start_line":163,"start_character":43,"end_line":163,"end_character":54},"in_reply_to":"e8b89b4b_15d06412","updated":"2022-07-18 15:40:11.000000000","message":"Unfortunately we didn\u0027t add a release note in the previous change but the argument was \"deprecated\" at that time. (We have a warning message in L189).\n\nIf that is not the correct deprecation then I can deprecate the parameter officially.","commit_id":"7df64737c23f7e88cb4d8abe29245603864ed4f9"}],"oslo_utils/tests/test_reflection.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"13c081daa513aca6029696c2ec1925e71bd21804","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                            strict\u003dFalse))"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            self.assertFalse(reflection.is_same_callback(b.b, c.b,"},{"line_number":162,"context_line":"                             strict\u003dFalse))"},{"line_number":163,"context_line":"            self.assertTrue(reflection.is_same_callback(b.b, b.b))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6e28d63a_a488c3a8","side":"PARENT","line":162,"range":{"start_line":162,"start_character":29,"end_line":162,"end_character":41},"updated":"2022-07-18 09:02:56.000000000","message":"Why removing this param?","commit_id":"7df64737c23f7e88cb4d8abe29245603864ed4f9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2c56606f9f2504f3f4dc9b51678b169e93dbdf8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                            strict\u003dFalse))"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            self.assertFalse(reflection.is_same_callback(b.b, c.b,"},{"line_number":162,"context_line":"                             strict\u003dFalse))"},{"line_number":163,"context_line":"            self.assertTrue(reflection.is_same_callback(b.b, b.b))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a91c7dd_d1e4cccd","side":"PARENT","line":162,"range":{"start_line":162,"start_character":29,"end_line":162,"end_character":41},"in_reply_to":"6e28d63a_a488c3a8","updated":"2022-07-18 13:23:32.000000000","message":"I\u0027ve removed this because it has no effect in Python 3.8+ but I noticed we should remove this argument to get rid of this in testing. I\u0027ve updated the change to remove the parameter.","commit_id":"7df64737c23f7e88cb4d8abe29245603864ed4f9"}]}