)]}'
{"id":"openstack%2Foslo.utils~924372","triplet_id":"openstack%2Foslo.utils~master~I7caa96feae5394781be48476ed88e0db2549f668","project":"openstack/oslo.utils","branch":"master","topic":"add-format-inspector","attention_set":{},"removed_from_attention_set":{"9303":{"account":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"last_update":"2024-08-01 14:38:54.000000000","reason":"\u003cGERRIT_ACCOUNT_9303\u003e replied on the change","reason_account":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2024-08-01 13:59:34.000000000","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change","reason_account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}},"4393":{"account":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"last_update":"2024-08-07 10:33:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7caa96feae5394781be48476ed88e0db2549f668","subject":"Add region-complete signaling for inspectors","status":"MERGED","created":"2024-07-17 21:32:09.000000000","updated":"2024-08-07 10:34:33.000000000","submitted":"2024-08-07 10:33:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"924372-add-format-inspector","meta_rev_id":"05498b8a66f6515c916dc9fb7c7e36cf74b90d23","_number":924372,"virtual_id_number":924372,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-08-07 10:33:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2024-08-01 14:21:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2024-08-01 13:59:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2024-08-07 08:51:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":1,"date":"2024-08-07 08:51:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-17 23:08:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-23 14:50:58.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2024-08-01 14:21:55.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2024-08-07 08:51:38.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"}],"messages":[{"id":"eaca8acb591bf3e087877e8b1e49ec458b0eac0b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-17 21:32:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"16827559593bc5f196200063666600d985f1dbb1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-17 23:08:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5a181be9c57043458ef6a0562c6673d5\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4100fa9f7e674215b61072e90153c663 : SUCCESS in 1h 34m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/24d5a7aa25274e44b5d672849ffc41f9 : SUCCESS in 3m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a6702f2dbdcf4ab8b8d384a32628fd0f : SUCCESS in 5m 39s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/eef33af119e549759d3cb5831c8caa39 : SUCCESS in 4m 48s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/68038474b1324a9aa541f189c93830fc : SUCCESS in 7m 14s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8dde6854d33a445a93568c1549048dc8 : SUCCESS in 3m 34s","accounts_in_message":[],"_revision_number":1},{"id":"3cfc9c667c05f0d49d39270c2882ed8a17a6a355","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-22 18:13:34.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"6eb9f3cc8dbc9350e8334dee37a29189759f8c1f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-22 19:27:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bc60fad8551d41478e3bdfaee0dd5a8d\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d34448b3cadd484081fb7930305c8e98 : SUCCESS in 1h 12m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b5eeef94eeea45a9a64957b13d8e5476 : SUCCESS in 3m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ec01db4acdaa457b89458b073ab6adb4 : SUCCESS in 4m 47s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/94a91e361cd345858907d24430d0daec : SUCCESS in 4m 48s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b2219f520c994a52892658dc6f54e0c4 : SUCCESS in 9m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0e0ba42c89224acfab88a70ae9c82e16 : SUCCESS in 3m 10s","accounts_in_message":[],"_revision_number":2},{"id":"d715b66dcd08b40e195e9dac7e230608871f822b","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-07-23 14:50:58.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d88cc12acf6ab43813234e56e863d4ba43796484","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-23 16:37:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2bb53d79131dad1001ea683c16b678e5c4f6e20f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-23 17:16:00.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"bfbe8a2879bb9bab83a8379f5fa9833631416f0b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-23 18:59:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ef223a017b0547f492e683ec13748039\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/dd3acb3b450142faa9e63c64eada41a2 : SUCCESS in 1h 37m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/61c2a759e8964f2e946ffecfd25a0433 : SUCCESS in 3m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/681639be2a184dee8b19531e9dd692bd : SUCCESS in 4m 08s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4b40e659ae174f4bb58dd1ce0c39efbf : SUCCESS in 4m 58s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/36f35482ed554b9f975a864cb8b7641d : SUCCESS in 7m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bc3044b69cd7464c84a4ef160eea2e26 : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":3},{"id":"195d0a48c9fb880211c4232144936cf753a58efa","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-07-29 14:30:00.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"6110264c50e845bcb155eb8dec0ee717ba25609f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-31 16:00:33.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":4},{"id":"c20e5ec95a51119b97e494473e290b37e9a5b8be","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-31 17:27:31.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/bc2bfd845801447899178c3e8d5edc79\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4a65d9510d2f4890bd1841614700536b : SUCCESS in 1h 24m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/611cf32b68524abdbc67951e94d10b94 : FAILURE in 6m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c0311464c1be4a559063505fe87ee66d : SUCCESS in 2m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/569024880b6649c9a4967f3c7ece7ce7 : FAILURE in 5m 12s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4e14f25b211f462cb9875cb61a345320 : FAILURE in 4m 13s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/6daa4fc74daa4846a714c4cad244a06b : FAILURE in 7m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/55d89a2be8b44c4388c04e25f874b5ad : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":4},{"id":"1abcacbb7fa4c22890bcd914fd5074bb6722d80d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-31 17:40:45.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified-1\n","accounts_in_message":[],"_revision_number":5},{"id":"7aa98903f3ef00da8a11a39efe48cf7e57dad40c","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-07-31 17:41:21.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"76bf3610e77c8d0d81336e259398a7dc877a3733","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-31 18:55:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a21a16cd95164829a7fb5892f064164e\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b9574b7013504223b19066ed2d64738d : SUCCESS in 1h 11m 30s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7507ddbda7814fce9a77cd02e9b16093 : SUCCESS in 6m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5f274721b06a4cf8acc3ba79f0287a0d : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3b77557ffe654d429733bc8523d5fd74 : SUCCESS in 4m 49s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c0117a5652a248ae8f049632a80bb81b : SUCCESS in 5m 07s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/72f188b4e89442688419376a7cd963bd : SUCCESS in 8m 52s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a53efb1edd74eab9d5c21e079fb14db : SUCCESS in 3m 40s","accounts_in_message":[],"_revision_number":5},{"id":"7f3600a9aabdfbefe328d0ebf6430b661fb5ed26","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-08-01 13:59:34.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"2d63f0fffec688d9fb9489ea77ff8165fc250535","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2024-08-01 14:21:55.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"5870efb4262cdac15bd0e34cf6944d01fe4fafac","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-08-01 14:25:10.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"c1f3ccf38c9af60fb6005a8b99fdde85b72a05a4","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2024-08-01 14:38:54.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"e1f5a9d59196ff04be6d9508ba9956ba5dd0a45a","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2024-08-07 08:51:38.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"69af09dfb691a372bd2bd791b76034f697fe7743","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 08:52:07.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"56984e6b5c018e8efb8597ca9773cec6fef05cf9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 10:33:33.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/07ecf8b993a049099d163aa0acb42e0f\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/46a8d60894384315b00ff097d9ae857d : SUCCESS in 1h 34m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba44690349ee4c249211e7d7c037379d : SUCCESS in 2m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5a4cd1f490554876bd703ce11c7b3380 : SUCCESS in 4m 46s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4d78c50fb15a450f9d33e052c05f61f1 : SUCCESS in 4m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45fdbc37a19c4228ade5a2b282203ae3 : SUCCESS in 3m 15s","accounts_in_message":[],"_revision_number":5},{"id":"7162e5e0d9dd487e8aff28d9a543de6c5338d69b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 10:33:33.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":5},{"id":"05498b8a66f6515c916dc9fb7c7e36cf74b90d23","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 10:34:33.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/332426d001c84148af85133ebc4c3ae0\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9ca10c725e464842987380aeb451407e : SUCCESS in 42s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b68be957cf82d96cccbbbfc49f4eae30c1470485","revisions":{"ddfd501e5f5b3ed65a650da70cab16618a66c98d":{"kind":"REWORK","_number":1,"created":"2024-07-17 21:32:09.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/72/924372/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/72/924372/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/1"}}},"commit":{"parents":[{"commit":"757962cfefa902c2184f3034ad3d6c3bbdcd8e6f","subject":"Reinstate VMDK safety check coverage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/757962cfefa902c2184f3034ad3d6c3bbdcd8e6f"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-17 19:34:56.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-17 21:31:47.000000000","tz":-420},"subject":"Add region-complete signaling for inspectors","message":"Add region-complete signaling for inspectors\n\nAs format_inspector has grown in utility, the redundancy of re-parsing\nthe region data each time has become excessive. We avoided refactoring\nthat infrastructure while addressing the CVE fix, but now is the time.\nThis adds a method that an inspector can implement to receive a\ncallback when a region becomes complete so it can parse it once. The\npost_process() callback is similar, but it is called once per chunk,\ninstead of once per region. Parsing the region once improves the\nperformance for multiple calls to get information and safety-check\nthe content.\n\nNOTE: This maybe fixes a VMDK parsing bug where if we get a mis-aligned\nchunk, we may fail to unpad it because the region doesn\u0027t end with\na pad character and thus rindex() does not find it. Since the\ndescriptor region is variable-length, this could happen and/or could\nbe an attack vector for fooling our matching. We actually have a test\nfor this already but this change tickled it to fail in a different way.\nThus the fixed code is still confirmed by the test. Additional tests\nare added for tightened checks.\n\nChange-Id: I7caa96feae5394781be48476ed88e0db2549f668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/ddfd501e5f5b3ed65a650da70cab16618a66c98d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/ddfd501e5f5b3ed65a650da70cab16618a66c98d"}]},"branch":"refs/heads/master"},"8a0156e43d6ae71953eb7e4f25fe246146489270":{"kind":"REWORK","_number":2,"created":"2024-07-22 18:13:34.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/72/924372/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/72/924372/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/2"}}},"commit":{"parents":[{"commit":"5cbb6f6619ae1074a453647390dd90de1e8207e1","subject":"Reinstate VMDK safety check coverage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/5cbb6f6619ae1074a453647390dd90de1e8207e1"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-17 19:34:56.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-22 18:10:54.000000000","tz":-420},"subject":"Add region-complete signaling for inspectors","message":"Add region-complete signaling for inspectors\n\nAs format_inspector has grown in utility, the redundancy of re-parsing\nthe region data each time has become excessive. We avoided refactoring\nthat infrastructure while addressing the CVE fix, but now is the time.\nThis adds a method that an inspector can implement to receive a\ncallback when a region becomes complete so it can parse it once. The\npost_process() callback is similar, but it is called once per chunk,\ninstead of once per region. Parsing the region once improves the\nperformance for multiple calls to get information and safety-check\nthe content.\n\nNOTE: This maybe fixes a VMDK parsing bug where if we get a mis-aligned\nchunk, we may fail to unpad it because the region doesn\u0027t end with\na pad character and thus rindex() does not find it. Since the\ndescriptor region is variable-length, this could happen and/or could\nbe an attack vector for fooling our matching. We actually have a test\nfor this already but this change tickled it to fail in a different way.\nThus the fixed code is still confirmed by the test. Additional tests\nare added for tightened checks.\n\nChange-Id: I7caa96feae5394781be48476ed88e0db2549f668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/8a0156e43d6ae71953eb7e4f25fe246146489270"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/8a0156e43d6ae71953eb7e4f25fe246146489270"}]},"branch":"refs/heads/master"},"6aac7d50babdfc35bf4199709312e7b96fa277ea":{"kind":"REWORK","_number":3,"created":"2024-07-23 17:16:00.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/72/924372/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/72/924372/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/3"}}},"commit":{"parents":[{"commit":"3e31923d07f265ef067a2618962efff15e665e59","subject":"Reinstate VMDK safety check coverage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/3e31923d07f265ef067a2618962efff15e665e59"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-17 19:34:56.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-23 17:03:33.000000000","tz":-420},"subject":"Add region-complete signaling for inspectors","message":"Add region-complete signaling for inspectors\n\nAs format_inspector has grown in utility, the redundancy of re-parsing\nthe region data each time has become excessive. We avoided refactoring\nthat infrastructure while addressing the CVE fix, but now is the time.\nThis adds a method that an inspector can implement to receive a\ncallback when a region becomes complete so it can parse it once. The\npost_process() callback is similar, but it is called once per chunk,\ninstead of once per region. Parsing the region once improves the\nperformance for multiple calls to get information and safety-check\nthe content.\n\nNOTE: This maybe fixes a VMDK parsing bug where if we get a mis-aligned\nchunk, we may fail to unpad it because the region doesn\u0027t end with\na pad character and thus rindex() does not find it. Since the\ndescriptor region is variable-length, this could happen and/or could\nbe an attack vector for fooling our matching. We actually have a test\nfor this already but this change tickled it to fail in a different way.\nThus the fixed code is still confirmed by the test. Additional tests\nare added for tightened checks.\n\nChange-Id: I7caa96feae5394781be48476ed88e0db2549f668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/6aac7d50babdfc35bf4199709312e7b96fa277ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/6aac7d50babdfc35bf4199709312e7b96fa277ea"}]},"branch":"refs/heads/master"},"f38929786a57302719947915935e3430162c5f0e":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2024-07-31 16:00:33.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/72/924372/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/72/924372/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/4"}}},"commit":{"parents":[{"commit":"e1f58f49982385a63db6f3ca5549439b902fee7d","subject":"Reinstate VMDK safety check coverage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/e1f58f49982385a63db6f3ca5549439b902fee7d"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-17 19:34:56.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-31 15:52:55.000000000","tz":-420},"subject":"Add region-complete signaling for inspectors","message":"Add region-complete signaling for inspectors\n\nAs format_inspector has grown in utility, the redundancy of re-parsing\nthe region data each time has become excessive. We avoided refactoring\nthat infrastructure while addressing the CVE fix, but now is the time.\nThis adds a method that an inspector can implement to receive a\ncallback when a region becomes complete so it can parse it once. The\npost_process() callback is similar, but it is called once per chunk,\ninstead of once per region. Parsing the region once improves the\nperformance for multiple calls to get information and safety-check\nthe content.\n\nNOTE: This maybe fixes a VMDK parsing bug where if we get a mis-aligned\nchunk, we may fail to unpad it because the region doesn\u0027t end with\na pad character and thus rindex() does not find it. Since the\ndescriptor region is variable-length, this could happen and/or could\nbe an attack vector for fooling our matching. We actually have a test\nfor this already but this change tickled it to fail in a different way.\nThus the fixed code is still confirmed by the test. Additional tests\nare added for tightened checks.\n\nChange-Id: I7caa96feae5394781be48476ed88e0db2549f668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/f38929786a57302719947915935e3430162c5f0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/f38929786a57302719947915935e3430162c5f0e"}]},"branch":"refs/heads/master"},"b68be957cf82d96cccbbbfc49f4eae30c1470485":{"kind":"REWORK","_number":5,"created":"2024-07-31 17:40:45.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/72/924372/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.utils","ref":"refs/changes/72/924372/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.utils refs/changes/72/924372/5"}}},"commit":{"parents":[{"commit":"e1f58f49982385a63db6f3ca5549439b902fee7d","subject":"Reinstate VMDK safety check coverage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/e1f58f49982385a63db6f3ca5549439b902fee7d"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-17 19:34:56.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-07-31 17:40:35.000000000","tz":-420},"subject":"Add region-complete signaling for inspectors","message":"Add region-complete signaling for inspectors\n\nAs format_inspector has grown in utility, the redundancy of re-parsing\nthe region data each time has become excessive. We avoided refactoring\nthat infrastructure while addressing the CVE fix, but now is the time.\nThis adds a method that an inspector can implement to receive a\ncallback when a region becomes complete so it can parse it once. The\npost_process() callback is similar, but it is called once per chunk,\ninstead of once per region. Parsing the region once improves the\nperformance for multiple calls to get information and safety-check\nthe content.\n\nNOTE: This maybe fixes a VMDK parsing bug where if we get a mis-aligned\nchunk, we may fail to unpad it because the region doesn\u0027t end with\na pad character and thus rindex() does not find it. Since the\ndescriptor region is variable-length, this could happen and/or could\nbe an attack vector for fooling our matching. We actually have a test\nfor this already but this change tickled it to fail in a different way.\nThus the fixed code is still confirmed by the test. Additional tests\nare added for tightened checks.\n\nChange-Id: I7caa96feae5394781be48476ed88e0db2549f668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/b68be957cf82d96cccbbbfc49f4eae30c1470485"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.utils/commit/b68be957cf82d96cccbbbfc49f4eae30c1470485"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}