)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"7beced406324816e65dc43f0098244b65bce6533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c72277d_f6c3638e","updated":"2024-08-27 15:35:04.000000000","message":"FTR, it\u0027s needed since the import of format_inspector from Nova and Cinder [1]\n\n[1] https://review.opendev.org/c/openstack/oslo.utils/+/924347","commit_id":"eb785296a0ee5d40773f3719b04593ba4f28c936"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a77a0ad6c5969318ee978891f2d70747bee0e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86a9c813_5efaa7c1","updated":"2024-08-27 20:00:04.000000000","message":"minor nit but this will work so +1","commit_id":"eb785296a0ee5d40773f3719b04593ba4f28c936"}],"bindep.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a77a0ad6c5969318ee978891f2d70747bee0e32","unresolved":true,"context_lines":[{"line_number":6,"context_line":"python3-dev [platform:dpkg]"},{"line_number":7,"context_line":"python3-devel [platform:rpm]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"qemu-img [platform:redhat]"},{"line_number":10,"context_line":"qemu-tools [platform:suse]"},{"line_number":11,"context_line":"qemu-utils [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":1,"id":"866fc007_1c160e93","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":26},"updated":"2024-08-27 20:00:04.000000000","message":"so technially thesse are test only deps so they shoudl have the test profile in the bindep declaration liek this\n\nhttps://github.com/openstack/nova/blob/master/bindep.txt#L4\n\noslo is not really following that convention but any tep that is not a runtime dep is ment ot have test if its only for test code.\n\nthere are other profiles like pdf-docs\n\nwe had previosuly talks about also have one profile per \"extra\" in setup.cfg\n\nhttps://github.com/openstack/nova/blob/master/setup.cfg#L30-L36\nbut that never really went anywhere to thet only stanbdard targets im aware of are\n\n`test`, `doc` and `pdf-doc`.","commit_id":"eb785296a0ee5d40773f3719b04593ba4f28c936"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0831a7b3015497b7bfb69187c03eb04e2e6dbca","unresolved":true,"context_lines":[{"line_number":6,"context_line":"python3-dev [platform:dpkg]"},{"line_number":7,"context_line":"python3-devel [platform:rpm]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"qemu-img [platform:redhat]"},{"line_number":10,"context_line":"qemu-tools [platform:suse]"},{"line_number":11,"context_line":"qemu-utils [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":1,"id":"f32db268_ea3f622f","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":26},"in_reply_to":"866fc007_1c160e93","updated":"2024-09-13 13:07:54.000000000","message":"Let\u0027s add the test profile to clearly declare that this is not a runtime dependency. oslo.utils is used by multiple projects and I\u0027m concerned with pulling unnecessary dependencies because of this.","commit_id":"eb785296a0ee5d40773f3719b04593ba4f28c936"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c0caad224a5efd11a5b449cf0b453bcf1a5ce9a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"python3-dev [platform:dpkg]"},{"line_number":7,"context_line":"python3-devel [platform:rpm]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"qemu-img [platform:redhat]"},{"line_number":10,"context_line":"qemu-tools [platform:suse]"},{"line_number":11,"context_line":"qemu-utils [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":1,"id":"19ce5e41_0e215866","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":26},"in_reply_to":"f32db268_ea3f622f","updated":"2024-09-13 13:08:33.000000000","message":"Done","commit_id":"eb785296a0ee5d40773f3719b04593ba4f28c936"}]}
