)]}'
{"oslo_utils/netutils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c8914b8378f972fd3dcac1e47feeb84332edc5a","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        else:"},{"line_number":429,"context_line":"            LOG.info(\u0027Could not determine default network interface, \u0027"},{"line_number":430,"context_line":"                     \u0027using %s for IPv4 address\u0027, LOCALHOST)"},{"line_number":431,"context_line":"            return LOCALHOST"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    try:"},{"line_number":434,"context_line":"        addrs \u003d psutil.net_if_addrs()[interface]"}],"source_content_type":"text/x-python","patch_set":2,"id":"12caa753_d6b8fdf6","line":431,"updated":"2024-10-14 16:42:06.000000000","message":"This will only work on Linux (and potentially MacOS?). Do we need to be concerned with Windows support?","commit_id":"2ec1ce3661099eb73134d36eb8a4437938b304e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2ba8f7dcd98f2620d8c6cbbebef7770e3d08175","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        else:"},{"line_number":429,"context_line":"            LOG.info(\u0027Could not determine default network interface, \u0027"},{"line_number":430,"context_line":"                     \u0027using %s for IPv4 address\u0027, LOCALHOST)"},{"line_number":431,"context_line":"            return LOCALHOST"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    try:"},{"line_number":434,"context_line":"        addrs \u003d psutil.net_if_addrs()[interface]"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3e57e23_0014c673","line":431,"in_reply_to":"12caa753_d6b8fdf6","updated":"2024-10-14 21:23:32.000000000","message":"According to code search these two functions are used by only server side code (I see one usage in zaqar but that\u0027s in functional tests). Because we are removing Windows support from services now, I think we don\u0027t have to keep these methods compatible with Windows.","commit_id":"2ec1ce3661099eb73134d36eb8a4437938b304e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1ca2a99486660cd3c024e5529a5c1e44189536af","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        else:"},{"line_number":429,"context_line":"            LOG.info(\u0027Could not determine default network interface, \u0027"},{"line_number":430,"context_line":"                     \u0027using %s for IPv4 address\u0027, LOCALHOST)"},{"line_number":431,"context_line":"            return LOCALHOST"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    try:"},{"line_number":434,"context_line":"        addrs \u003d psutil.net_if_addrs()[interface]"}],"source_content_type":"text/x-python","patch_set":2,"id":"a40afab5_60010cfe","line":431,"in_reply_to":"a3e57e23_0014c673","updated":"2024-10-15 14:14:42.000000000","message":"So I spent some time looking for alternatives and got the thoughts below.\n\n* netifaces-plus: https://github.com/tsukumijima/netifaces-plus\n * this looks like a direct fork\n* netifaces2: https://github.com/SamuelYvon/netifaces-2\n * this does not support Windows. Also it conflicts with nerifaces so can\u0027t be used really\n* scapy: https://pypi.org/project/scapy/\n * This is cross-platform but has too many features. Installing it shows approximately 200 MB which is much bigger than netifaces (~2MB)\n\nSo I\u0027m inclined to continue with the current direction and breaks compatibility of netutils with Windows .... This does not kill the existing usage and I doubt anyone may use this library in windows .","commit_id":"2ec1ce3661099eb73134d36eb8a4437938b304e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3e083e724d6cfbcff2d123857221020ec7080270","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        else:"},{"line_number":429,"context_line":"            LOG.info(\u0027Could not determine default network interface, \u0027"},{"line_number":430,"context_line":"                     \u0027using %s for IPv4 address\u0027, LOCALHOST)"},{"line_number":431,"context_line":"            return LOCALHOST"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    try:"},{"line_number":434,"context_line":"        addrs \u003d psutil.net_if_addrs()[interface]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0ca0eb_ef0a3e39","line":431,"in_reply_to":"a40afab5_60010cfe","updated":"2024-10-26 16:51:59.000000000","message":"Also note that a few existing interfaces like is_ipv6_enabled is not compatible with Windows. So at this moment this module is not really compatible with Windows and given the fact that this is not used actually in our code potentially run in Windows, I think we don\u0027t have to care about Windows for this specific method.","commit_id":"2ec1ce3661099eb73134d36eb8a4437938b304e9"}]}
