)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3af8c7a6cabae42deeaf50214b3459edf0cedbb3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow running the inspection as a script:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    python -m oslo_utils.imageutils.format_inspection \u003cpath\u003e [\u003cpath\u003e ...]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1eb4d907ff80ee3110ffaa560ae18bfd866e55ab"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a79f1d99_8d7d2d15","line":11,"updated":"2024-12-04 16:03:41.000000000","message":"i think that is a useful capablity but i would implement this differntly using __main__.py instead of inline\n\nhttps://docs.python.org/3/library/__main__.html#main-py-in-python-packages\n\nthat will allow use to seperate the cli interface form the lib code more cleanly then mixing both in the same file.","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d5bff451dfa946d94d21d1b895443c447f2abf55","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow running the inspection as a script:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    python -m oslo_utils.imageutils.format_inspection \u003cpath\u003e [\u003cpath\u003e ...]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1eb4d907ff80ee3110ffaa560ae18bfd866e55ab"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"34c7ff7c_7abcdc1f","line":11,"in_reply_to":"a79f1d99_8d7d2d15","updated":"2024-12-04 18:09:06.000000000","message":"As discussed on IRC, this would necessitate using the parent module path (i.e. so we\u0027d lose context from the \"executable\" name","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"314790dc1e78a773328686fe69501607bab67a32","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow running the inspection as a script:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    python -m oslo_utils.imageutils.format_inspection \u003cpath\u003e [\u003cpath\u003e ...]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1eb4d907ff80ee3110ffaa560ae18bfd866e55ab"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc905443_94e3f02a","line":11,"in_reply_to":"a79f1d99_8d7d2d15","updated":"2024-12-04 18:11:41.000000000","message":"we discussed this on irc and it woudl change the invocation form \n\n\n`python -m oslo_utils.imageutils.format_inspection`\n\nto\n`python -m oslo_utils.imageutils`\n\nand i agree with stephen that the former is clearer.","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"314790dc1e78a773328686fe69501607bab67a32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"501d68f7_2c8253f0","updated":"2024-12-04 18:11:41.000000000","message":"+1 for the direction.\nim still not sure how i feel about testing this.\n\nit kind of hard to mock argparser such that you can proply emulate invokign main with commandline arguments\n\nso im not sure we have a clean way to unit test this.","commit_id":"3322150bceb274c79ceab96dc0cd5020785d9680"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"63852e869d754d136c02e768fbbb67e33e91b905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e6d803e5_951a4ac1","updated":"2025-02-05 17:37:42.000000000","message":"Could be worth to add a release note","commit_id":"7013cebdeec06925dcff1a2548d631fd7eaba107"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3aeddb7d13a4f1bee5638e94935abe50fca468a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6935e9c_e15d6c5e","updated":"2025-02-05 17:39:42.000000000","message":"Duplicated with https://review.opendev.org/c/openstack/oslo.utils/+/930379","commit_id":"7013cebdeec06925dcff1a2548d631fd7eaba107"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c5f5ac103e1b5062d036835fef404a6b3ca6391f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"002beb24_8136d9ad","updated":"2024-12-12 22:02:34.000000000","message":"This is a duplicate of the version I arleady wrote a while back that\u0027s never been merged: https://review.opendev.org/c/openstack/oslo.utils/+/930379\n\nOnly one should be merged. I think it\u0027s clear the one I prefer :P","commit_id":"7013cebdeec06925dcff1a2548d631fd7eaba107"}],"oslo_utils/imageutils/format_inspector.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3af8c7a6cabae42deeaf50214b3459edf0cedbb3","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"        return matches"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"    @property"},{"line_number":1440,"context_line":"    def format(self) -\u003e ty.Optional[FileInspector]:"},{"line_number":1441,"context_line":"        \"\"\"The format determined from the content."},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"        If this is None, a decision has not been reached. Otherwise,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2823611_a92f41fd","line":1440,"updated":"2024-12-04 16:03:41.000000000","message":"this module is not currently using type hits so this is kind an unrelated change and likely shoudl be done seperatly.","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a94dfec1be8bd6eb8ec0f41cb3e4ebdb78abe056","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"        return matches"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"    @property"},{"line_number":1440,"context_line":"    def format(self) -\u003e ty.Optional[FileInspector]:"},{"line_number":1441,"context_line":"        \"\"\"The format determined from the content."},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"        If this is None, a decision has not been reached. Otherwise,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6cd0806f_f97e80ec","line":1440,"in_reply_to":"d2823611_a92f41fd","updated":"2024-12-04 18:07:54.000000000","message":"It was related since I had to figure out what the return type of that method was in order to write this patch. Once I had it figured out, it made sense to me to add documentation (i.e. the hint) for the reviewers. I don\u0027t want to hold this up though so 🤷","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3af8c7a6cabae42deeaf50214b3459edf0cedbb3","unresolved":true,"context_lines":[{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":""},{"line_number":1516,"context_line":"def __main__():"},{"line_number":1517,"context_line":"    import argparse"},{"line_number":1518,"context_line":"    import sys"},{"line_number":1519,"context_line":""},{"line_number":1520,"context_line":"    parser \u003d argparse.ArgumentParser("}],"source_content_type":"text/x-python","patch_set":2,"id":"0783db93_3fb6e169","line":1517,"updated":"2024-12-04 16:03:41.000000000","message":"by taking the __main__.py  appcoh we can avoid needing to nest these import within the main funciton","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"314790dc1e78a773328686fe69501607bab67a32","unresolved":false,"context_lines":[{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":""},{"line_number":1516,"context_line":"def __main__():"},{"line_number":1517,"context_line":"    import argparse"},{"line_number":1518,"context_line":"    import sys"},{"line_number":1519,"context_line":""},{"line_number":1520,"context_line":"    parser \u003d argparse.ArgumentParser("}],"source_content_type":"text/x-python","patch_set":2,"id":"afe9bf6d_5b255c7d","line":1517,"in_reply_to":"0783db93_3fb6e169","updated":"2024-12-04 18:11:41.000000000","message":"Acknowledged","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d5bff451dfa946d94d21d1b895443c447f2abf55","unresolved":false,"context_lines":[{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":""},{"line_number":1516,"context_line":"def __main__():"},{"line_number":1517,"context_line":"    import argparse"},{"line_number":1518,"context_line":"    import sys"},{"line_number":1519,"context_line":""},{"line_number":1520,"context_line":"    parser \u003d argparse.ArgumentParser("}],"source_content_type":"text/x-python","patch_set":2,"id":"70c082e6_52b6b4a1","line":1517,"in_reply_to":"0783db93_3fb6e169","updated":"2024-12-04 18:09:06.000000000","message":"Discussed elsewhere.","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3af8c7a6cabae42deeaf50214b3459edf0cedbb3","unresolved":true,"context_lines":[{"line_number":1559,"context_line":"        sys.exit(1)"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":1563,"context_line":"    __main__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"429fa633_874925ba","line":1562,"updated":"2024-12-04 16:03:41.000000000","message":"and evaluating this conditional explicitly on import although i don\u0027t think that would have much overhead.","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"314790dc1e78a773328686fe69501607bab67a32","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"        sys.exit(1)"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":1563,"context_line":"    __main__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fccde21b_9efc34dc","line":1562,"in_reply_to":"429fa633_874925ba","updated":"2024-12-04 18:11:41.000000000","message":"Acknowledged","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d5bff451dfa946d94d21d1b895443c447f2abf55","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"        sys.exit(1)"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":1563,"context_line":"    __main__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3670ed52_1388a7f0","line":1562,"in_reply_to":"429fa633_874925ba","updated":"2024-12-04 18:09:06.000000000","message":"Discussed elsewhere.","commit_id":"82e3c88b65df237d45a16a65209fddf131be00d7"}]}