)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"41a95d3cfeddb9a38a8bdd8572a50ba3d73b6e52","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6847a35_a46c57ad","updated":"2025-09-11 13:30:29.000000000","message":"oslo.utils is the core library and making it dependent on oslo.log may cause circular dependencies between these. IMO this should be implemented in upper layer, with clear choice by developers.","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a4b1ffceb631ee601866f4d6c3cfc419bd120c7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9722357_5a0c36b5","in_reply_to":"33f6d5b2_db8fe5bb","updated":"2025-09-11 13:54:12.000000000","message":"I agree with your points. Your concerning are legit.\nThat would be awesome if we are able to find an alternative.\n\nMoving this solution at the services level seems too much invasive to me, as it will require tons of updates here and there.\n\nAt the oslo.log level it is too late to uncypher something.\n\nConcerning the security aspect of this patch, as you said on IRC showing password on debug log is already considered as a minor security problem, but the same will be true if this solution is implemented at the service level.\n\nConcerning the low level nature of oslo.utils I totally agree with that. The introduction of oslo.config here broke that design.","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7cd595630d72430e0c382288ba0beeb41b092dd3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33f6d5b2_db8fe5bb","in_reply_to":"54403fd4_0d257ac4","updated":"2025-09-11 13:41:32.000000000","message":"Sorry I meant oslo.config . So rechecking the current deps oslo.config does not depend on oslo.utils so there may be no circular dependency immediately caused. However oslo.utils is supposed to be the most lower library, and I can imagine the case we may want to use it from oslo.config , so I\u0027d vote my huge -1 to adding oslo.utils -\u003e oslo.config dependency.\n\nAlso IMO it\u0027s not a good design to void the whole mask function by a knob. If someone wants to implement this feature then it should be explicitly implemented in their service, by selecting whether they should call the mask function.","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"560faca3c141b17d88d842d458fd4cd1b7ab37ca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54403fd4_0d257ac4","in_reply_to":"e6847a35_a46c57ad","updated":"2025-09-11 13:38:17.000000000","message":"There is no dependency on oslo.log or I misunderstand you.\nThis feature is purely standalone in oslo.utils.\nMaybe you wanted to say oslo.config?","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"16ea35771db7c39a61c6aa8b1905afe036019326","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0b15adf_53ee0780","in_reply_to":"e6847a35_a46c57ad","updated":"2025-09-11 13:35:54.000000000","message":"This comment still stands.","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0349006a7b62d85d943ea0db42da56b2cd76f28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc6a0781_70363ee5","in_reply_to":"e9722357_5a0c36b5","updated":"2025-09-11 14:14:59.000000000","message":"\u003e That would be awesome if we are able to find an alternative.\n\nBecause the mask function should be explicitly called, I\u0027d say that the option should be implemented within the upper layer where it is called. It may cause an option added to multiple places, but allow more close review about the tradeoff (between debuggability and security) based on the actual content being exposed.","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"5e516c7feb62119701db54f269881299579362a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cffeda8f_dbe50ec8","in_reply_to":"fc6a0781_70363ee5","updated":"2025-09-12 07:21:49.000000000","message":"Implemented at the service level?","commit_id":"fbf09929ef97922fd8394ce392caf225dea73234"},{"author":{"_account_id":16339,"name":"Cyril Lopez","email":"cylopez@redhat.com","username":"cylopez"},"change_message_id":"e00a091bd98f01212ca543f7b0c6bf175521afe1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"016fb46b_a5d1818b","updated":"2025-09-11 13:58:47.000000000","message":"verify interesting feature !","commit_id":"e88626beb82b46c4fceacbede57114715c1ba351"}]}