)]}'
{"id":"openstack%2Foslo.versionedobjects~1003516","triplet_id":"openstack%2Foslo.versionedobjects~master~Iec1341ecd48f0de96a19cb460c73e092729acffe","project":"openstack/oslo.versionedobjects","branch":"master","topic":"annotation-style-ovos","attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2026-09-02 13:22:08.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Iec1341ecd48f0de96a19cb460c73e092729acffe","subject":"Add support for PEP 563 forward references","status":"NEW","created":"2026-09-02 11:45:31.000000000","updated":"2026-09-02 13:22:08.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"24fe8164d43c1eb7c6b7df8c008ba969f48845f1","_number":1003516,"virtual_id_number":1003516,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-09-02 13:22:08.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-02 13:22:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"39c2f6e38292f61936daf498153dbdac60c82276","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-09-02 11:45:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f933833f26bd875d08c5e2ebeb04f9bf7a6e22e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-09-02 11:53:07.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"24fe8164d43c1eb7c6b7df8c008ba969f48845f1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-02 13:22:08.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/13a7846565134d9ea31e47630d80eaad\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/896b6e385a7048a295b7eee13aaf9bad : SUCCESS in 1h 26m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c32af125e5d491b9cee47de1431e1c6 : FAILURE in 4m 47s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4651bc2fb23d4af883139b346fe72900 : FAILURE in 3m 22s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/edf2d347fd5c47228b3c0e17dd0e429f : FAILURE in 5m 42s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/75ca89f09a954f72bc7341a846edae10 : FAILURE in 8m 15s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/4da2aed8315a4e0bb5dc43981df51aa0 : FAILURE in 4m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ccda61322a2e42c5a6ecfcbfc81a81c2 : SUCCESS in 4m 24s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2c7c08d8883d4a7c89b560a78a86dbb1 : SUCCESS in 5m 36s\n- oslo.versionedobjects-src-grenade-multinode https://zuul.opendev.org/t/openstack/build/8a1dceaa1db24bf9aa269ebf9c4bd812 : SUCCESS in 1h 16m 04s (non-voting)\n- oslo.versionedobjects-nova-tox-py313 https://zuul.opendev.org/t/openstack/build/9edd08f4630e477cb692638b842af778 : SUCCESS in 13m 50s\n- oslo.versionedobjects-ironic-tox-py313 https://zuul.opendev.org/t/openstack/build/87f0d9df48d04db2a609e22ff06479bb : SUCCESS in 6m 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2b98b117b9be203ab1bb1b91009532e7d2872713","revisions":{"f172bd526fbde81a16971771787799477ba50cf8":{"kind":"REWORK","_number":1,"created":"2026-09-02 11:45:31.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/16/1003516/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.versionedobjects","ref":"refs/changes/16/1003516/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/1"}}},"commit":{"parents":[{"commit":"f5c31c8063425c9b51382d4bbff1b4a4b1fd9088","subject":"Extend dataclass style o.vos with remaining types","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/f5c31c8063425c9b51382d4bbff1b4a4b1fd9088"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-08-14 22:32:40.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-09-02 11:45:13.000000000","tz":60},"subject":"Add support for PEP 563 forward references","message":"Add support for PEP 563 forward references\n\nWhen a module uses \u0027from __future__ import annotations\u0027 and an\nannotation references a class not yet defined, typing.get_type_hints()\nand eval() both fail. The fallback path previously passed the raw\nannotation string (e.g. \u0027Child | None\u0027) through to _hint_to_field, which\ntreated it as a forward reference to an object named \u0027Child | None\u0027 —\nlosing both the nullable flag and the correct object name. The same bug\naffected container patterns like \u0027list[Child]\u0027.\n\nAdd _resolve_string_hint() to parse unresolvable string annotations:\nsplit on \u0027 | \u0027 to detect nullable unions, and recognise list[X]/set[X]\ncontainer patterns. Multi-type unions like \u0027A | None | B\u0027 are rejected\nwith a clear TypeError.\n\nChange-Id: Iec1341ecd48f0de96a19cb460c73e092729acffe\nAssisted-By: Claude Opus 4.6 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/f172bd526fbde81a16971771787799477ba50cf8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/f172bd526fbde81a16971771787799477ba50cf8"}]},"branch":"refs/heads/master"},"2b98b117b9be203ab1bb1b91009532e7d2872713":{"kind":"NO_CHANGE","_number":2,"created":"2026-09-02 11:53:07.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/16/1003516/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.versionedobjects","ref":"refs/changes/16/1003516/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/16/1003516/2"}}},"commit":{"parents":[{"commit":"513e48847e9936844a3a0674684bcb625fe2f851","subject":"Extend dataclass style o.vos with remaining types","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/513e48847e9936844a3a0674684bcb625fe2f851"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-08-14 22:32:40.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-09-02 11:52:59.000000000","tz":60},"subject":"Add support for PEP 563 forward references","message":"Add support for PEP 563 forward references\n\nWhen a module uses \u0027from __future__ import annotations\u0027 and an\nannotation references a class not yet defined, typing.get_type_hints()\nand eval() both fail. The fallback path previously passed the raw\nannotation string (e.g. \u0027Child | None\u0027) through to _hint_to_field, which\ntreated it as a forward reference to an object named \u0027Child | None\u0027 —\nlosing both the nullable flag and the correct object name. The same bug\naffected container patterns like \u0027list[Child]\u0027.\n\nAdd _resolve_string_hint() to parse unresolvable string annotations:\nsplit on \u0027 | \u0027 to detect nullable unions, and recognise list[X]/set[X]\ncontainer patterns. Multi-type unions like \u0027A | None | B\u0027 are rejected\nwith a clear TypeError.\n\nChange-Id: Iec1341ecd48f0de96a19cb460c73e092729acffe\nAssisted-By: Claude Opus 4.6 \u003cnoreply@anthropic.com\u003e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/2b98b117b9be203ab1bb1b91009532e7d2872713"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/2b98b117b9be203ab1bb1b91009532e7d2872713"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}