)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96ce79e992231b64301191a40a04843ff6c630b5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This also fixes a bug in TestObjMakeList which was specifying incorrect"},{"line_number":19,"context_line":"obj_name for the elements in \u0027objects\u0027 collection of MyList test class."},{"line_number":20,"context_line":"It was not leading to failures as the items of this collection were not"},{"line_number":21,"context_line":"being corrced  prior to this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I004646ce643e7e51305cfb1cd4eb5e8647a83513"},{"line_number":24,"context_line":"Closes-Bug: #1466057"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_e63ffa84","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":13},"updated":"2015-06-18 16:55:33.000000000","message":"Should be \"coerced\"","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"3a18414030ebf9c6827e4cce43ad41d4879d7d33","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This also fixes a bug in TestObjMakeList which was specifying incorrect"},{"line_number":19,"context_line":"obj_name for the elements in \u0027objects\u0027 collection of MyList test class."},{"line_number":20,"context_line":"It was not leading to failures as the items of this collection were not"},{"line_number":21,"context_line":"being corrced  prior to this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I004646ce643e7e51305cfb1cd4eb5e8647a83513"},{"line_number":24,"context_line":"Closes-Bug: #1466057"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_8d7f2614","line":21,"in_reply_to":"fa32b979_e63ffa84","updated":"2015-06-18 18:10:16.000000000","message":"Done","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"}],"oslo_versionedobjects/fields.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96ce79e992231b64301191a40a04843ff6c630b5","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":351,"context_line":"        if not isinstance(value, list):"},{"line_number":352,"context_line":"            raise ValueError(_(\u0027A list is required in field %s\u0027) % attr)"},{"line_number":353,"context_line":"        return CoercedList(self._element_type, obj, attr, value)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def to_primitive(self, obj, attr, value):"},{"line_number":356,"context_line":"        return [self._element_type.to_primitive(obj, attr, x) for x in value]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_fa422d67","line":353,"range":{"start_line":353,"start_character":47,"end_line":353,"end_character":63},"updated":"2015-06-18 16:55:33.000000000","message":"Please pass these as kwargs, since they are.","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"3a18414030ebf9c6827e4cce43ad41d4879d7d33","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":351,"context_line":"        if not isinstance(value, list):"},{"line_number":352,"context_line":"            raise ValueError(_(\u0027A list is required in field %s\u0027) % attr)"},{"line_number":353,"context_line":"        return CoercedList(self._element_type, obj, attr, value)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def to_primitive(self, obj, attr, value):"},{"line_number":356,"context_line":"        return [self._element_type.to_primitive(obj, attr, x) for x in value]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_00fd1e6d","line":353,"in_reply_to":"fa32b979_fa422d67","updated":"2015-06-18 18:10:16.000000000","message":"Done","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96ce79e992231b64301191a40a04843ff6c630b5","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    List implementation which overrides all element-adding methods and"},{"line_number":644,"context_line":"    coercing the element(s) being added to the required element type"},{"line_number":645,"context_line":"    \"\"\""},{"line_number":646,"context_line":"    def __init__(self, element_type, obj\u003dNone, field\u003dNone, iterable\u003dNone):"},{"line_number":647,"context_line":"        self._element_type \u003d element_type"},{"line_number":648,"context_line":"        self._obj \u003d obj"},{"line_number":649,"context_line":"        self._field \u003d field"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_9a520134","line":646,"range":{"start_line":646,"start_character":37,"end_line":646,"end_character":72},"updated":"2015-06-18 16:55:33.000000000","message":"Are these really optional? At least the iterable looks like it must be provided (and iterable) else we\u0027ll fail below, right?","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e036ab51c67d25381811e489447e546d10ef0bad","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    List implementation which overrides all element-adding methods and"},{"line_number":644,"context_line":"    coercing the element(s) being added to the required element type"},{"line_number":645,"context_line":"    \"\"\""},{"line_number":646,"context_line":"    def __init__(self, element_type, obj\u003dNone, field\u003dNone, iterable\u003dNone):"},{"line_number":647,"context_line":"        self._element_type \u003d element_type"},{"line_number":648,"context_line":"        self._obj \u003d obj"},{"line_number":649,"context_line":"        self._field \u003d field"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_4d780cf9","line":646,"in_reply_to":"fa32b979_0dd6b627","updated":"2015-06-19 17:33:30.000000000","message":"It doesn\u0027t for me:\n\n \u003e\u003e\u003e list(None)\n Traceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e \n TypeError: \u0027NoneType\u0027 object is not iterable\n \u003e\u003e\u003e","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"64f6f47707da8902eef1e701a95b743b198a3714","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    List implementation which overrides all element-adding methods and"},{"line_number":644,"context_line":"    coercing the element(s) being added to the required element type"},{"line_number":645,"context_line":"    \"\"\""},{"line_number":646,"context_line":"    def __init__(self, element_type, obj\u003dNone, field\u003dNone, iterable\u003dNone):"},{"line_number":647,"context_line":"        self._element_type \u003d element_type"},{"line_number":648,"context_line":"        self._obj \u003d obj"},{"line_number":649,"context_line":"        self._field \u003d field"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_af197a24","line":646,"in_reply_to":"fa32b979_4d780cf9","updated":"2015-06-20 20:38:25.000000000","message":"Yes, you are right, I looked at the wrong place.\nThis is fixed in patchset #5","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"3a18414030ebf9c6827e4cce43ad41d4879d7d33","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    List implementation which overrides all element-adding methods and"},{"line_number":644,"context_line":"    coercing the element(s) being added to the required element type"},{"line_number":645,"context_line":"    \"\"\""},{"line_number":646,"context_line":"    def __init__(self, element_type, obj\u003dNone, field\u003dNone, iterable\u003dNone):"},{"line_number":647,"context_line":"        self._element_type \u003d element_type"},{"line_number":648,"context_line":"        self._obj \u003d obj"},{"line_number":649,"context_line":"        self._field \u003d field"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_0dd6b627","line":646,"in_reply_to":"fa32b979_9a520134","updated":"2015-06-18 18:10:16.000000000","message":"\u0027obj\u0027 and \u0027field\u0027 are passed to coerce of the actual field type and in all its present subclasses are used only for logging/exception messages, i.e. may be safely set to None.\n\nIterable may be None here, as a regular list accepts None in its __init__\nHowever, this codes needs to be fixed to properly handle None.","commit_id":"47f6f41a8fe6de78f5f05efce218b7f8475b820d"}]}
