)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"6dd63afeac4145d6f938605a460aa436e5fa74ef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"allow arbitrary subclasses - only the base class passes"},{"line_number":15,"context_line":"the check."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Introduce a new \u0027allow_subclasses\u0027 parameter, defaulting"},{"line_number":18,"context_line":"to False, which traverses the python class hierarchy,"},{"line_number":19,"context_line":"checking the obj_name() value on all parent classes"},{"line_number":20,"context_line":"of the value being coerced."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_01402433","line":17,"updated":"2015-06-23 13:57:21.000000000","message":"The parameter is called \"subclasses\" in latest patch set, so it\u0027s better to update its name here as well","commit_id":"7718b9db981ecaa6127cd62a12d4ac2e76a190a5"}],"oslo_versionedobjects/fields.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd377847256414bd957148870123574ef90c3b63","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"class Object(FieldType):"},{"line_number":469,"context_line":"    def __init__(self, obj_name, allow_subclasses\u003dFalse, **kwargs):"},{"line_number":470,"context_line":"        self._obj_name \u003d obj_name"},{"line_number":471,"context_line":"        self._allow_subclasses \u003d allow_subclasses"},{"line_number":472,"context_line":"        super(Object, self).__init__(**kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_8d193425","line":469,"updated":"2015-06-19 17:29:13.000000000","message":"I wonder if we should make this just \"subclasses\u003d\" so that it\u0027s shorter. Since these are specified inline in a field definition, longer things mean it\u0027s harder to organize.\n\n fields \u003d {\n     \u0027my_object\u0027: fields.ObjectField(\u0027MyLongSubclassName, allow_subclasses\u003dTrue),\n }","commit_id":"c3a0bc31638c28d981a1a998a41e03bcbdbd89b5"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e639533fb7354c46d033a20d55053fb7a1986949","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"class Object(FieldType):"},{"line_number":469,"context_line":"    def __init__(self, obj_name, allow_subclasses\u003dFalse, **kwargs):"},{"line_number":470,"context_line":"        self._obj_name \u003d obj_name"},{"line_number":471,"context_line":"        self._allow_subclasses \u003d allow_subclasses"},{"line_number":472,"context_line":"        super(Object, self).__init__(**kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_4b879412","line":469,"in_reply_to":"fa32b979_8d193425","updated":"2015-06-19 18:18:18.000000000","message":"Yep, the shorter name is fine with me.","commit_id":"c3a0bc31638c28d981a1a998a41e03bcbdbd89b5"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"46a9d893c42b0aa049f026a7c31a0c73d4f083fd","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            return []"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        obj_names \u003d [klass.obj_name()]"},{"line_number":480,"context_line":"        for parent in klass.__bases__:"},{"line_number":481,"context_line":"            obj_names.extend(Object._get_obj_names(parent))"},{"line_number":482,"context_line":"        return obj_names"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a0b8f211","line":480,"updated":"2015-06-21 10:28:18.000000000","message":"What about using klass.mro() instead? It will allow to avoid  magic attribute usage, and will be more consistent with the code already existing at base._make_class_properties","commit_id":"c3a0bc31638c28d981a1a998a41e03bcbdbd89b5"}],"oslo_versionedobjects/tests/test_fields.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6a868f8b077e7556e41ce9d9deff838edfd31dcf","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        self.assertEqual(\u0027TestableObject(fake-uuid)\u0027,"},{"line_number":478,"context_line":"                         self.field.stringify(obj))"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def test_inheritance(self):"},{"line_number":481,"context_line":"        # We need a whole lot of classes in a hierarchy to"},{"line_number":482,"context_line":"        # test subclass recognition for the Object field"},{"line_number":483,"context_line":"        class TestAnimal(obj_base.VersionedObject):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_9bde9c3c","line":480,"updated":"2015-06-24 20:10:00.000000000","message":"LOL at this whole method. :)","commit_id":"28e2b4f004138ef49d4e88c7adf484a1634ad328"}]}
