)]}'
{"oslo_versionedobjects/base.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c8552ccebe8288284e0521e9ef3b106cff2626c1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            except Exception:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    attr \u003d \"%s.%s\" % (self.obj_name(), name)"},{"line_number":86,"context_line":"                    LOG.exception(_LE(\u0027Error setting %(attr)s\u0027),"},{"line_number":87,"context_line":"                                  {\u0027attr\u0027: attr})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def deleter(self, name\u003dname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_584e9cc2","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":24},"updated":"2015-08-03 17:10:09.000000000","message":"Can you mock this to raise and make sure that we do the right thing? Just setting an integer value to a string should trigger us to get to this path, and then raise on the LOG making sure we get the ValueError from the setattr() call.","commit_id":"431fe0f47d19db0385fbd7dca7aea56e3912d874"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c8552ccebe8288284e0521e9ef3b106cff2626c1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            except Exception:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    attr \u003d \"%s.%s\" % (self.obj_name(), name)"},{"line_number":86,"context_line":"                    LOG.exception(_LE(\u0027Error setting %(attr)s\u0027),"},{"line_number":87,"context_line":"                                  {\u0027attr\u0027: attr})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def deleter(self, name\u003dname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b851e064","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":24},"updated":"2015-08-03 17:10:09.000000000","message":"Can you mock this to raise and make sure that we do the right thing? Just setting an integer value to a string should trigger us to get to this path, and then raise on the LOG making sure we get the ValueError from the setattr() call.","commit_id":"431fe0f47d19db0385fbd7dca7aea56e3912d874"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"e48bb119b4c2b79569613ce51737e729061ab7df","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            except Exception:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    attr \u003d \"%s.%s\" % (self.obj_name(), name)"},{"line_number":86,"context_line":"                    LOG.exception(_LE(\u0027Error setting %(attr)s\u0027),"},{"line_number":87,"context_line":"                                  {\u0027attr\u0027: attr})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def deleter(self, name\u003dname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_73485b5c","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":24},"in_reply_to":"1a4dcd0f_584e9cc2","updated":"2015-08-03 17:19:08.000000000","message":"I think, we don\u0027t need to test the save_and_reraise_exception function, because it\u0027s already tested in the oslo_utils library. But, I think, we should implement the unit tests for the oslo_versionedobjects or for the base module as well","commit_id":"431fe0f47d19db0385fbd7dca7aea56e3912d874"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"5a0807ceee3192d94f0c32168101a645b4c6e23a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            except Exception:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    attr \u003d \"%s.%s\" % (self.obj_name(), name)"},{"line_number":86,"context_line":"                    LOG.exception(_LE(\u0027Error setting %(attr)s\u0027),"},{"line_number":87,"context_line":"                                  {\u0027attr\u0027: attr})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def deleter(self, name\u003dname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_73e4db3a","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":24},"in_reply_to":"1a4dcd0f_73485b5c","updated":"2015-08-03 17:20:40.000000000","message":"I meant:the unit test for the  _make_class_properties function","commit_id":"431fe0f47d19db0385fbd7dca7aea56e3912d874"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9562a893ba45e790d0fcdb5637c515e0de229b3c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            except Exception:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    attr \u003d \"%s.%s\" % (self.obj_name(), name)"},{"line_number":86,"context_line":"                    LOG.exception(_LE(\u0027Error setting %(attr)s\u0027),"},{"line_number":87,"context_line":"                                  {\u0027attr\u0027: attr})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def deleter(self, name\u003dname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f3eb0baf","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":24},"in_reply_to":"1a4dcd0f_73e4db3a","updated":"2015-08-03 17:27:50.000000000","message":"yeah, no need to validate that the utility function works. But we should have a test that fails if we were to remove L84 in this file.","commit_id":"431fe0f47d19db0385fbd7dca7aea56e3912d874"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8fe60043e281e5fd82e256c436b2f9d3af0a91e4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            except Exception:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    attr \u003d \"%s.%s\" % (self.obj_name(), name)"},{"line_number":86,"context_line":"                    LOG.exception(_LE(\u0027Error setting %(attr)s\u0027),"},{"line_number":87,"context_line":"                                  {\u0027attr\u0027: attr})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def deleter(self, name\u003dname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8772377b","line":86,"in_reply_to":"1a4dcd0f_b851e064","updated":"2015-08-10 23:08:20.000000000","message":"@Dan. I scratched my head a bit. I don\u0027t really understand this code, so I may have interpreted your comment incorrectly. I don\u0027t see how setting an int value to a string will cause the setattr() call to raise an exception.\n\nThere aren\u0027t any explicit unit tests for _make_class_properties() (at least none that I could see), so I added a couple of tests in the next revision. Let me know if that\u0027s sort of what you were thinking of.","commit_id":"431fe0f47d19db0385fbd7dca7aea56e3912d874"}]}
