)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"18adfcd94dc73c54787454eef50f29161320016d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add validation on the target_version arg as following:"},{"line_number":10,"context_line":"1. When target_version \u003d\u003d object version don\u0027t call obj_make_compatible"},{"line_number":11,"context_line":"2. When target_version \u003e object version raise exception"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0f8dbe3cbdb86752f026f3692d4badc9f6e693c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_cf3a71cd","line":11,"updated":"2015-08-02 09:12:28.000000000","message":"For 1., it\u0027s probably the right thing to do. For 2., I am not so sure. Is it possible that consumers are interested in forward-porting, not just back-porting of objects? (F.e. if an object is sent from an old agent to server, and server wants to convert it to \u0027canonical\u0027 latest version before handling it?)","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f594e93215e449a5a7f7f5dc87d1ef4d0b66c40","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add validation on the target_version arg as following:"},{"line_number":10,"context_line":"1. When target_version \u003d\u003d object version don\u0027t call obj_make_compatible"},{"line_number":11,"context_line":"2. When target_version \u003e object version raise exception"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0f8dbe3cbdb86752f026f3692d4badc9f6e693c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_afb7e51f","line":11,"in_reply_to":"3a50d1a3_4f82e153","updated":"2015-08-02 09:37:12.000000000","message":"This is specific to how we implement and handle upgrades in neutron and other server projects. I am not sure we should enforce the model onto the library. But let\u0027s here from folks that maintain it. :)","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e1afcefa5f8d6085d335e6b53d231f33dda1d5fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add validation on the target_version arg as following:"},{"line_number":10,"context_line":"1. When target_version \u003d\u003d object version don\u0027t call obj_make_compatible"},{"line_number":11,"context_line":"2. When target_version \u003e object version raise exception"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0f8dbe3cbdb86752f026f3692d4badc9f6e693c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_78e4b83a","line":11,"in_reply_to":"3a50d1a3_afb7e51f","updated":"2015-08-03 16:57:49.000000000","message":"This is a local call, and thus a target newer than our own version makes no sense, as far as I can see. This would already be running on the indirection service, if so configured, which should be newest and is responsible for handling version conversions.","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"04ea7f8a0d0593a20c85dc5a42b81ac347949e64","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add validation on the target_version arg as following:"},{"line_number":10,"context_line":"1. When target_version \u003d\u003d object version don\u0027t call obj_make_compatible"},{"line_number":11,"context_line":"2. When target_version \u003e object version raise exception"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0f8dbe3cbdb86752f026f3692d4badc9f6e693c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_4f82e153","line":11,"in_reply_to":"3a50d1a3_cf3a71cd","updated":"2015-08-02 09:24:46.000000000","message":"I don\u0027t believe that this is the scenario because the check will be on the server side and the so it still target_version\u003c\u003d server object version. \n\nthis validation is more due to wrong usage like \nagent send new version object like version 1.7 and the server side try to call obj_to_primitive with version 1.7,  when it is only support object version 1.6.","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"}],"oslo_versionedobjects/exception.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"18adfcd94dc73c54787454eef50f29161320016d","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class InvalidTargetVersion(VersionedObjectsException):"},{"line_number":186,"context_line":"    msg_fmt \u003d _(\u0027invalid target version %(version)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_af2da590","line":186,"updated":"2015-08-02 09:12:28.000000000","message":"Should it start from upper-case \u0027I\u0027?","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"74032e263a68396bff45504be0b41505fba4f4f3","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class InvalidTargetVersion(VersionedObjectsException):"},{"line_number":186,"context_line":"    msg_fmt \u003d _(\u0027invalid target version %(version)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b337c3e2","line":186,"in_reply_to":"1a4dcd0f_5890dc95","updated":"2015-08-03 17:17:02.000000000","message":"Done","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e1afcefa5f8d6085d335e6b53d231f33dda1d5fb","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class InvalidTargetVersion(VersionedObjectsException):"},{"line_number":186,"context_line":"    msg_fmt \u003d _(\u0027invalid target version %(version)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_5890dc95","line":186,"in_reply_to":"3a50d1a3_af2da590","updated":"2015-08-03 16:57:49.000000000","message":"Yes :)","commit_id":"ec9320cd9d82696fa2f155e4c75b259332afeeea"}]}