)]}'
{"oslo_versionedobjects/base.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"1330f872eca95c1a3194ca7b38421b9117f84842","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                primitive[name] \u003d field.to_primitive(self, name,"},{"line_number":519,"context_line":"                                                     getattr(self, name))"},{"line_number":520,"context_line":"        if target_version !\u003d self.VERSION:"},{"line_number":521,"context_line":"            if version_manifest is None:"},{"line_number":522,"context_line":"                self.obj_make_compatible(primitive, target_version)"},{"line_number":523,"context_line":"            else:"},{"line_number":524,"context_line":"                self.obj_make_compatible_from_manifest(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_785961fc","line":521,"updated":"2015-08-26 15:12:32.000000000","message":"I think https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L410-L417 would cover us enough that we could just do self.obj_make_compatible_from_manifest() and just pass in version_manifest even if it was None right? I guess this way of doing things is safer. We pass in a None version_manifest here (https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L1075) and it looks to be working fine.","commit_id":"0e57a42726eae19e6b250ec5b052237398025be8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d62ea55e7d2b361e12aa627f9e5180c73ecd8e38","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                primitive[name] \u003d field.to_primitive(self, name,"},{"line_number":519,"context_line":"                                                     getattr(self, name))"},{"line_number":520,"context_line":"        if target_version !\u003d self.VERSION:"},{"line_number":521,"context_line":"            if version_manifest is None:"},{"line_number":522,"context_line":"                self.obj_make_compatible(primitive, target_version)"},{"line_number":523,"context_line":"            else:"},{"line_number":524,"context_line":"                self.obj_make_compatible_from_manifest(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_18657c44","line":521,"in_reply_to":"da20952f_38e72042","updated":"2015-08-26 19:05:58.000000000","message":"What Ryan is suggesting is that you can replace lines 521-526 with just this:\n\n self.obj_make_compatible_from_manifest(primitive, target_version, version_manifest)","commit_id":"0e57a42726eae19e6b250ec5b052237398025be8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"28a53733d2e45c606470742df81df0189c7e3223","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                primitive[name] \u003d field.to_primitive(self, name,"},{"line_number":519,"context_line":"                                                     getattr(self, name))"},{"line_number":520,"context_line":"        if target_version !\u003d self.VERSION:"},{"line_number":521,"context_line":"            if version_manifest is None:"},{"line_number":522,"context_line":"                self.obj_make_compatible(primitive, target_version)"},{"line_number":523,"context_line":"            else:"},{"line_number":524,"context_line":"                self.obj_make_compatible_from_manifest(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_38e72042","line":521,"in_reply_to":"fa1b9901_785961fc","updated":"2015-08-26 18:53:35.000000000","message":"No, because this could still be called by old code without version_manifest. This is a library interface, so nova is, for example, still calling this without a manifest in places.","commit_id":"0e57a42726eae19e6b250ec5b052237398025be8"}]}
