)]}'
{"oslo_versionedobjects/tests/test_fields.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"1d2aee4febf0a5a8df8b98b6eb2dffc0a98a52a7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def test_stringify(self):"},{"line_number":128,"context_line":"        payload \u003d \"\"\"{\u0027admin_password\u0027:\u0027mypassword\u0027}\"\"\""},{"line_number":129,"context_line":"        expected \u003d \"\"\"\u0027{\u0027admin_password\u0027:\u0027***\u0027}\u0027\"\"\""},{"line_number":130,"context_line":"        self.assertEqual(expected, self.field.stringify(payload))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class TestVersionPredicate(TestString):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_b318ab1f","line":130,"updated":"2015-10-15 20:16:23.000000000","message":"isn\u0027t this just asserting strutils.mask_password() does what it is supposed to do? I mean, I guess this way allows it to stay close to the other test_stringify()\u0027s. You could just assert mask_password() is called. If you don\u0027t want to do it this way, you should add a test method for asserting it doesn\u0027t censor non-sensitive stuff, like your birthday. (I need to know so I can get you a present)","commit_id":"bd977f400a1192d5cf7c2b52ef91615c0828813c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3440311c705136221abddb6a522b5d4b278c9022","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def test_stringify(self):"},{"line_number":128,"context_line":"        payload \u003d \"\"\"{\u0027admin_password\u0027:\u0027mypassword\u0027}\"\"\""},{"line_number":129,"context_line":"        expected \u003d \"\"\"\u0027{\u0027admin_password\u0027:\u0027***\u0027}\u0027\"\"\""},{"line_number":130,"context_line":"        self.assertEqual(expected, self.field.stringify(payload))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class TestVersionPredicate(TestString):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_fcb4af35","line":130,"in_reply_to":"5a2ca52d_b318ab1f","updated":"2015-10-15 21:57:20.000000000","message":"It was 10/11 so you\u0027re late, thanks, way to go.\n\nWe could just mock out strutils.mask_password, but I\u0027m not sure we need to, that part of it isn\u0027t going to change.","commit_id":"bd977f400a1192d5cf7c2b52ef91615c0828813c"}]}