)]}'
{"id":"openstack%2Foslo.versionedobjects~233151","triplet_id":"openstack%2Foslo.versionedobjects~master~I56466eb8b5d8000ef010f2015f453a9e74dc66b8","project":"openstack/oslo.versionedobjects","branch":"master","topic":"bug/1321785","hashtags":[],"change_id":"I56466eb8b5d8000ef010f2015f453a9e74dc66b8","subject":"Add SensitiveString field type","status":"MERGED","created":"2015-10-09 16:05:45.000000000","updated":"2015-11-08 17:20:01.000000000","submitted":"2015-11-08 17:20:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"363d913662dc36256960d59d283a08ecf971ba3b","_number":233151,"virtual_id_number":233151,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-11-08 17:20:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2015-10-15 21:57:20.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-11-08 16:08:50.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2015-11-03 16:29:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2015-10-28 20:12:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-08 16:08:50.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-28 20:12:01.000000000","updated_by":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"reviewer":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"state":"REVIEWER"},{"updated":"2015-11-03 16:29:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2015-11-08 16:08:50.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-11-08 17:20:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1d0f56e12f1e657bb01f690ae14ab1a94ef19661","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-09 16:05:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f1b5cb778141209af0b7c9bfc8c41c62add2c3a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 17:26:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.versionedobjects-pep8 http://logs.openstack.org/51/233151/1/check/gate-oslo.versionedobjects-pep8/094ea25/ : SUCCESS in 57s\n- gate-oslo.versionedobjects-docs http://docs-draft.openstack.org/51/233151/1/check/gate-oslo.versionedobjects-docs/7d17c2d//doc/build/html/ : SUCCESS in 1m 09s\n- gate-oslo.versionedobjects-python27 http://logs.openstack.org/51/233151/1/check/gate-oslo.versionedobjects-python27/b2659b3/ : SUCCESS in 1m 09s\n- gate-oslo.versionedobjects-python34 http://logs.openstack.org/51/233151/1/check/gate-oslo.versionedobjects-python34/1a5042f/ : SUCCESS in 1m 34s\n- gate-tempest-dsvm-neutron-src-oslo.versionedobjects http://logs.openstack.org/51/233151/1/check/gate-tempest-dsvm-neutron-src-oslo.versionedobjects/fb299bb/ : SUCCESS in 1h 12m 53s","accounts_in_message":[],"_revision_number":1},{"id":"1d2aee4febf0a5a8df8b98b6eb2dffc0a98a52a7","author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"date":"2015-10-15 20:16:23.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nHopefully you\u0027re tough like SensitiveString and don\u0027t get your feelings hurt by my comment.","accounts_in_message":[],"_revision_number":1},{"id":"3440311c705136221abddb6a522b5d4b278c9022","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-15 21:57:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"34683e4fb51df67208681b5b80a36ba03cedd33a","author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"date":"2015-10-28 20:12:01.000000000","message":"Patch Set 1: Code-Review+1\n\n*deep sigh* Fiiiiine... Belated happy birthday by the way.","accounts_in_message":[],"_revision_number":1},{"id":"e38188020f8100da5ce28be5e7bb1f22d0c1d142","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-11-03 16:29:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3da5830ada37ada5a56ac5bb1fbaa4d576ef27cc","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-11-08 16:08:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"426589def7cbf9d666e98d1db9dfaecb80a40933","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-08 16:08:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4a01a0d2f3e57d8c959375bfa809e5f7dcca6efa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-08 17:20:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-oslo.versionedobjects-docs http://docs-draft.openstack.org/51/233151/1/gate/gate-oslo.versionedobjects-docs/c7a9d31//doc/build/html/ : SUCCESS in 1m 21s\n- gate-oslo.versionedobjects-pep8 http://logs.openstack.org/51/233151/1/gate/gate-oslo.versionedobjects-pep8/882352c/ : SUCCESS in 1m 11s\n- gate-oslo.versionedobjects-python27 http://logs.openstack.org/51/233151/1/gate/gate-oslo.versionedobjects-python27/aba9dda/ : SUCCESS in 1m 21s\n- gate-oslo.versionedobjects-python34 http://logs.openstack.org/51/233151/1/gate/gate-oslo.versionedobjects-python34/f33b981/ : SUCCESS in 1m 20s\n- gate-tempest-dsvm-neutron-src-oslo.versionedobjects http://logs.openstack.org/51/233151/1/gate/gate-tempest-dsvm-neutron-src-oslo.versionedobjects/13cdf79/ : SUCCESS in 1h 11m 03s","accounts_in_message":[],"_revision_number":1},{"id":"0fb0b414438afaa633d52c95d8d603c0cc5a40e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-08 17:20:01.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bd977f400a1192d5cf7c2b52ef91615c0828813c","revisions":{"bd977f400a1192d5cf7c2b52ef91615c0828813c":{"kind":"REWORK","_number":1,"created":"2015-10-09 16:05:45.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/51/233151/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.versionedobjects","ref":"refs/changes/51/233151/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/51/233151/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/51/233151/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/51/233151/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.versionedobjects refs/changes/51/233151/1"}}},"commit":{"parents":[{"commit":"e8a758907b4b427079071487d5574442bc7bbb98","subject":"Fix obj_to_primitive() when used with a manifest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/e8a758907b4b427079071487d5574442bc7bbb98"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-09 16:05:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-09 16:05:33.000000000","tz":-420},"subject":"Add SensitiveString field type","message":"Add SensitiveString field type\n\nThere are objects that define a String field to hold a serialized json\nblob and that blob can have sensitive information in it (tokens,\npasswords, etc). When the object is logged, repr will log that sensitive\ninformation. This puts a burden on the code that\u0027s doing the logging to\nremember to sanitize the object\u0027s string form before logging it.\n\nIt\u0027d be simpler and cleaner to just have a field type that extends\nString so it\u0027s the same in all respects except for when it\u0027s\nstringified. So in SensitiveString\u0027s stringify method it just masks the\npassword on the field value before returning it.\n\nAnd no SensitiveString does not play an acoustic guitar at your local\ncoffee shop, he\u0027s actually super tough and emotionally walled up, that\u0027s\nwhy he doesn\u0027t like exposing too much information about himself in the\nlogs.\n\nCloses-Bug: #1321785\n\nChange-Id: I56466eb8b5d8000ef010f2015f453a9e74dc66b8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/bd977f400a1192d5cf7c2b52ef91615c0828813c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.versionedobjects/commit/bd977f400a1192d5cf7c2b52ef91615c0828813c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}